fix static analysis issues and ftbfs

fix-sast.patch

@@ -0,0 +1,36 @@
+diff --git a/gsmclient.c b/gsmclient.c
+index fb93a5c..93e9a64 100644
+--- a/gsmclient.c
++++ b/gsmclient.c
+@@ -182,6 +182,7 @@ gsm_client_init (GsmClient *client, gpointer data)
+   char pid_str[64];
+   int   empty_vector_len = 0;
+   char *empty_vector[] = { NULL };
++  gchar *curdir;
+ 
+   (void)data;
+   client->priv = g_new (GsmClientPrivate, 1);
+@@ -197,8 +198,10 @@ gsm_client_init (GsmClient *client, gpointer data)
+   /* Default property values (this code assumes we start
+    * with an empty proplist)
+    */
++  curdir = g_get_current_dir ();
+   push_prop (client, smprop_new_string (GSM_CLIENT_PROPERTY_CURRENT_DIRECTORY,
+-                                        g_get_current_dir (), -1));
++                                        curdir, -1));
++  g_free(curdir);
+ 
+   g_snprintf (pid_str, sizeof (pid_str), "%d", (int) getpid ());
+   push_prop (client, smprop_new_string (GSM_CLIENT_PROPERTY_PROCESS_ID,
+diff --git a/shvar.c b/shvar.c
+index 0e199c6..62723db 100644
+--- a/shvar.c
++++ b/shvar.c
+@@ -348,6 +348,7 @@ svSetValue(shvarFile *s, const char *key, const char *value)
+ 	    s->modified = 1;
+ 	    goto bail; /* do not need keyValue */
+ 	}
++	else goto bail;
+ 	goto end;
+     }
+ 

usermode.spec

@@ -9,11 +9,12 @@
 Summary: Tools for certain user account management tasks
 Name: usermode
 Version: 1.114
-Release: 10%{?dist}
+Release: 12%{?dist}
 License: GPL-2.0-or-later
 URL: https://pagure.io/%{name}/
 Source: https://releases.pagure.org/%{name}/%{name}-%{version}.tar.xz
 Source1: config-util
+Patch1: fix-sast.patch
 Requires: pam, passwd, util-linux
 # https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/IJFYI5Q2BYZKIGDFS2WLOBDUSEGWHIKV/
 BuildRequires: make
@@ -53,6 +54,7 @@ graphical tools for certain account management tasks.
 
 %prep
 %setup -q
+%patch -P 1 -p 1
 
 %build
 %configure --with-selinux --without-fexecve %{!?with_gtk:--without-gtk}
@@ -87,7 +89,7 @@ done
 %files -f %{name}.lang
 %license COPYING
 %doc ChangeLog NEWS README
-%attr(4711,root,root) /usr/sbin/userhelper
+%attr(4711,root,root) /%{_sbindir}/userhelper
 %{_bindir}/consolehelper
 %{_mandir}/man8/userhelper.8*
 %{_mandir}/man8/consolehelper.8*
@@ -113,6 +115,12 @@ done
 %endif
 
 %changelog
+* Thu Jan 30 2025 Michal Hlavinka <mhlavink@redhat.com> - 1.114-12
+- fix static analysis issues and ftbfs
+
+* Sun Jan 19 2025 Fedora Release Engineering <releng@fedoraproject.org> - 1.114-11
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild
+
 * Sat Jul 20 2024 Fedora Release Engineering <releng@fedoraproject.org> - 1.114-10
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild