Update to 1.33.0 upstream release

Upstream tag: 1.33.0
Upstream commit: a47645ca

Commit authored by Packit automation (https://packit.dev/)

.gitignore

@@ -43,3 +43,6 @@
 /tmt-1.29.0.tar.gz
 /tmt-1.30.0.tar.gz
 /tmt-1.31.0.tar.gz
+/tmt-1.32.1.tar.gz
+/tmt-1.32.2.tar.gz
+/tmt-1.33.0.tar.gz

.packit.yaml

@@ -41,7 +41,7 @@ jobs:
     identifier: core
     trigger: pull_request
     targets:
-      - fedora-all
+      - fedora-latest-stable
       - epel-9
     tf_extra_params:
         test:
@@ -49,19 +49,45 @@ jobs:
                 name: /plans/features/(core|basic)
 
   # Test pull requests (full)
+  # Do not run extended unit tests, that plan gets its own job because
+  # of podman vs systemd-resolved flakiness.
   - job: tests
     identifier: full
     trigger: pull_request
-    manual_trigger: true
     targets:
       - fedora-all
       - epel-9
+    require:
+        label:
+          present:
+            - full test
+          absent:
+            - discuss
+    tf_extra_params:
+        test:
+            tmt:
+                name: '^(?!/plans/features/extended-unit-tests).*$'
+
+  - job: tests
+    identifier: extended-unit-tests
+    trigger: pull_request
+    targets:
+      - fedora-latest-stable
+    require:
+        label:
+          present:
+            - full test
+          absent:
+            - discuss
+    tf_extra_params:
+        test:
+            tmt:
+                name: '/plans/features/extended-unit-tests$'
 
   # Test pull requests (provision)
   - job: tests
     identifier: provision
     trigger: pull_request
-    manual_trigger: true
     use_internal_tf: True
     targets:
       - fedora-latest-stable
@@ -73,6 +99,12 @@ jobs:
           - tmt:
                 context:
                     how: provision
+    require:
+        label:
+          present:
+            - full test
+          absent:
+            - discuss
 
   # Test internal plugins
   - job: tests
@@ -89,6 +121,12 @@ jobs:
                 provisioning:
                     tags:
                         BusinessUnit: tmt
+    require:
+        label:
+          present:
+            - full test
+          absent:
+            - discuss
 
   # Test internal wow
   - job: tests
@@ -105,6 +143,12 @@ jobs:
                 provisioning:
                     tags:
                         BusinessUnit: tmt
+    require:
+        label:
+          present:
+            - full test
+          absent:
+            - discuss
 
   # Build commits to main
   - job: copr_build

README.packit

@@ -1,3 +1,3 @@
 This repository is maintained by packit.
 https://packit.dev/
-The file was generated using packit 0.90.0.post1.dev9+g1f0325d1.
+The file was generated using packit 0.96.0.post1.dev4+gc5b1ea8e.

dnf5-support.path

@@ -0,0 +1,66 @@
+--- tmt-1.24.1/tmt/steps/prepare/install.py.old	2023-06-22 11:57:06.633409186 +0200
++++ tmt-1.24.1/tmt/steps/prepare/install.py	2023-06-22 11:57:45.239501579 +0200
+@@ -273,6 +273,7 @@ class InstallDnf(InstallBase):
+ 
+     package_manager = "dnf"
+     copr_plugin = "dnf-plugins-core"
++    skip_missing_option = "--skip-broken"
+ 
+     def prepare_command(self) -> Tuple[Command, Command]:
+         """ Prepare installation command """
+@@ -290,7 +291,7 @@ class InstallDnf(InstallBase):
+         command += Command(self.package_manager)
+ 
+         if self.skip_missing:
+-            command += Command('--skip-broken')
++            options += Command(self.skip_missing_option)
+ 
+         return (command, options)
+ 
+@@ -356,6 +357,14 @@ class InstallDnf(InstallBase):
+             self.guest.execute(command)
+ 
+ 
++class InstallDnf5(InstallDnf):
++    """ Install packages using dnf5 """
++
++    package_manager = "dnf5"
++    copr_plugin = "dnf5-plugins"
++    skip_missing_option = "--skip-unavailable"
++
++
+ class InstallYum(InstallDnf):
+     """ Install packages using yum """
+ 
+@@ -592,6 +601,9 @@ class PrepareInstall(tmt.steps.prepare.P
+         elif guest.facts.package_manager == GuestPackageManager.DNF:
+             installer = InstallDnf(logger=logger, parent=self, guest=guest)
+ 
++        elif guest.facts.package_manager == GuestPackageManager.DNF5:
++            installer = InstallDnf5(logger=logger, parent=self, guest=guest)
++
+         elif guest.facts.package_manager == GuestPackageManager.YUM:
+             installer = InstallYum(logger=logger, parent=self, guest=guest)
+ 
+--- tmt-1.24.1/tmt/steps/provision/__init__.py.old	2023-06-22 11:56:50.556370700 +0200
++++ tmt-1.24.1/tmt/steps/provision/__init__.py	2023-06-22 11:58:00.472538032 +0200
+@@ -64,6 +64,7 @@ class CheckRsyncOutcome(enum.Enum):
+ 
+ class GuestPackageManager(enum.Enum):
+     DNF = 'dnf'
++    DNF5 = 'dnf5'
+     YUM = 'yum'
+     RPM_OSTREE = 'rpm-ostree'
+ 
+@@ -274,8 +275,9 @@ class GuestFacts(tmt.utils.SerializableC
+             guest,
+             [
+                 (Command('stat', '/run/ostree-booted'), GuestPackageManager.RPM_OSTREE),
+-                (Command('rpm', '-q', 'dnf'), GuestPackageManager.DNF),
+-                (Command('rpm', '-q', 'yum'), GuestPackageManager.YUM),
++                (Command('dnf5', '--version'), GuestPackageManager.DNF5),
++                (Command('dnf', '--version'), GuestPackageManager.DNF),
++                (Command('yum', '--version'), GuestPackageManager.YUM),
+                 # And, one day, we'd follow up on this with...
+                 # (Command('dpkg', '-l', 'apt'), 'apt')
+                 ])

sources

@@ -1 +1 @@
-SHA512 (tmt-1.31.0.tar.gz) = 339ace3550697e3e704e1f189578c7c24bc80dec3aa3bf9621b3c57eda38c16dbcaf24b476e0378ee789b9d18bb030adf72d9df2751e77acacbfdab5e8875d3f
+SHA512 (tmt-1.33.0.tar.gz) = 9a39e5f5d6aae26f3a793f8f0f5a95a3a1f323135a31babf8772d5011cc94ffda662c4b7ed3ad7fe6397452d896004051f7f8f57518cfe3c96083c10b9d97af7

tmt.spec

@@ -1,5 +1,5 @@
 Name:           tmt
-Version:        1.31.0
+Version:        1.33.0
 Release:        %autorelease
 Summary:        Test Management Tool
 
@@ -20,8 +20,6 @@ Obsoletes:      tmt-report-reportportal < %{version}-%{release}
 
 Recommends:     bash-completion
 
-%define workdir_root /var/tmp/tmt
-
 %py_provides    python3-tmt
 
 %description
@@ -126,7 +124,6 @@ mkdir -p %{buildroot}%{_mandir}/man1
 install -pm 644 tmt.1 %{buildroot}%{_mandir}/man1
 mkdir -p %{buildroot}%{_datadir}/bash-completion/completions
 install -pm 644 completions/bash/%{name} %{buildroot}%{_datadir}/bash-completion/completions/%{name}
-mkdir -pm 1777 %{buildroot}%{workdir_root}
 mkdir -p %{buildroot}/etc/%{name}/
 install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 
@@ -137,7 +134,6 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 %doc README.rst examples
 %{_bindir}/tmt
 %{_mandir}/man1/tmt.1.gz
-%dir %{workdir_root}
 %{_datadir}/bash-completion/completions/%{name}
 
 %files -n tmt+provision-container -f %{_pyproject_ghost_distinfo}
@@ -148,6 +144,122 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 %files -n tmt+all -f %{_pyproject_ghost_distinfo}
 
 %changelog
+* Tue May 07 2024 Tomáš Bajer <tbajer@redhat.com> - 1.33.0
+- Fix installation of packages from files (#2914)
+- Simplify the documentation building (#2483)
+- Install dependencies of upgrade tasks
+- Improve fail message when library doesn't exist
+- Parse the `system` hardware requirement (#2795)
+- Define `location.lab-controller` hardware requirement (#2794)
+- Test restart on crash (#2870)
+- Add `codespell` pre-commit and fix revealed errors
+- Add test restart counter, similar to `TMT_REBOOT_COUNT`
+- Fix error message if no supported package manager found
+- Fix copy/paste issue for `combine_hw_disk_size()`
+- Slightly improve rendering of ReST for command like
+- Allow `duration` in the `execute` schema
+- Log hash of the beakerlib library repo
+- Fix inability of rpm-ostree to install multiple packages (#2887)
+- Fix Alpine Linux support (#2828)
+- Allow custom failure patterns in `dmesg` test check
+- Make `junit_xml` more visible to linters
+- Add support for `virtualization.hypervisor` hardware requirement (#2733)
+- Add a new section `Review` to contributor docs
+- Accept SSH options from environment variable (#2783)
+- Fix AVC denial detection on Fedora rawhide (#2881)
+- Reuse "become" image to fix sudo-related trouble in /tests/provision/user (#2892)
+- Polish prepare/ansible documentation
+- Support `cpu.cores` hardware requirement for mrack (#2728)
+- Allow pip install from git-archive
+- Add the `cpu.vendor` hardware requirement
+- Fix incorrect translation of `cpu.processors` to Beaker
+- Document custom Jinja template filters (#2769)
+- Update logger-name for clean
+
+* Fri Apr 19 2024 Lukáš Zachar <lzachar@redhat.com> - 1.32.2
+- Remove /var/tmp workdir from rpm packaging
+- Refactor package manager discovery to allow priorities
+- Add unit test for package manager installing a file system path
+- Update pre-commit checks and add a couple of new ones
+- Removing c9s workaround for pytest-container
+- Clarify the `--last` symlink creation race a bit
+- Remove the `.travis.yml` config file
+- Correctly show the `--provision-timeout` default
+- Refresh Beaker API client in mrack to use up-to-date Kerberos ticket
+
+* Thu Mar 28 2024 Martin Hoyer <mhoyer@redhat.com> - 1.32.1
+- rpm .spec file version bump
+- Update pytest on c9s when using site-packages
+
+* Wed Mar 27 2024 Martin Hoyer <mhoyer@redhat.com> - 1.32.0
+- Support Alpine Linux `apk` package manager
+- Update the `reportportal` plugin
+- Allow `keep-git-metadata` to be used without url
+- Use `TMT_REPORT_ARTIFACTS_URL` in Polarion report plugin
+- Prepare dist-git sources using `rpmbuild -bp`
+- Add support for `zcrypt` to Beaker plugin
+- Introduce ansible-lint to format ansible files
+- Add support for linking artifacts from the report
+- Document test tags and mark beakerlib integration
+- Clarify that plan context is not applied to plan
+- Increase the default test `duration` a bit
+- Update pre-commit checks
+- Fix typos in the `tmt try` help message examples
+- Add new environment variable for test iteration identifier
+- Select no tests if `modified-only` returns nothing (#2761)
+- Debug output for `discover -h fmf --modified-only`
+- Finish unit testing of HW transformations in mrack plugin
+- Run `/plans/install/docs` in core `packit` jobs
+- Extract "package manager" functionality into plugins (#2557)
+- Allow commands whose output is not logged unless they fail
+- Move `/tests/run/shell` to `/plans/provision/local`
+- Include a simple config for the `polarion` plugin
+- Cover `report/junit` with `pyright`
+- Implement the new test check `watchdog`
+- Support `disk.driver` hw requirement for `mrack`
+- Cover `tmt.hardware` with `pyright` check
+- Bootstrap unit tests for Beaker XML transformation of HW requirements
+- Add support for emulated TPM into virtual provision plugin
+- Set default formatting of Pint units to use symbols, not names (#2736)
+- Disable IPv6 for /plans/provision/virtual in CI
+- Add support for `disk.driver` hardware requirement
+- Remove now unnecessary `NON_KVM_ADDITIONAL_WAIT` from testcloud
+- Support `disk.model-name` hw requirement for `mrack`
+- Include `context` in the test `metadata.yaml` file
+- Pass `domain_configuration` to testcloud's `wake()`
+- Document how to enable verbose/debug logging
+- Disable password authentication when using keys
+- Fix /plans/provision/virtual to set correct PROVISION_* variable
+- Log the beaker job whiteboard
+- /usr/sbin/sestatus instead of /usr/bin/sestatus (#2720)
+- Set acl permissions on the `workdir` root
+- Extend the `duration` for time-demanding tests
+- Add support for `disk.model-name` hardware requirement
+- Move deferred user stories into a separate section
+- Mark test check tests with more fitting provision tags
+- Add `Environment` and `FmfContext` among loggable types
+- Bump supported Artemis API versions to 0.0.69
+- "Show default" flag was dropped from CLI option initialization
+- Convert environment handling into a dict-like class (#2612)
+- Enable `additional_coverage` tests for pull requests (#2700)
+- Add essential requirements to checks
+- Remove mention about the full test suite from docs
+- Use the `PROVISION_HOW` variable in `provision` plans (#2688)
+- Properly detect if test is enabled somewhere
+- Check for files in `rpm-ostree install` script
+- Collect test/test check results in test invocation (#2608)
+- Test the `become` key under `virtual` provision
+- Introduce "topology" addresses for guests (#2670)
+- Make checks smarter about environments in which they should not run (#2686)
+- Cover report/display and report/html with pyright (#2682)
+- Cover `tmt.templates` with `pyright`
+- Allow custom boot/connect timeouts for testcloud VMs
+- Underline `try` menu keys
+- Drop two no longer used methods from prepare step
+- Enable the full test execution using a label (#2683)
+- Support URL as post-install-script for Artemis plugin
+- Fix dmesg check test for recent Fedoras
+
 * Tue Feb 06 2024 Michal Hlavinka <mhlavink@redhat.com> - 1.31.0
 - Simple ReST renderer for CLI help texts (#2574)
 - Generate plugin documentation from their sources (#2549)
@@ -375,7 +487,7 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 - Always show the real beaker job id
 - Create a production copr build for each release
 - AVC denials check for tests (#2331)
-- Add nice & colorfull help to "make" targets
+- Add nice & colorful help to "make" targets
 - Include more dependencies in the dev environment
 - Stop using the `_version.py` file
 - Replace `opt()` for `--dry/--force` with properties
@@ -794,7 +906,7 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 - Prune irrelevant files during the `finish` step
 - Add junit plugin schema
 - Support to import empty key from Makefile
-- Deleting unsed and duplicite part of finish step
+- Deleting unused and duplicite part of finish step
 - Support absolute paths in HTML reports
 - Capture exceptions when getting `image_url`
 - Enable verbose output for `provision` & `prepare`
@@ -1037,8 +1149,8 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 - Remove duplicated short option in tmt lint
 - Adjust the `rstrnt-report-result` implementation
 - Backwards compatibility for `rstrnt-report-result`
-- Set the `1777` permision for `/var/tmp/tmt`
-- Adjust the fix for the `rpm-ostree` intallation
+- Set the `1777` permission for `/var/tmp/tmt`
+- Adjust the fix for the `rpm-ostree` installation
 - Fix package installation using `rpm-ostree`
 - Handle empty fmf file as an empty dictionary
 - Fix distgit testsuite after tmt packaging change
@@ -1260,7 +1372,7 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 - Require beakerlib-1.28 for beakerlib tests
 - Adjust the dist git source discover implementation
 - Discover tmt tests from sources
-- Reenable plans/install/docs
+- Re-enable plans/install/docs
 - Correct the `playbook` attribute in the spec (#948)
 - Ansible plugin for Finish step
 - Thread processing of executed commands inside tmt
@@ -1529,7 +1641,7 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 - Strip whitespace before relevancy comment
 - Ensure rsync is installed on the guest if needed
 - Use the default branch in the discover fmf plugin
-- Suport the 'el' shortcut for the distro context
+- Support the 'el' shortcut for the distro context
 - Implement the 'tmt --version' option [fix #445]
 - Adjust test create test, fix missing dots
 - Support creating tests in the current directory
@@ -1839,7 +1951,7 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 - Add a story and examples describing manual tests
 - Sync more extra-* attributes when exporting [#199]
 - Enable checks for essential test attributes
-- Handle require in Dicovery
+- Handle require in Discovery
 - Store imported metadata in a sane order [fix #86]
 - Enable Python 3.8 in Travis, update classifiers
 - Add missing 'require' attribute to the Test class
@@ -1850,7 +1962,7 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 - Merge improved import of tier from tags [#187]
 - Adjust tier import from test case tags
 - Merge tmt test export --nitrate --create [#185]
-- Adjust suppport for creating new nitrate testcases
+- Adjust support for creating new nitrate testcases
 - Allow creation of nitrate cases when exporting
 - Create tier attribute from multiple Tier tags
 - Fix run.sh to work with RHEL/CentOS 7 as well
@@ -2109,7 +2221,7 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 - Enable bash completion feature
 
 * Thu Oct 17 2019 Petr Šplíchal <psplicha@redhat.com> - 0.4-1
-- Add tests for 'tmt init', allow overwritting
+- Add tests for 'tmt init', allow overwriting
 - Use plural commands to prevent confusion [fix #10]
 - Add a link to Packit & Testing Farm documentation
 - Add a simple develop section to the readme
@@ -2134,7 +2246,7 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 - Add a story for the mock shortcut [fix #5, fix #6]
 - Add a story for core option --format
 - Propose a dream for hands-free debugging
-- Rename remaining testset occurences to plan
+- Rename remaining testset occurrences to plan
 - Implement 'tmt plan lint' with initial checks
 
 * Thu Oct 10 2019 Petr Šplíchal <psplicha@redhat.com> - 0.3-1
@@ -2152,7 +2264,7 @@ install -pm 644 %{name}/steps/provision/mrack/mrack* %{buildroot}/etc/%{name}/
 - Provide one-letter versions for select options
 - Implement 'tmt run --all' to run all test steps
 - Support command abbreviation, add related stories
-- Add the Quick Start Guide story to documention
+- Add the Quick Start Guide story to documentation
 - Add coverage options to tmt story ls and show
 - Initialize metadata tree only when accessed
 - Remove show functionality from the 'run' command