Don't use filelock to test this package on RHEL

Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>

.gitignore

@@ -15,3 +15,31 @@
 /Sphinx-1.7.2.tar.gz
 /Sphinx-1.7.5.tar.gz
 /Sphinx-1.7.6.tar.gz
+/Sphinx-1.8.4.tar.gz
+/Sphinx-2.0.0b1.tar.gz
+/Sphinx-2.0.0b2.tar.gz
+/Sphinx-2.0.1.tar.gz
+/Sphinx-2.1.2.tar.gz
+/Sphinx-2.2.0.tar.gz
+/Sphinx-2.2.2.tar.gz
+/Sphinx-3.1.1.tar.gz
+/Sphinx-3.1.2.tar.gz
+/Sphinx-3.2.1.tar.gz
+/Sphinx-3.3.1.tar.gz
+/Sphinx-3.4.3.tar.gz
+/Sphinx-3.5.2.tar.gz
+/Sphinx-3.5.3.tar.gz
+/Sphinx-3.5.4.tar.gz
+/Sphinx-4.0.2.tar.gz
+/Sphinx-4.1.2.tar.gz
+/Sphinx-4.2.0.tar.gz
+/Sphinx-4.3.0.tar.gz
+/Sphinx-4.3.1.tar.gz
+/Sphinx-4.4.0.tar.gz
+/Sphinx-4.5.0.tar.gz
+/Sphinx-5.0.2.tar.gz
+/Sphinx-5.1.1.tar.gz
+/Sphinx-5.2.3.tar.gz
+/Sphinx-5.3.0.tar.gz
+/Sphinx-6.1.3.tar.gz
+/Sphinx-6.2.1.tar.gz

README.fedora

@@ -1,27 +0,0 @@
-Sphinx with autodoc is sensitive to whether it is run via Python2 or Python3
-as it uses the Python version that it is invoked with to parse the source
-files for docstrings.  Unfortunately, there's no logic to detect this within
-the sphinx commands and the standard Makefiles generated by sphinx-quickstart
-don't give the user any hint that it might be a problem.
-
-The Fedora package tries to mitigate this problem by allowing the user to
-switch between the Python2 and Python3 versions using environment-modules.  To
-switch to the Python3 commands, use::
-
-    module swap python-sphinx/python3-sphinx
-
-To switch to the Python2 version, use::
-
-    module swap python-sphinx/python2-sphinx
-
-The default install uses the python2 version of the modules.
-If the system administrator wishes to change the default, edit the
-/etc/profile.d/zz-modules-python-sphinx.sh and
-/etc/profile.d/zz-modules-python-sphinx.csh files to specify a specific
-alternative to use.  For instance, to make the python3 version the default,
-modify it like so::
-
-    @@ -1,2 +1,2 @@
-     # Add path to the default python-sphinx scripts on this version of Fedora
-    -module load python-sphinx
-    +module load python-sphinx/python3-sphinx

default-sphinx-command.in

@@ -1,2 +0,0 @@
-#%Module1.0
-set ModuleVersion  "python@PYTHONVER@-sphinx"

python-sphinx.spec

@@ -1,164 +1,103 @@
-%if 0%{?fedora} || 0%{?rhel} > 7
-%global with_python3 1
-%else
-%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print (get_python_lib())")}
-%endif
-
-%if 0%{?rhel} > 7
-# Build without BuildRequires ImageMagick, to skip imgconverter tests
-%bcond_with imagemagick_tests
-%else
-%bcond_without imagemagick_tests
-%endif
-
-# When bootstrapping sphinx, we don't yet have sphinxcontrib-websupport
-%bcond_without websupport
+# When bootstrapping sphinx in Fedora, we don't yet have sphinxcontrib-websupport
+# Without it we have warnings in docs, but it's not a hard dependency
+# We don't want to support sphinxcontrib-websupport in RHEL, hence disabling the dependency
+%bcond websupport %{undefined rhel}
 # Also, we don't have all the tests requirements
-%bcond_without tests
+%bcond tests 1
 
-# Currently, python2 version is always the default: https://fedoraproject.org/wiki/Packaging:Python#Naming
-%if 1
-%global py3_default 0
-%else
-%global py3_default 1
-%endif
+# Unset -s on python shebang to allow RPM-installed sphinx to be used
+# with user-installed modules (#1903763)
+%undefine _py3_shebang_s
+
+# No internet in Koji
+%bcond internet 0
+
+# Build without BuildRequires ImageMagick, to skip imgconverter tests
+%bcond imagemagick_tests %{undefined rhel}
+# Same for filelock -- we don't want it in RHEL just to run a handful of tests here
+%bcond filelock_tests %{undefined rhel}
+
+# During texlive updates, sometimes the latex environment is unstable
+%bcond latex_tests 1
 
 %global upstream_name Sphinx
 
 Name:       python-sphinx
-Version:    1.7.6
-Release:    1%{?dist}
+%global     general_version 6.2.1
+#global     prerel ...
+%global     upstream_version %{general_version}%{?prerel}
+Version:    %{general_version}%{?prerel:~%{prerel}}
+Release:    4%{?dist}
 Epoch:      1
 Summary:    Python documentation generator
 
-Group:      Development/Tools
+# Unless otherwise noted, the license for code is BSD-2-Clause
+# sphinx/themes/haiku/static/haiku.css_t has bits licensed with MIT
+License:    BSD-2-Clause AND MIT
 
-# Unless otherwise noted, the license for code is BSD
-# sphinx/util/stemmer.py Public Domain
-# sphinx/pycode/pgen2 Python
-# jquery (MIT or GPLv2)
-License:    BSD and Public Domain and Python and (MIT or GPLv2)
-URL:        http://sphinx-doc.org/
-Source0:    https://files.pythonhosted.org/packages/source/S/%{upstream_name}/%{upstream_name}-%{version}.tar.gz
-Source1:    python2-sphinx
-Source2:    python3-sphinx
-Source3:    zz-modules-python-sphinx.sh
-Source4:    zz-modules-python-sphinx.csh
-Source5:    README.fedora
-# environment-modules file to select whether the py2 or py3 version of
-# python-sphinx execuitables is default
-Source6:    default-sphinx-command.in
+URL:        https://www.sphinx-doc.org/
+Source:     %{pypi_source %{upstream_name} %{upstream_version}}
 
-# Make the test_latex_remote_images an expected failure
-# since it requires an active internet connection
-# to fetch images, which is not possible in koji or mock.
-Patch0: xfail-test_latex_remote_images.patch
-
-# Allow extra themes to exist. We pull in python[23]-sphinx-theme-alabaster
+# Allow extra themes to exist. We pull in python3-sphinx-theme-alabaster
 # which causes that test to fail.
-Patch1: sphinx-test_theming.diff
+Patch:      sphinx-test_theming.diff
+
 
 BuildArch:     noarch
-BuildRequires: python2-devel >= 2.4
-BuildRequires: python2-babel
-BuildRequires: python2-setuptools
-BuildRequires: python2-docutils
-BuildRequires: python2-jinja2
-BuildRequires: python2-pygments >= 2.0
-BuildRequires: python2-six
-BuildRequires: python2-sphinx_rtd_theme
-BuildRequires: python2-sphinx-theme-alabaster
-BuildRequires: python2-imagesize
-BuildRequires: python2-requests
-BuildRequires: python2-packaging
-BuildRequires: python2-typing
-%if %{with websupport}
-BuildRequires: python2-sphinxcontrib-websupport
-%endif
-BuildRequires: environment(modules)
 
-# for fixes
-BuildRequires: dos2unix
+BuildRequires: make
+BuildRequires: python%{python3_pkgversion}-devel
+BuildRequires: pyproject-rpm-macros
+
+%if %{with websupport}
+BuildRequires: python%{python3_pkgversion}-sphinxcontrib-websupport
+%endif
 
 %if %{with tests}
-BuildRequires: python2-nose
-BuildRequires: python2-pytest
-BuildRequires: python2-pytest-cov
+# tests import _testcapi
+BuildRequires: python%{python3_pkgversion}-test
+
+BuildRequires: gcc
 BuildRequires: gettext
-BuildRequires: texinfo
 BuildRequires: graphviz
-BuildRequires: python2-sqlalchemy
-BuildRequires: python2-mock
-BuildRequires: python2-html5lib
-BuildRequires: python2-whoosh
-BuildRequires: python2-snowballstemmer
-BuildRequires: python2-enum34
+BuildRequires: texinfo
+
 %if %{with imagemagick_tests}
 BuildRequires: ImageMagick
 %endif
+
+%if %{with latex_tests}
 BuildRequires: texlive-collection-fontsrecommended
 BuildRequires: texlive-collection-latex
 BuildRequires: texlive-dvipng
 BuildRequires: texlive-dvisvgm
-BuildRequires: texlive-ucs
-BuildRequires: tex(cmap.sty)
-BuildRequires: tex(ecrm1000.tfm)
-BuildRequires: tex(footnote.sty)
-BuildRequires: tex(framed.sty)
-BuildRequires: tex(multirow.sty)
-BuildRequires: tex(parskip.sty)
-BuildRequires: tex(titlesec.sty)
-BuildRequires: tex(threeparttable.sty)
-BuildRequires: tex(upquote.sty)
-BuildRequires: tex(wrapfig.sty)
-BuildRequires: tex(capt-of.sty)
-BuildRequires: tex(needspace.sty)
-BuildRequires: tex(eqparbox.sty)
 BuildRequires: tex(amsmath.sty)
 BuildRequires: tex(amsthm.sty)
-BuildRequires: tex(amssymb.sty)
-BuildRequires: tex(amsfonts.sty)
-BuildRequires: tex(bm.sty)
-BuildRequires: tex(palatino.sty)
-BuildRequires: tex(multirow.sty)
-BuildRequires: tex(eqparbox.sty)
-BuildRequires: tex(atbegshi.sty)
 BuildRequires: tex(anyfontsize.sty)
-BuildRequires: tex(luatex85.sty)
-BuildRequires: tex(fncychap.sty)
-BuildRequires: tex(tabulary.sty)
-BuildRequires: tex(polyglossia.sty)
+BuildRequires: tex(article.cls)
+BuildRequires: tex(capt-of.sty)
+BuildRequires: tex(cmap.sty)
+BuildRequires: tex(color.sty)
 BuildRequires: tex(ctablestack.sty)
-BuildRequires: tex(eu1enc.def)
+BuildRequires: tex(fancyhdr.sty)
+BuildRequires: tex(fancyvrb.sty)
+BuildRequires: tex(fncychap.sty)
+BuildRequires: tex(framed.sty)
+BuildRequires: tex(FreeSerif.otf)
+BuildRequires: tex(geometry.sty)
+BuildRequires: tex(hyperref.sty)
+BuildRequires: tex(kvoptions.sty)
+BuildRequires: tex(luatex85.sty)
+BuildRequires: tex(needspace.sty)
+BuildRequires: tex(parskip.sty)
+BuildRequires: tex(polyglossia.sty)
+BuildRequires: tex(tabulary.sty)
+BuildRequires: tex(titlesec.sty)
+BuildRequires: tex(upquote.sty)
+BuildRequires: tex(utf8x.def)
+BuildRequires: tex(wrapfig.sty)
 %endif
-
-%if 0%{?with_python3}
-BuildRequires: python3-devel
-BuildRequires: python3-babel
-BuildRequires: python3-setuptools
-BuildRequires: python3-docutils
-BuildRequires: python3-jinja2
-BuildRequires: python3-pygments
-BuildRequires: python3-six
-BuildRequires: python3-sphinx_rtd_theme
-BuildRequires: python3-sphinx-theme-alabaster
-BuildRequires: python3-packaging
-BuildRequires: python3-imagesize
-BuildRequires: python3-requests
-%if %{with websupport}
-BuildRequires: python3-sphinxcontrib-websupport
 %endif
-%if %{with tests}
-BuildRequires: python3-nose
-BuildRequires: python3-pytest
-BuildRequires: python3-pytest-cov
-BuildRequires: python3-sqlalchemy
-BuildRequires: python3-mock
-BuildRequires: python3-html5lib
-BuildRequires: python3-whoosh
-BuildRequires: python3-snowballstemmer
-%endif
-%endif # with_python3
 
 
 %description
@@ -190,41 +129,14 @@ the Python docs:
       snippets and inclusion of appropriately formatted docstrings.
 
 
-%package -n    python2-sphinx
+%package -n python%{python3_pkgversion}-sphinx
 Summary:       Python documentation generator
-Requires:      python-sphinx-locale = %{?epoch}:%{version}-%{release}
-Requires:      python2-babel
-Requires:      python2-docutils
-Requires:      python2-jinja2
-Requires:      python2-pygments
-Requires:      python2-mock
-Requires:      python2-snowballstemmer
-Requires:      python2-sphinx_rtd_theme
-Requires:      python2-six
-Requires:      python2-sphinx-theme-alabaster
-Requires:      python2-imagesize
-Requires:      python2-requests
-Requires:      python2-packaging
-Requires:      python2-typing
-%if %{with websupport}
-Requires:      python2-sphinxcontrib-websupport
-%endif
-Requires: environment(modules)
-# Needed to get rid of the alternatives config installed in f24 and f25
-# versions of the package
-Requires(pre): /usr/sbin/alternatives
+
 Recommends:    graphviz
 Recommends:    ImageMagick
-Obsoletes:     python-sphinx <= 1.2.3
-Obsoletes:     python-sphinxcontrib-napoleon < 0.5
-Provides:      python-sphinxcontrib-napoleon = %{?epoch}:%{version}-%{release}
-Obsoletes:     python2-Sphinx <= 1.3.1-4
-Provides:      python2-Sphinx = %{?epoch}:%{version}-%{release}
-Provides:      python(Sphinx) = %{?epoch}:%{version}-%{release}
-%{?python_provide:%python_provide python2-sphinx}
-Conflicts:     python3-sphinx < %{?epoch}:%{version}-%{release}
 
-%description -n python2-sphinx
+
+%description -n python%{python3_pkgversion}-sphinx
 Sphinx is a tool that makes it easy to create intelligent and
 beautiful documentation for Python projects (or other documents
 consisting of multiple reStructuredText sources), written by Georg
@@ -253,46 +165,44 @@ the Python docs:
       snippets and inclusion of appropriately formatted docstrings.
 
 
-%package latex
-Summary:       LaTeX builder dependencies for %{name}
-Requires:      python(Sphinx) = %{?epoch}:%{version}-%{release}
+%package -n python%{python3_pkgversion}-sphinx-latex
+Summary:       LaTeX builder dependencies for python%{python3_pkgversion}-sphinx
+
+Requires:      python%{python3_pkgversion}-sphinx = %{epoch}:%{version}-%{release}
 Requires:      texlive-collection-fontsrecommended
 Requires:      texlive-collection-latex
 Requires:      texlive-dvipng
 Requires:      texlive-dvisvgm
-Requires:      texlive-ucs
-Requires:      tex(cmap.sty)
-Requires:      tex(ecrm1000.tfm)
-Requires:      tex(footnote.sty)
-Requires:      tex(framed.sty)
-Requires:      tex(multirow.sty)
-Requires:      tex(parskip.sty)
-Requires:      tex(titlesec.sty)
-Requires:      tex(threeparttable.sty)
-Requires:      tex(upquote.sty)
-Requires:      tex(wrapfig.sty)
-Requires:      tex(capt-of.sty)
-Requires:      tex(needspace.sty)
-Requires:      tex(eqparbox.sty)
 Requires:      tex(amsmath.sty)
 Requires:      tex(amsthm.sty)
-Requires:      tex(amssymb.sty)
-Requires:      tex(amsfonts.sty)
-Requires:      tex(bm.sty)
-Requires:      tex(palatino.sty)
-Requires:      tex(multirow.sty)
-Requires:      tex(eqparbox.sty)
-Requires:      tex(atbegshi.sty)
 Requires:      tex(anyfontsize.sty)
-Requires:      tex(luatex85.sty)
-Requires:      tex(fncychap.sty)
-Requires:      tex(tabulary.sty)
-Requires:      tex(polyglossia.sty)
+Requires:      tex(article.cls)
+Requires:      tex(capt-of.sty)
+Requires:      tex(cmap.sty)
+Requires:      tex(color.sty)
 Requires:      tex(ctablestack.sty)
-Requires:      tex(eu1enc.def)
-Obsoletes:     python3-sphinx-latex < 1.4.4-2
+Requires:      tex(fancyhdr.sty)
+Requires:      tex(fancyvrb.sty)
+Requires:      tex(fncychap.sty)
+Requires:      tex(framed.sty)
+Requires:      tex(FreeSerif.otf)
+Requires:      tex(geometry.sty)
+Requires:      tex(hyperref.sty)
+Requires:      tex(kvoptions.sty)
+Requires:      tex(luatex85.sty)
+Requires:      tex(needspace.sty)
+Requires:      tex(parskip.sty)
+Requires:      tex(polyglossia.sty)
+Requires:      tex(tabulary.sty)
+Requires:      tex(titlesec.sty)
+Requires:      tex(upquote.sty)
+Requires:      tex(utf8x.def)
+Requires:      tex(wrapfig.sty)
 
-%description latex
+# No files in this package, automatic provides don't work:
+%py_provides   python%{python3_pkgversion}-sphinx-latex
+
+%description  -n python%{python3_pkgversion}-sphinx-latex
 Sphinx is a tool that makes it easy to create intelligent and
 beautiful documentation for Python projects (or other documents
 consisting of multiple reStructuredText sources), written by Georg
@@ -304,73 +214,10 @@ This package pulls in the TeX dependencies needed by Sphinx's LaTeX
 builder.
 
 
-%if 0%{?with_python3}
-%package -n python3-sphinx
-Summary:       Python documentation generator
-Group:         Development/Tools
-Requires:      python-sphinx-locale = %{?epoch}:%{version}-%{release}
-Requires:      python3-babel
-Requires:      python3-docutils
-Requires:      python3-jinja2
-Requires:      python3-pygments
-Requires:      python3-mock
-Requires:      python3-snowballstemmer
-Requires:      python3-sphinx_rtd_theme
-Requires:      python3-sphinx-theme-alabaster
-Requires:      python3-imagesize
-Requires:      python3-requests
-Requires:      python3-six
-Requires:      python3-packaging
-%if %{with websupport}
-Requires:      python3-sphinxcontrib-websupport
-%endif
-Recommends:    graphviz
-Recommends:    ImageMagick
-Requires: environment(modules)
-# Needed to get rid of the alternatives config installed in f24 and f25
-# versions of the package
-Requires(pre): /usr/sbin/alternatives
-Obsoletes:     python3-sphinxcontrib-napoleon < 0.3.0
-Provides:      python3-sphinxcontrib-napoleon = %{?epoch}:%{version}-%{release}
-Provides:      python(Sphinx) = %{?epoch}:%{version}-%{release}
-%{?python_provide:%python_provide python3-sphinx}
-Conflicts:     python2-Sphinx < %{?epoch}:%{version}-%{release}
-
-%description -n python3-sphinx
-Sphinx is a tool that makes it easy to create intelligent and
-beautiful documentation for Python projects (or other documents
-consisting of multiple reStructuredText sources), written by Georg
-Brandl. It was originally created to translate the new Python
-documentation, but has now been cleaned up in the hope that it will be
-useful to many other projects.
-
-Sphinx uses reStructuredText as its markup language, and many of its
-strengths come from the power and straightforwardness of
-reStructuredText and its parsing and translating suite, the Docutils.
-
-Although it is still under constant development, the following
-features are already present, work fine and can be seen "in action" in
-the Python docs:
-
-    * Output formats: HTML (including Windows HTML Help) and LaTeX,
-      for printable PDF versions
-    * Extensive cross-references: semantic markup and automatic links
-      for functions, classes, glossary terms and similar pieces of
-      information
-    * Hierarchical structure: easy definition of a document tree, with
-      automatic links to siblings, parents and children
-    * Automatic indices: general index as well as a module index
-    * Code handling: automatic highlighting using the Pygments highlighter
-    * Various extensions are available, e.g. for automatic testing of
-      snippets and inclusion of appropriately formatted docstrings.
-%endif # with_python3
-
-
 %package doc
 Summary:       Documentation for %{name}
-Group:         Documentation
-License:       BSD
-Requires:      python(Sphinx) = %{?epoch}:%{version}-%{release}
+License:       BSD-2-Clause
+Recommends:    python%{python3_pkgversion}-sphinx = %{epoch}:%{version}-%{release}
 
 %description doc
 Sphinx is a tool that makes it easy to create intelligent and
@@ -380,119 +227,76 @@ Brandl. It was originally created to translate the new Python
 documentation, but has now been cleaned up in the hope that it will be
 useful to many other projects.
 
-This package contains documentation in reST and HTML formats.
+This package contains documentation in the HTML format.
 
 
-%package locale
-Summary:       Locale files for %{name}
-Group:         Development/Tools
-License:       BSD
-
-%description locale
-Sphinx is a tool that makes it easy to create intelligent and
-beautiful documentation for Python projects (or other documents
-consisting of multiple reStructuredText sources), written by Georg
-Brandl. It was originally created to translate the new Python
-documentation, but has now been cleaned up in the hope that it will be
-useful to many other projects.
-
-This package contains locale files for Sphinx
-
 %prep
-%autosetup -n %{upstream_name}-%{version}%{?prerel} -p1
-
-cp %{SOURCE5} .
-
-# fix line encoding of bundled jquery.js
-dos2unix -k ./sphinx/themes/basic/static/jquery.js
+%autosetup -n %{upstream_name}-%{upstream_version} -p1
 
 %if %{without imagemagick_tests}
 rm tests/test_ext_imgconverter.py
 %endif
 
-%if %{without websupport}
-rm tests/test_websupport.py tests/test_api_translator.py
+%if %{without filelock_tests}
+sed -i '/filelock/d' pyproject.toml
+rm tests/test_build_linkcheck.py tests/test_ext_intersphinx.py
 %endif
 
-%if 0%{?with_python3}
-rm -rf %{py3dir}
-cp -a . %{py3dir}
-%endif # with_python3
+%if %{defined rhel}
+# unwanted dependency in RHEL, https://bugzilla.redhat.com/show_bug.cgi?id=1945182
+sed -i '/html5lib/d' pyproject.toml
+%endif
+
+%generate_buildrequires
+%pyproject_buildrequires -r %{?with_tests:-x test}
+
 
 %build
-%py2_build
-%if 0%{?with_python3}
-%py3_build
-%endif # with_python3
+%pyproject_wheel
 
 export PYTHONPATH=$PWD
 pushd doc
-%if 0%{?with_python3}
-export SPHINXBUILD="%{__python3} ../sphinx/cmd/build.py"
-%else
-export SPHINXBUILD="%{__python2} ../sphinx/cmd/build.py"
-%endif
-
+export SPHINXBUILD="%{python3} ../sphinx/cmd/build.py"
 make html SPHINXBUILD="$SPHINXBUILD"
 make man SPHINXBUILD="$SPHINXBUILD"
 rm -rf _build/html/.buildinfo
+# Those files are copied to _build/html/_images and loaded to the
+# html pages from there - we can safely remove the duplicated and unused files
+rm -rf _build/html/_static/themes _build/html/_static/tutorial
+rm -f _build/html/_static/more.png _build/html/_static/translation.svg
 mv _build/html ..
 popd
 
 
 %install
-%if 0%{?with_python3}
-%py3_install
-install -d %{buildroot}%{_libexecdir}/python3-sphinx
-for i in sphinx-{apidoc,autogen,build,quickstart}; do
-    mv %{buildroot}%{_bindir}/$i %{buildroot}%{_bindir}/$i-%{python3_version}
-    ln -s $i-%{python3_version} %{buildroot}%{_bindir}/$i-3
-    ln -s %{_bindir}/$i-3 %{buildroot}%{_libexecdir}/python3-sphinx/$i
-done
-%endif # with_python3
+%pyproject_install
 
-%py2_install
-install -d %{buildroot}%{_libexecdir}/python2-sphinx
+# For backwards compatibility. Remove with care, if at all
 for i in sphinx-{apidoc,autogen,build,quickstart}; do
-    mv %{buildroot}%{_bindir}/$i %{buildroot}%{_bindir}/$i-%{python2_version}
-    ln -s $i-%{python2_version} %{buildroot}%{_bindir}/$i-2
-    ln -s %{_bindir}/$i-2 %{buildroot}%{_libexecdir}/python2-sphinx/$i
+    ln -s %{_bindir}/$i %{buildroot}%{_bindir}/$i-%{python3_version}
+    ln -s %{_bindir}/$i %{buildroot}%{_bindir}/$i-3
 done
 
+# Clean up non-python files
+rm -f %{buildroot}%{python3_sitelib}/sphinx/locale/.DS_Store
+rm -rf %{buildroot}%{python3_sitelib}/sphinx/locale/.tx
+
 pushd doc
 # Deliver man pages
 install -d %{buildroot}%{_mandir}/man1
 for f in _build/man/sphinx-*.1;
 do
-    ### TODO: these are all the same.  Do we really need to ship them three
-    ### times or is it fine to just ship them as e.g. sphinx-build.1
     cp -p $f %{buildroot}%{_mandir}/man1/$(basename $f)
-    cp -p $f %{buildroot}%{_mandir}/man1/$(basename $f | sed -e "s|.1$|-%{python2_version}.1|")
-    cp -p $f %{buildroot}%{_mandir}/man1/$(basename $f | sed -e "s|.1$|-%{python3_version}.1|")
 done
-
-# Remove language files, they're identical to the ones from the
-# Python 2 build that will be moved to /usr/share below
-find %{buildroot}%{python3_sitelib}/sphinx/locale -maxdepth 1 -mindepth 1 -type d -not -path '*/\.*' -exec rm -rf '{}' \;
 popd
 
-# Clean up non-python files
-rm -f %{buildroot}%{python2_sitelib}/sphinx/locale/.DS_Store
-rm -rf %{buildroot}%{python2_sitelib}/sphinx/locale/.tx
-rm -f %{buildroot}%{python3_sitelib}/sphinx/locale/.DS_Store
-rm -rf %{buildroot}%{python3_sitelib}/sphinx/locale/.tx
-
-# Deliver rst files
-rm -rf doc/_build
-sed -i 's|python ../sphinx-build.py|/usr/bin/sphinx-build|' doc/Makefile
-mv doc reST
-
 # Move language files to /usr/share;
 # patch to support this incorporated in 0.6.6
-pushd %{buildroot}%{python2_sitelib}
+pushd %{buildroot}%{python3_sitelib}
 
 for lang in `find sphinx/locale -maxdepth 1 -mindepth 1 -type d -not -path '*/\.*' -printf "%f "`;
 do
+  test $lang == __pycache__ && continue
   install -d %{buildroot}%{_datadir}/sphinx/locale/$lang
   install -d %{buildroot}%{_datadir}/locale/$lang/LC_MESSAGES
   mv sphinx/locale/$lang/LC_MESSAGES/sphinx.js \
@@ -503,36 +307,9 @@ do
 done
 popd
 
-install -d %{buildroot}%{_modulesdir}/python-sphinx
-install -m 0644 %{SOURCE1} %{buildroot}%{_modulesdir}/python-sphinx/
-sed -i 's|@python2_sphinx_dir@|%{_libexecdir}/python2-sphinx|' %{buildroot}%{_modulesdir}/python-sphinx/python2-sphinx
-install -m 0644 %{SOURCE2} %{buildroot}%{_modulesdir}/python-sphinx/
-sed -i 's|@python3_sphinx_dir@|%{_libexecdir}/python3-sphinx|' %{buildroot}%{_modulesdir}/python-sphinx/python3-sphinx
-install -d %{buildroot}%{_sysconfdir}/profile.d
-install -m 0644 %{SOURCE3} %{buildroot}%{_sysconfdir}/profile.d/zz-modules-python-sphinx.sh
-install -m 0644 %{SOURCE4} %{buildroot}%{_sysconfdir}/profile.d/zz-modules-python-sphinx.csh
-
-%if %{py3_default}
-sed 's/@PYTHONVER@/3/' < %{SOURCE6} > %{buildroot}%{_modulesdir}/python-sphinx/.version
-
-# These symlinks establish a default for when a package is first installed (and
-# therefore, environment modules is not loaded).  The user can immediately
-# switch them by using module swap python-sphinx/python2-sphinx
-for filename in sphinx-{build,apidoc,autogen,quickstart} ; do
-  ln -s %{_libexecdir}/python3-sphinx/$filename %{buildroot}%{_bindir}/$filename
-done
-
-%else
-sed 's/@PYTHONVER@/2/' < %{SOURCE6} > %{buildroot}%{_modulesdir}/python-sphinx/.version
-
-# These symlinks establish a default for when a package is first installed (and
-# therefore, environment modules is not loaded).  The user can immediately
-# switch them by using module swap python-sphinx/python3-sphinx
-for filename in sphinx-{build,apidoc,autogen,quickstart} ; do
-  ln -s %{_libexecdir}/python2-sphinx/$filename %{buildroot}%{_bindir}/$filename
-done
-
-%endif
+# Create the sphinxcontrib directory, so we can own it
+# See https://bugzilla.redhat.com/show_bug.cgi?id=1669790 for rationale
+mkdir %{buildroot}%{python3_sitelib}/sphinxcontrib
 
 %find_lang sphinx
 
@@ -545,79 +322,251 @@ done
 
 %if %{with tests}
 %check
-export PYTHONPATH=$PWD
-
-# Currently, all linkcheck tests hit external websites.  Since network access
-# is disabled in koji, we have to disable these.
-rm tests/test_build_linkcheck.py
-
-# Igoring test_api_translator for now as it fails on Fedora.
-# The issue has been reported upstream: https://github.com/sphinx-doc/sphinx/issues/4710
-LANG=en_US.UTF-8 %{__python2} -m pytest -v --ignore=tests/test_api_translator.py
-%if 0%{?with_python3}
-pushd %{py3dir}
-# Currently, all linkcheck tests hit external websites.  Since network access
-# is disabled in koji, we have to disable these.
-rm tests/test_build_linkcheck.py
-LANG=en_US.UTF-8 PYTHON=python3 make test
-popd
-%endif # with_python3
-%endif # with tests
+# Currently, all linkcheck tests and test_latex_images need internet
+# test_build_latex_doc needs internet to download pictures,
+# but fails also with it enabled, we decided to skip it entirely
+# In RHEL builds, skip tests which use html5lib (excluded above)
+%pytest \
+%if %{defined rhel}
+    --ignore tests/test_build_html.py \
+    --ignore tests/test_build_latex.py \
+    --ignore tests/test_build_texinfo.py \
+    --ignore tests/test_domain_std.py \
+    --ignore tests/test_smartquotes.py \
+%endif
+%if %{without internet}
+    -k "not linkcheck and not test_latex_images and not test_build_latex_doc" \
+%endif
+;
+%endif
 
 
-%files latex
-%license LICENSE
-
-%files locale -f sphinx.lang
+%files -n python%{python3_pkgversion}-sphinx -f sphinx.lang
 %license LICENSE
+%doc AUTHORS CHANGES EXAMPLES README.rst
+%{_bindir}/sphinx-*
+%{python3_sitelib}/sphinx/
+%dir %{python3_sitelib}/sphinxcontrib/
+%{python3_sitelib}/sphinx-%{upstream_version}.dist-info/
 %dir %{_datadir}/sphinx/
 %dir %{_datadir}/sphinx/locale
 %dir %{_datadir}/sphinx/locale/*
+%{_mandir}/man1/sphinx-*
 
-%files -n python2-sphinx
-%license LICENSE
-%doc AUTHORS CHANGES EXAMPLES README.rst README.fedora
-%{_bindir}/sphinx-*-2*
-%{_bindir}/sphinx-build
-%{_bindir}/sphinx-apidoc
-%{_bindir}/sphinx-autogen
-%{_bindir}/sphinx-quickstart
-%{python2_sitelib}/sphinx/
-%{python2_sitelib}/Sphinx-%{version}-py%{python2_version}.egg-info/
-%exclude %{_mandir}/man1/sphinx-*-%{python3_version}.1*
-%{_mandir}/man1/*
-%{_libexecdir}/python2-sphinx/
-%{_modulesdir}/python-sphinx/python2-sphinx
-%if !%{py3_default}
-%{_modulesdir}/python-sphinx/.version
-%endif
-%config(noreplace) %{_sysconfdir}/profile.d/zz-modules-python-sphinx.sh
-%config(noreplace) %{_sysconfdir}/profile.d/zz-modules-python-sphinx.csh
 
-%if 0%{?with_python3}
+%files -n python%{python3_pkgversion}-sphinx-latex
+# empty, this is a metapackage
 
-%files -n python3-sphinx
-%license LICENSE
-%doc AUTHORS CHANGES EXAMPLES README.rst README.fedora
-%{_bindir}/sphinx-*-3*
-%{python3_sitelib}/sphinx/
-%{python3_sitelib}/Sphinx-%{version}-py%{python3_version}.egg-info/
-%{_mandir}/man1/sphinx-*-%{python3_version}.1*
-%{_libexecdir}/python3-sphinx/
-%{_modulesdir}/python-sphinx/python3-sphinx
-%if %{py3_default}
-%{_modulesdir}/python-sphinx/.version
-%endif
-%config(noreplace) %{_sysconfdir}/profile.d/zz-modules-python-sphinx.sh
-%config(noreplace) %{_sysconfdir}/profile.d/zz-modules-python-sphinx.csh
-
-%endif # with_python3
 
 %files doc
-%doc html reST
+%license LICENSE
+%doc html
 
 
 %changelog
+* Thu Jul 27 2023 Miro Hrončok <mhroncok@redhat.com> - 1:6.2.1-4
+- Don't use filelock to test this package on RHEL
+
+* Fri Jul 21 2023 Fedora Release Engineering <releng@fedoraproject.org> - 1:6.2.1-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild
+
+* Thu Jul 13 2023 Karolina Surma <ksurma@redhat.com> - 1:6.2.1-2
+- Don't use websupport to build documentation on RHEL
+
+* Mon Jun 26 2023 Karolina Surma <ksurma@redhat.com> - 1:6.2.1-1
+- Update to 6.2.1
+- Fixes rhbz#2188968
+
+* Fri Jun 16 2023 Python Maint <python-maint@redhat.com> - 1:6.1.3-4
+- Rebuilt for Python 3.12
+
+* Tue Jun 13 2023 Python Maint <python-maint@redhat.com> - 1:6.1.3-3
+- Bootstrap for Python 3.12
+
+* Wed May 31 2023 Yaakov Selkowitz <yselkowi@redhat.com> - 1:6.1.3-2
+- Avoid html5lib test dependency in RHEL builds
+
+* Fri Mar 10 2023 Karolina Surma <ksurma@redhat.com> - 1:6.1.3-1
+- Update to 6.1.3
+- Fixes rhbz#2135122
+
+* Thu Mar 09 2023 Karolina Surma <ksurma@redhat.com> - 1:5.3.0-4
+- Fix tests related to missing setuptools and Babel 2.12
+- Fixes rhbz#2176685
+
+* Tue Jan 31 2023 Karolina Surma <ksurma@redhat.com> - 1:5.3.0-3
+- Fix tests with python-pygments 2.14+
+
+* Fri Jan 20 2023 Fedora Release Engineering <releng@fedoraproject.org> - 1:5.3.0-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild
+
+* Tue Nov 08 2022 Karolina Surma <ksurma@redhat.com> - 1:5.3.0-1
+- Update to 5.3.0
+- Fixes rhbz#2129546
+
+* Mon Aug 15 2022 Karolina Surma <ksurma@redhat.com> - 1:5.1.1-1
+- Update to 5.1.1
+- Fixes rhbz#2110473
+- Remove reST documentation from the -doc package, ship only HTML
+
+* Fri Jul 22 2022 Fedora Release Engineering <releng@fedoraproject.org> - 1:5.0.2-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
+
+* Tue Jun 21 2022 Karolina Surma <ksurma@redhat.com> - 1:5.0.2-1
+- Update to 5.0.2
+
+* Mon Jun 13 2022 Python Maint <python-maint@redhat.com> - 1:4.5.0-3
+- Rebuilt for Python 3.11
+
+* Mon Jun 13 2022 Python Maint <python-maint@redhat.com> - 1:4.5.0-2
+- Bootstrap for Python 3.11
+
+* Fri Apr 01 2022 Karolina Surma <ksurma@redhat.com> - 1:4.5.0-1
+- Update to 4.5.0
+- Fixes rhbz#2068924
+
+* Tue Feb 01 2022 Karolina Surma <ksurma@redhat.com> - 1:4.4.0-1
+- Update to 4.4.0
+- Fixes rhbz#2033955
+
+* Fri Jan 21 2022 Fedora Release Engineering <releng@fedoraproject.org> - 1:4.3.1-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
+
+* Mon Nov 29 2021 Karolina Surma <ksurma@redhat.com> - 1:4.3.1-1
+- Update to 4.3.1
+- Fixes rhbz#2027059
+
+* Fri Nov 19 2021 Karolina Surma <ksurma@redhat.com> - 1:4.3.0-1
+- Update to 4.3.0
+- Fixes rhbz#2022111
+
+* Fri Sep 17 2021 Karolina Surma <ksurma@redhat.com> - 1:4.2.0-1
+- Update to 4.2.0
+- Fixes rhbz#2003427
+
+* Thu Sep 16 2021 Karolina Surma <ksurma@redhat.com> - 1:4.1.2-3
+- Display typing objects correctly with Python 3.10 (fix FTBFS)
+- Generate correct reference to parent class if class has `_name` attribute
+- Enable previously deselected test
+
+* Wed Aug 18 2021 Karolina Surma <ksurma@redhat.com> - 1:4.1.2-2
+- Patch python-sphinx to work with python-pygments >=2.10
+
+* Mon Aug 02 2021 Karolina Surma <ksurma@redhat.com> - 1:4.1.2-1
+- Update to 4.1.2
+- Fixes rhbz#1979326
+- Backport commit to fix python-sphinx with Python 3.10-rc1
+
+* Fri Jul 23 2021 Fedora Release Engineering <releng@fedoraproject.org> - 1:4.0.2-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
+
+* Fri Jun 11 2021 Karolina Surma <ksurma@redhat.com> - 1:4.0.2-1
+- Update to 4.0.2
+- Fixes rhbz#1948279
+
+* Thu Jun 03 2021 Python Maint <python-maint@redhat.com> - 1:3.5.4-3
+- Rebuilt for Python 3.10
+
+* Wed Jun 02 2021 Python Maint <python-maint@redhat.com> - 1:3.5.4-2
+- Bootstrap for Python 3.10
+
+* Mon May 10 2021 Karolina Surma <ksurma@redhat.com> - 1:3.5.4-1
+- Update to 3.5.4
+- Fixes rhbz#1949477
+
+* Thu Apr 01 2021 Karolina Surma <ksurma@redhat.com> - 1:3.5.3-1
+- Update to 3.5.3
+- Fixes rhbz#1941161
+
+* Wed Mar 10 2021 Charalampos Stratakis <cstratak@redhat.com> - 1:3.5.2-1
+- Update 3.5.2
+- Fixes rhbz#1928459
+
+* Wed Jan 27 2021 Fedora Release Engineering <releng@fedoraproject.org> - 1:3.4.3-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
+
+* Tue Jan 19 2021 Charalampos Stratakis <cstratak@redhat.com> - 1:3.4.3-1
+- Update to 3.4.3
+- Fixes rhbz#1909494
+
+* Sat Dec 05 2020 Mattia Verga <mattia.verga@protonmail.com> - 1:3.3.1-2
+- Unset -s from python shebang
+- Fixes: rhbz#1903763
+
+* Mon Nov 23 2020 Miro Hrončok <mhroncok@redhat.com> - 1:3.3.1-1
+- Update to 3.3.1
+- Fixes: rhbz#1893752
+
+* Wed Oct 14 2020 Tomas Hrnciar <thrnciar@redhat.com> - 1:3.2.1-2
+- Backport commit to fix python-sphinx with python-pygments v2.7.1
+
+* Tue Aug 18 2020 Miro Hrončok <mhroncok@redhat.com> - 1:3.2.1-1
+- Update to 3.2.1
+- Remove compatibility symbolic links from /usr/libexec/
+- Fixes rhbz#1867294
+
+* Fri Aug 07 2020 Miro Hrončok <mhroncok@redhat.com> - 1:3.1.2-1
+- Update to 3.1.2
+- Fixes rhbz#1853901
+
+* Wed Jul 29 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1:3.1.1-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
+
+* Tue Jun 30 2020 Charalampos Stratakis <cstratak@redhat.com> - 1:3.1.1-1
+- Update to 3.1.1 (#1783776)
+
+* Sat May 23 2020 Miro Hrončok <mhroncok@redhat.com> - 1:2.2.2-4
+- Rebuilt for Python 3.9
+
+* Fri May 22 2020 Miro Hrončok <mhroncok@redhat.com> - 1:2.2.2-3
+- Bootstrap for Python 3.9
+
+* Thu Jan 30 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1:2.2.2-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
+
+* Tue Dec 10 2019 Miro Hrončok <mhroncok@redhat.com> - 1:2.2.2-1
+- Update to 2.2.2 (rhbz#1743018)
+
+* Thu Oct 03 2019 Miro Hrončok <mhroncok@redhat.com> - 1:2.1.2-6
+- Rebuilt for Python 3.8.0rc1 (#1748018)
+
+* Fri Aug 16 2019 Miro Hrončok <mhroncok@redhat.com> - 1:2.1.2-5
+- Rebuilt for Python 3.8
+
+* Thu Aug 15 2019 Miro Hrončok <mhroncok@redhat.com> - 1:2.1.2-4
+- Bootstrap for Python 3.8
+
+* Thu Aug 15 2019 Richard Shaw <hobbes1069@gmail.com> - 1:2.1.2-3
+- Rebuild for Python 3.8.
+
+* Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1:2.1.2-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
+
+* Sun Jun 23 2019 Miro Hrončok <mhroncok@redhat.com> - 1:2.1.2-1
+- Update to 2.1.2 (#1716158)
+
+* Wed Apr 10 2019 Miro Hrončok <mhroncok@redhat.com> - 1:2.0.1-1
+- Update to 2.0.1 (#1697544)
+- Own the sphinxcontrib directory (#1669790)
+
+* Wed Mar 27 2019 Charalampos Stratakis <cstratak@redhat.com> - 1:2.0.0~b2-1
+- Update to 2.0.0b2
+
+* Wed Feb 27 2019 Miro Hrončok <mhroncok@redhat.com> - 1:2.0.0~b1-1
+- Update to 2.0.0b1
+- Drop Python 2 package
+- https://fedoraproject.org/wiki/Changes/Sphinx2
+
+* Thu Feb 07 2019 Alfredo Moralejo <amoralej@redhat.com> - 1:1.8.4-1
+- Update to 1.8.4.
+
+* Sat Feb 02 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1:1.7.6-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
+
+* Sun Nov 18 2018 Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> - 1:1.7.6-2
+- Drop explicit locale setting for python3, use C.UTF-8 for python2
+  See https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot
+
 * Mon Jul 23 2018 Marcel Plch <mplch@redhat.com> - 1:1.7.6-1
 - Update to 1.7.6
 

python2-sphinx

@@ -1,6 +0,0 @@
-#%Module 1.0
-#
-#  python2-sphinx module for use with 'environment modules' package
-#
-conflict        python-sphinx
-prepend-path    PATH            @python2_sphinx_dir@

python3-sphinx

@@ -1,6 +0,0 @@
-#%Module 1.0
-#
-#  python2-sphinx module for use with 'environment modules' package
-#
-conflict        python-sphinx
-prepend-path    PATH            @python3_sphinx_dir@

rpminspect.yaml

@@ -0,0 +1,4 @@
+# exclude XML template (not always valid) from XML validity check:
+xml:
+    ignore:
+        - /usr/lib/python*/site-packages/sphinx/themes/basic/opensearch.xml

sources

@@ -1 +1 @@
-SHA512 (Sphinx-1.7.6.tar.gz) = 505c4e92c1a09c48a50d8bd0ec86089bd3f0f5352302ae330e2fba6e61316f40c6ec3726e2cfaeb54de0818127a26ef5364ac92bcf254283022c38c4e95d419c
+SHA512 (Sphinx-6.2.1.tar.gz) = 88daae1f9bacbf513c0db1e7d732104b00ac36803b82e253d14eda287b4d48cfa34d0ed90b13099748610f405dc8bdcc54c2d33002a27b970117baf93418a062

sphinx-test_theming.diff

@@ -1,12 +1,12 @@
 diff -ru Sphinx-1.7.6/tests/test_theming.py Sphinx-1.7.6_patched/tests/test_theming.py
 --- Sphinx-1.7.6/tests/test_theming.py	2018-07-16 11:24:40.000000000 +0200
 +++ Sphinx-1.7.6_patched/tests/test_theming.py	2018-07-20 15:17:35.049263077 +0200
-@@ -31,7 +31,7 @@
+@@ -25,7 +25,7 @@
          themes.append('alabaster')
  
      # test Theme class API
--    assert set(app.html_themes.keys()) == set(themes)
-+    assert set(app.html_themes.keys()) >= set(themes)
-     assert app.html_themes['test-theme'] == app.srcdir / 'test_theme' / 'test-theme'
-     assert app.html_themes['ziptheme'] == app.srcdir / 'ziptheme.zip'
-     assert app.html_themes['staticfiles'] == app.srcdir / 'test_theme' / 'staticfiles'
+-    assert set(app.registry.html_themes.keys()) == set(themes)
++    assert set(app.registry.html_themes.keys()) >= set(themes)
+     assert app.registry.html_themes['test-theme'] == app.srcdir / 'test_theme' / 'test-theme'
+     assert app.registry.html_themes['ziptheme'] == app.srcdir / 'ziptheme.zip'
+     assert app.registry.html_themes['staticfiles'] == app.srcdir / 'test_theme' / 'staticfiles'

xfail-test_latex_remote_images.patch

@@ -1,13 +0,0 @@
-diff --git a/tests/test_build_latex.py b/tests/test_build_latex.py
-index 55f48cd..78ccecd 100644
---- a/tests/test_build_latex.py
-+++ b/tests/test_build_latex.py
-@@ -1009,7 +1009,7 @@ def test_latex_raw_directive(app, status, warning):
-     assert 'HTML: abc  ghi' in result
-     assert 'LaTeX: abc def ghi' in result
- 
--
-+@pytest.mark.xfail(reason="this test requires internet connection")
- @pytest.mark.sphinx('latex', testroot='images')
- def test_latex_remote_images(app, status, warning):
-     app.builder.build_all()

zz-modules-python-sphinx.csh

@@ -1,2 +0,0 @@
-# Add path to the default python-sphinx scripts on this version of Fedora
-module load python-sphinx >& /dev/null

zz-modules-python-sphinx.sh

@@ -1,2 +0,0 @@
-# Add path to the default python-sphinx scripts on this version of Fedora
-module load python-sphinx 2> /dev/null