Fix build with latest wireshark

Signed-off-by: Cole Robinson <crobinso@redhat.com>

.abignore

@@ -0,0 +1,31 @@
+[suppress_function]
+symbol_version_regexp = LIBVIRT_PRIVATE.*
+soname_regexp = libvirt\\.so.*
+
+[suppress_function]
+symbol_version_regexp = LIBVIRT_ADMIN_PRIVATE.*
+soname_regexp = libvirt-admin\\.so.*
+
+[suppress_variable]
+symbol_version_regexp = LIBVIRT_PRIVATE.*
+soname_regexp = libvirt\\.so.*
+
+[suppress_variable]
+symbol_version_regexp = LIBVIRT_ADMIN_PRIVATE.*
+soname_regexp = libvirt-admin\\.so.*
+
+[suppress_function]
+symbol_version_regexp = .*
+soname_regexp = libvirt_storage_.*\\.so.*
+
+[suppress_variable]
+symbol_version_regexp = .*
+soname_regexp = libvirt_storage_.*\\.so.*
+
+[suppress_function]
+symbol_version_regexp = .*
+soname_regexp = libvirt_driver_.*\\.so.*
+
+[suppress_variable]
+symbol_version_regexp = .*
+soname_regexp = libvirt_driver_.*\\.so.*

0001-Fix-mocking-of-virQEMUCapsProbeHVF-function.patch

@@ -0,0 +1,31 @@
+From 5629ebcb4234fde10fd9468d5fc5dd4947ed8677 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
+Date: Tue, 29 Apr 2025 15:49:10 +0100
+Subject: [PATCH] Fix mocking of virQEMUCapsProbeHVF function
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Daniel P. Berrangé <berrange@redhat.com>
+
+Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
+---
+ src/qemu/qemu_capabilities.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
+index ea7c14daa9..488a1a058e 100644
+--- a/src/qemu/qemu_capabilities.h
++++ b/src/qemu/qemu_capabilities.h
+@@ -943,7 +943,7 @@ bool
+ virQEMUCapsGetKVMSupportsSecureGuest(virQEMUCaps *qemuCaps) G_NO_INLINE;
+ 
+ bool
+-virQEMUCapsProbeHVF(virQEMUCaps *qemuCaps) G_NO_INLINE;
++virQEMUCapsProbeHVF(virQEMUCaps *qemuCaps) G_NO_INLINE __attribute__((noipa));
+ 
+ virArch virQEMUCapsArchFromString(const char *arch);
+ const char *virQEMUCapsArchToString(virArch arch);
+-- 
+2.49.0
+

0001-nss-Skip-empty-files-and-avoid-use-of-uninitialized-.patch

@@ -0,0 +1,85 @@
+From 63a3d70697dc44ef2f8b40f7c8e9aa869227a7da Mon Sep 17 00:00:00 2001
+From: Jiang XueQian <jiangxueqian@gmail.com>
+Date: Sat, 18 Jan 2025 16:32:10 +0800
+Subject: [PATCH] nss: Skip empty files and avoid use of uninitialized value
+Content-type: text/plain
+
+JSON parser isn't called when reading empty files so `jerr` will be used
+uninitialized in the original code. Empty files appear when a network
+has no dhcp clients.
+
+This patch checks for such files and skip them.
+
+Fixes: a8d828c88bbdaf83ae78dc06cdd84d5667fcc424
+Signed-off-by: Jiang XueQian <jiangxueqian@gmail.com>
+Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
+Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
+---
+ tools/nss/libvirt_nss_leases.c | 9 +++++++--
+ tools/nss/libvirt_nss_macs.c   | 9 +++++++--
+ 2 files changed, 14 insertions(+), 4 deletions(-)
+
+diff --git a/tools/nss/libvirt_nss_leases.c b/tools/nss/libvirt_nss_leases.c
+index aea81bb56e..25ea6b0ce2 100644
+--- a/tools/nss/libvirt_nss_leases.c
++++ b/tools/nss/libvirt_nss_leases.c
+@@ -263,7 +263,7 @@ findLeases(const char *file,
+     enum json_tokener_error jerr;
+     int jsonflags = JSON_TOKENER_STRICT | JSON_TOKENER_VALIDATE_UTF8;
+     char line[1024];
+-    ssize_t nreadTotal = 0;
++    size_t nreadTotal = 0;
+     int rv;
+ 
+     if ((fd = open(file, O_RDONLY)) < 0) {
+@@ -290,12 +290,17 @@ findLeases(const char *file,
+         jerr = json_tokener_get_error(tok);
+     } while (jerr == json_tokener_continue);
+ 
++    if (nreadTotal == 0) {
++        ret = 0;
++        goto cleanup;
++    }
++
+     if (jerr == json_tokener_continue) {
+         ERROR("Cannot parse %s: incomplete json found", file);
+         goto cleanup;
+     }
+ 
+-    if (nreadTotal > 0 && jerr != json_tokener_success) {
++    if (jerr != json_tokener_success) {
+         ERROR("Cannot parse %s: %s", file, json_tokener_error_desc(jerr));
+         goto cleanup;
+     }
+diff --git a/tools/nss/libvirt_nss_macs.c b/tools/nss/libvirt_nss_macs.c
+index 23229a18f3..bac8c0e1bb 100644
+--- a/tools/nss/libvirt_nss_macs.c
++++ b/tools/nss/libvirt_nss_macs.c
+@@ -124,7 +124,7 @@ findMACs(const char *file,
+     json_tokener *tok = NULL;
+     enum json_tokener_error jerr;
+     int jsonflags = JSON_TOKENER_STRICT | JSON_TOKENER_VALIDATE_UTF8;
+-    ssize_t nreadTotal = 0;
++    size_t nreadTotal = 0;
+     int rv;
+     size_t i;
+ 
+@@ -152,12 +152,17 @@ findMACs(const char *file,
+         jerr = json_tokener_get_error(tok);
+     } while (jerr == json_tokener_continue);
+ 
++    if (nreadTotal == 0) {
++        ret = 0;
++        goto cleanup;
++    }
++
+     if (jerr == json_tokener_continue) {
+         ERROR("Cannot parse %s: incomplete json found", file);
+         goto cleanup;
+     }
+ 
+-    if (nreadTotal > 0 && jerr != json_tokener_success) {
++    if (jerr != json_tokener_success) {
+         ERROR("Cannot parse %s: %s", file, json_tokener_error_desc(jerr));
+         goto cleanup;
+     }

0001-qemu-Be-more-forgiving-when-acquiring-QUERY-job-when.patch

@@ -0,0 +1,68 @@
+From cd0de70e05475d5f4aa46e578fbb98033d38c06b Mon Sep 17 00:00:00 2001
+From: Michal Privoznik <mprivozn@redhat.com>
+Date: Mon, 16 Jun 2025 10:28:37 +0200
+Subject: [PATCH] qemu: Be more forgiving when acquiring QUERY job when
+ formatting domain XML
+Content-type: text/plain
+
+In my previous commit of v11.0.0-rc1~115 I've made QEMU driver
+implementation for virDomainGetXMLDesc() (qemuDomainGetXMLDesc())
+acquire QERY job. See its commit message for more info. But this
+unfortunately broke apps witch fetch domain XML for incoming
+migration (like virt-manager). The reason is that for incoming
+migration the VIR_ASYNC_JOB_MIGRATION_IN async job is set, but
+the mask of allowed synchronous jobs is empty (because QEMU can't
+talk on monitor really). This makes virDomainObjBeginJob() fail
+which in turn makes qemuDomainGetXMLDesc() fail too.
+
+It makes sense for qemuDomainGetXMLDesc() to acquire the job
+(e.g. so that it's coherent with another thread that might be in
+the middle of a MODIFY job). But failure to dump XML may be
+treated as broken daemon (e.g. virt-manager does so).
+
+Therefore, still try to acquire the QUERY job (if job mask
+permits it) but, do not treat failure as an error.
+
+Fixes: 6cc93bf28842526be2fd596a607ebca796b7fb2e
+Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2369243
+Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
+Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
+---
+ src/qemu/qemu_driver.c | 10 +++++++---
+ 1 file changed, 7 insertions(+), 3 deletions(-)
+
+diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
+index d2eddbd9ae..6bdeede2e8 100644
+--- a/src/qemu/qemu_driver.c
++++ b/src/qemu/qemu_driver.c
+@@ -6158,6 +6158,7 @@ static char
+ {
+     virQEMUDriver *driver = dom->conn->privateData;
+     virDomainObj *vm;
++    bool hasJob = false;
+     char *ret = NULL;
+ 
+     virCheckFlags(VIR_DOMAIN_XML_COMMON_FLAGS | VIR_DOMAIN_XML_UPDATE_CPU,
+@@ -6169,8 +6170,10 @@ static char
+     if (virDomainGetXMLDescEnsureACL(dom->conn, vm->def, flags) < 0)
+         goto cleanup;
+ 
+-    if (virDomainObjBeginJob(vm, VIR_JOB_QUERY) < 0)
+-        goto cleanup;
++    if (virDomainNestedJobAllowed(vm->job, VIR_JOB_QUERY) &&
++        virDomainObjBeginJob(vm, VIR_JOB_QUERY) >= 0) {
++        hasJob = true;
++    }
+ 
+     qemuDomainUpdateCurrentMemorySize(vm);
+ 
+@@ -6186,7 +6189,8 @@ static char
+ 
+     ret = qemuDomainFormatXML(driver, vm, flags);
+ 
+-    virDomainObjEndJob(vm);
++    if (hasJob)
++        virDomainObjEndJob(vm);
+ 
+  cleanup:
+     virDomainObjEndAPI(&vm);

0001-storage-stop-hardcoding-paths-for-mkfs-mount-umount.patch

@@ -0,0 +1,94 @@
+From 63e4cbd109374f44e8bd4f8d1af5e2a2c67611bc Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
+Date: Mon, 28 Apr 2025 11:42:13 +0100
+Subject: [PATCH] storage: stop hardcoding paths for mkfs, mount, umount
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Daniel P. Berrangé <berrange@redhat.com>
+
+This was always undesirable but now causes problems on Fedora 42
+where at build time we detect a /sbin path but at runtime this
+will only exist on upgraded machines, not fresh installs.
+
+Reviewed-by: Peter Krempa <pkrempa@redhat.com>
+Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
+---
+ meson.build                      | 13 -------------
+ src/storage/storage_backend_fs.c | 17 +++--------------
+ 2 files changed, 3 insertions(+), 27 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index 37b1caa566..14c98b49a1 100644
+--- a/meson.build
++++ b/meson.build
+@@ -1827,23 +1827,10 @@ if conf.has('WITH_LIBVIRTD')
+       endif
+     endif
+ 
+-    if fs_enable
+-      mount_prog = find_program('mount', required: get_option('storage_fs'), dirs: libvirt_sbin_path)
+-      umount_prog = find_program('umount', required: get_option('storage_fs'), dirs: libvirt_sbin_path)
+-      mkfs_prog = find_program('mkfs', required: get_option('storage_fs'), dirs: libvirt_sbin_path)
+-
+-      if not mount_prog.found() or not umount_prog.found() or not mkfs_prog.found()
+-        fs_enable = false
+-      endif
+-    endif
+-
+     if fs_enable
+       use_storage = true
+ 
+       conf.set('WITH_STORAGE_FS', 1)
+-      conf.set_quoted('MOUNT', mount_prog.full_path())
+-      conf.set_quoted('UMOUNT', umount_prog.full_path())
+-      conf.set_quoted('MKFS', mkfs_prog.full_path())
+     endif
+   endif
+ 
+diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
+index fce395d60f..6ec359625a 100644
+--- a/src/storage/storage_backend_fs.c
++++ b/src/storage/storage_backend_fs.c
+@@ -304,7 +304,7 @@ virStorageBackendFileSystemMount(virStoragePoolObj *pool)
+     if (!(src = virStorageBackendFileSystemGetPoolSource(pool)))
+         return -1;
+ 
+-    cmd = virStorageBackendFileSystemMountCmd(MOUNT, def, src);
++    cmd = virStorageBackendFileSystemMountCmd("mount", def, src);
+ 
+     /* Mounting a shared FS might take a long time. Don't hold
+      * the pool locked meanwhile. */
+@@ -362,7 +362,7 @@ virStorageBackendFileSystemStop(virStoragePoolObj *pool)
+     if ((rc = virStorageBackendFileSystemIsMounted(pool)) != 1)
+         return rc;
+ 
+-    cmd = virCommandNewArgList(UMOUNT, def->target.path, NULL);
++    cmd = virCommandNewArgList("umount", def->target.path, NULL);
+     return virCommandRun(cmd, NULL);
+ }
+ #endif /* WITH_STORAGE_FS */
+@@ -402,18 +402,7 @@ virStorageBackendExecuteMKFS(const char *device,
+     g_autoptr(virCommand) cmd = NULL;
+     g_autofree char *mkfs = NULL;
+ 
+-#if WITH_STORAGE_FS
+-    mkfs = virFindFileInPath(MKFS);
+-#endif /* WITH_STORAGE_FS */
+-
+-    if (!mkfs) {
+-        virReportError(VIR_ERR_INTERNAL_ERROR,
+-                       _("mkfs is not available on this platform: Failed to make filesystem of type '%1$s' on device '%2$s'"),
+-                       format, device);
+-        return -1;
+-    }
+-
+-    cmd = virCommandNewArgList(mkfs, "-t", format, NULL);
++    cmd = virCommandNewArgList("mkfs", "-t", format, NULL);
+ 
+     /* use the force, otherwise mkfs.xfs won't overwrite existing fs.
+      * Similarly mkfs.ext2, mkfs.ext3, and mkfs.ext4 require supplying -F
+-- 
+2.49.0
+

0001-tpm-Use-dev-null-for-cancel-path-if-none-was-found.patch

@@ -1,34 +0,0 @@
-From: Stefan Berger <stefanb@linux.vnet.ibm.com>
-Date: Thu, 29 Jun 2017 14:01:11 -0400
-Subject: [PATCH] tpm: Use /dev/null for cancel path if none was found
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-TPM 2 does not implement sysfs files for cancellation of commands.
-We therefore use /dev/null for the cancel path passed to QEMU.
-
-Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
-Tested-by: Javier Martinez Canillas <javierm@redhat.com>
-Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
-Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
-(cherry picked from commit dfbb15b75433e520fb1b905c1c3e28753e53e4a5)
----
- src/util/virtpm.c | 4 +---
- 1 file changed, 1 insertion(+), 3 deletions(-)
-
-diff --git a/src/util/virtpm.c b/src/util/virtpm.c
-index 6d9b0657a..d5c10da38 100644
---- a/src/util/virtpm.c
-+++ b/src/util/virtpm.c
-@@ -61,9 +61,7 @@ virTPMCreateCancelPath(const char *devpath)
-                 VIR_FREE(path);
-             }
-             if (!path)
--                virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
--                               _("No usable sysfs TPM cancel file could be "
--                                 "found"));
-+                ignore_value(VIR_STRDUP(path, "/dev/null"));
-         } else {
-             virReportError(VIR_ERR_INTERNAL_ERROR,
-                            _("TPM device path %s is invalid"), devpath);

0001-util-avoid-overflow-in-hextable-buffer.patch

@@ -0,0 +1,43 @@
+From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
+To: devel@lists.libvirt.org
+Subject: [PATCH] util: avoid overflow in hextable buffer
+Date: Mon, 20 Jan 2025 10:09:24 +0000
+Message-ID: <20250120100924.3864818-1-berrange@redhat.com>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+The assigned string is 17 chars long once the trailing nul is taken
+into account. This triggers a warning with GCC 15
+
+ src/util/virsystemd.c: In function ‘virSystemdEscapeName’:
+ src/util/virsystemd.c:59:38: error: initializer-string for array of ‘char’ is too long [-Werror=unterminated-string-initialization]
+    59 |     static const char hextable[16] = "0123456789abcdef";
+       |                                      ^~~~~~~~~~~~~~~~~~
+
+Switch to a dynamically sized array as used in all the other places
+we have a hextable array.
+
+See also: https://gcc.gnu.org/PR115185
+Reported-by: Yaakov Selkowitz <yselkowi@redhat.com>
+Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
+---
+ src/util/virsystemd.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c
+index 5b772e29dd..d46e5f74fc 100644
+--- a/src/util/virsystemd.c
++++ b/src/util/virsystemd.c
+@@ -56,7 +56,7 @@ struct _virSystemdActivationEntry {
+ static void virSystemdEscapeName(virBuffer *buf,
+                                  const char *name)
+ {
+-    static const char hextable[16] = "0123456789abcdef";
++    static const char hextable[] = "0123456789abcdef";
+ 
+ #define ESCAPE(c) \
+     do { \
+-- 
+2.47.1
+

0001-util-stop-hardcoding-numad-path.patch

@@ -0,0 +1,58 @@
+From 7ab0f1c2a3fddf46d381f055e49111e3063b4829 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
+Date: Mon, 28 Apr 2025 11:47:34 +0100
+Subject: [PATCH] util: stop hardcoding numad path
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Daniel P. Berrangé <berrange@redhat.com>
+
+Change the meson rules to always enable numad if on a Linux host, unless
+the meson options say not to.
+
+Reviewed-by: Peter Krempa <pkrempa@redhat.com>
+Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
+---
+ meson.build        | 10 +++-------
+ src/util/virnuma.c |  2 +-
+ 2 files changed, 4 insertions(+), 8 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index 14c98b49a1..767205f44b 100644
+--- a/meson.build
++++ b/meson.build
+@@ -2028,14 +2028,10 @@ if not get_option('nss').disabled()
+   endif
+ endif
+ 
+-if not get_option('numad').disabled() and numactl_dep.found()
+-  numad_prog = find_program('numad', required: get_option('numad'), dirs: libvirt_sbin_path)
+-  if numad_prog.found()
+-    conf.set('WITH_NUMAD', 1)
+-    conf.set_quoted('NUMAD', numad_prog.full_path())
+-  endif
++if not get_option('numad').disabled() and numactl_dep.found() and host_machine.system() == 'linux'
++  conf.set('WITH_NUMAD', 1)
+ elif get_option('numad').enabled()
+-  error('You must have numactl enabled for numad support.')
++  error('You must have a Linux host with numactl enabled for numad support.')
+ endif
+ 
+ # nwfilter should only be compiled for linux, and only if the
+diff --git a/src/util/virnuma.c b/src/util/virnuma.c
+index 9393c20875..67c51630c7 100644
+--- a/src/util/virnuma.c
++++ b/src/util/virnuma.c
+@@ -61,7 +61,7 @@ virNumaGetAutoPlacementAdvice(unsigned short vcpus,
+     g_autoptr(virCommand) cmd = NULL;
+     char *output = NULL;
+ 
+-    cmd = virCommandNewArgList(NUMAD, "-w", NULL);
++    cmd = virCommandNewArgList("numad", "-w", NULL);
+     virCommandAddArgFormat(cmd, "%d:%llu", vcpus,
+                            VIR_DIV_UP(balloon, 1024));
+ 
+-- 
+2.49.0
+

0001-wireshark-Drop-needless-declaration-of-proto_registe.patch

@@ -0,0 +1,36 @@
+From b825bb556bd3967bf5422c243b77bd4038e317e2 Mon Sep 17 00:00:00 2001
+Message-ID: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+From: Michal Privoznik <mprivozn@redhat.com>
+Date: Mon, 13 Oct 2025 10:34:51 +0200
+Subject: [PATCH 1/8] wireshark: Drop needless declaration of
+ proto_register_libvirt() and proto_reg_handoff_libvirt()
+Content-type: text/plain
+
+Both proto_register_libvirt() and proto_reg_handoff_libvirt() are
+declared in packet-libvirt.h which is included from plugin.c.
+There's no need to provide another declaration in plugin.c.
+
+Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
+Reviewed-by: Peter Krempa <pkrempa@redhat.com>
+Signed-off-by: Cole Robinson <crobinso@redhat.com>
+---
+ tools/wireshark/src/plugin.c | 3 ---
+ 1 file changed, 3 deletions(-)
+
+diff --git a/tools/wireshark/src/plugin.c b/tools/wireshark/src/plugin.c
+index 9a83f2ca07..19b25e7b1a 100644
+--- a/tools/wireshark/src/plugin.c
++++ b/tools/wireshark/src/plugin.c
+@@ -72,9 +72,6 @@ void plugin_register(void)
+ 
+ #else /* WIRESHARK_VERSION >= 2009000 */
+ 
+-void proto_register_libvirt(void);
+-void proto_reg_handoff_libvirt(void);
+-
+ WS_DLL_PUBLIC_DEF const gchar plugin_version[] = PLUGIN_VERSION;
+ WS_DLL_PUBLIC_DEF const int plugin_want_major = WIRESHARK_VERSION_MAJOR;
+ WS_DLL_PUBLIC_DEF const int plugin_want_minor = WIRESHARK_VERSION_MINOR;
+-- 
+2.51.0
+

0002-security-add-MANAGER_MOUNT_NAMESPACE-flag.patch

@@ -1,108 +0,0 @@
-From: Cole Robinson <crobinso@redhat.com>
-Date: Sun, 27 Aug 2017 11:23:47 -0400
-Subject: [PATCH] security: add MANAGER_MOUNT_NAMESPACE flag
-
-The VIR_SECURITY_MANAGER_MOUNT_NAMESPACE flag informs the DAC driver
-if mount namespaces are in use for the VM. Will be used for future
-changes.
-
-Wire it up in the qemu driver
-
-(cherry picked from commit 321031e482425dfeae0f125cdac6df870f079efd)
----
- src/qemu/qemu_driver.c          |  2 ++
- src/security/security_dac.c     | 10 ++++++++++
- src/security/security_dac.h     |  3 +++
- src/security/security_manager.c |  4 +++-
- src/security/security_manager.h |  1 +
- 5 files changed, 19 insertions(+), 1 deletion(-)
-
-diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
-index b7824512c..1f9264639 100644
---- a/src/qemu/qemu_driver.c
-+++ b/src/qemu/qemu_driver.c
-@@ -419,6 +419,8 @@ qemuSecurityInit(virQEMUDriverPtr driver)
-     if (virQEMUDriverIsPrivileged(driver)) {
-         if (cfg->dynamicOwnership)
-             flags |= VIR_SECURITY_MANAGER_DYNAMIC_OWNERSHIP;
-+        if (virBitmapIsBitSet(cfg->namespaces, QEMU_DOMAIN_NS_MOUNT))
-+            flags |= VIR_SECURITY_MANAGER_MOUNT_NAMESPACE;
-         if (!(mgr = qemuSecurityNewDAC(QEMU_DRIVER_NAME,
-                                        cfg->user,
-                                        cfg->group,
-diff --git a/src/security/security_dac.c b/src/security/security_dac.c
-index ca7a6af6d..507be44a2 100644
---- a/src/security/security_dac.c
-+++ b/src/security/security_dac.c
-@@ -57,6 +57,7 @@ struct _virSecurityDACData {
-     gid_t *groups;
-     int ngroups;
-     bool dynamicOwnership;
-+    bool mountNamespace;
-     char *baselabel;
-     virSecurityManagerDACChownCallback chownCallback;
- };
-@@ -237,6 +238,15 @@ virSecurityDACSetDynamicOwnership(virSecurityManagerPtr mgr,
-     priv->dynamicOwnership = dynamicOwnership;
- }
- 
-+void
-+virSecurityDACSetMountNamespace(virSecurityManagerPtr mgr,
-+                                bool mountNamespace)
-+{
-+    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
-+    priv->mountNamespace = mountNamespace;
-+}
-+
-+
- void
- virSecurityDACSetChownCallback(virSecurityManagerPtr mgr,
-                                virSecurityManagerDACChownCallback chownCallback)
-diff --git a/src/security/security_dac.h b/src/security/security_dac.h
-index 846cefbb5..97681c961 100644
---- a/src/security/security_dac.h
-+++ b/src/security/security_dac.h
-@@ -32,6 +32,9 @@ int virSecurityDACSetUserAndGroup(virSecurityManagerPtr mgr,
- void virSecurityDACSetDynamicOwnership(virSecurityManagerPtr mgr,
-                                        bool dynamic);
- 
-+void virSecurityDACSetMountNamespace(virSecurityManagerPtr mgr,
-+                                     bool mountNamespace);
-+
- void virSecurityDACSetChownCallback(virSecurityManagerPtr mgr,
-                                     virSecurityManagerDACChownCallback chownCallback);
- 
-diff --git a/src/security/security_manager.c b/src/security/security_manager.c
-index 95b995230..e43c99d4f 100644
---- a/src/security/security_manager.c
-+++ b/src/security/security_manager.c
-@@ -146,7 +146,8 @@ virSecurityManagerNewDAC(const char *virtDriver,
-     virSecurityManagerPtr mgr;
- 
-     virCheckFlags(VIR_SECURITY_MANAGER_NEW_MASK |
--                  VIR_SECURITY_MANAGER_DYNAMIC_OWNERSHIP, NULL);
-+                  VIR_SECURITY_MANAGER_DYNAMIC_OWNERSHIP |
-+                  VIR_SECURITY_MANAGER_MOUNT_NAMESPACE, NULL);
- 
-     mgr = virSecurityManagerNewDriver(&virSecurityDriverDAC,
-                                       virtDriver,
-@@ -161,6 +162,7 @@ virSecurityManagerNewDAC(const char *virtDriver,
-     }
- 
-     virSecurityDACSetDynamicOwnership(mgr, flags & VIR_SECURITY_MANAGER_DYNAMIC_OWNERSHIP);
-+    virSecurityDACSetMountNamespace(mgr, flags & VIR_SECURITY_MANAGER_MOUNT_NAMESPACE);
-     virSecurityDACSetChownCallback(mgr, chownCallback);
- 
-     return mgr;
-diff --git a/src/security/security_manager.h b/src/security/security_manager.h
-index 01296d339..08fb89203 100644
---- a/src/security/security_manager.h
-+++ b/src/security/security_manager.h
-@@ -36,6 +36,7 @@ typedef enum {
-     VIR_SECURITY_MANAGER_REQUIRE_CONFINED   = 1 << 2,
-     VIR_SECURITY_MANAGER_PRIVILEGED         = 1 << 3,
-     VIR_SECURITY_MANAGER_DYNAMIC_OWNERSHIP  = 1 << 4,
-+    VIR_SECURITY_MANAGER_MOUNT_NAMESPACE    = 1 << 5,
- } virSecurityManagerNewFlags;
- 
- # define VIR_SECURITY_MANAGER_NEW_MASK  \

0002-wireshark-Switch-header-files-to-pragma-once.patch

@@ -0,0 +1,47 @@
+From 41d3b457972bde85991fa7ed6f282370aca4b2af Mon Sep 17 00:00:00 2001
+Message-ID: <41d3b457972bde85991fa7ed6f282370aca4b2af.1760476767.git.crobinso@redhat.com>
+In-Reply-To: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+References: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+From: Michal Privoznik <mprivozn@redhat.com>
+Date: Fri, 10 Oct 2025 15:20:05 +0200
+Subject: [PATCH 2/8] wireshark: Switch header files to #pragma once
+Content-type: text/plain
+
+The genxdrstub.pl script generates some header files. But they
+use the old pattern to guard against multiple inclusion:
+
+  #ifndef SOMETHING_H
+  #define SOMETHING_H
+  ...
+  #endif
+
+Change the script to generate just '#pragma once' used everywhere
+else in our code.
+
+Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
+Reviewed-by: Peter Krempa <pkrempa@redhat.com>
+Signed-off-by: Cole Robinson <crobinso@redhat.com>
+---
+ tools/wireshark/util/genxdrstub.pl | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/tools/wireshark/util/genxdrstub.pl b/tools/wireshark/util/genxdrstub.pl
+index 8cfda25a27..01b663a88c 100755
+--- a/tools/wireshark/util/genxdrstub.pl
++++ b/tools/wireshark/util/genxdrstub.pl
+@@ -563,11 +563,8 @@ sub add_header_file {
+     local $self->{header_contents} = [];
+     $self->print("/* *DO NOT MODIFY* this file directly.\n");
+     $self->print(" * This file was generated by $0 from libvirt version $libvirt_version */\n");
+-    my $ucname = uc $name;
+-    $self->print("#ifndef _$ucname\_H_\n");
+-    $self->print("#define _$ucname\_H_\n");
++    $self->print("#pragma once\n");
+     $block->();
+-    $self->print("#endif /* _$ucname\_H_ */");
+     push @{ $self->{headers} }, [ $name, delete $self->{header_contents} ];
+ }
+ 
+-- 
+2.51.0
+

0003-security-dac-relabel-spice-rendernode.patch

@@ -1,101 +0,0 @@
-From: Cole Robinson <crobinso@redhat.com>
-Date: Mon, 17 Jul 2017 08:57:57 -0400
-Subject: [PATCH] security: dac: relabel spice rendernode
-
-For a logged in user this a path like /dev/dri/renderD128 will have
-default ownership root:video which won't work for the qemu:qemu user,
-so we need to chown it.
-
-We only do this when mount namespaces are enabled in the qemu driver,
-so the chown'ing doesn't interfere with other users of the shared
-render node path
-
-https://bugzilla.redhat.com/show_bug.cgi?id=1460804
-(cherry picked from commit 98931187eefdec6f2dea5cb82ab6d23a3ffa6634)
----
- src/security/security_dac.c | 58 +++++++++++++++++++++++++++++++++++++++++++++
- 1 file changed, 58 insertions(+)
-
-diff --git a/src/security/security_dac.c b/src/security/security_dac.c
-index 507be44a2..349dbe81d 100644
---- a/src/security/security_dac.c
-+++ b/src/security/security_dac.c
-@@ -1380,6 +1380,54 @@ virSecurityDACRestoreTPMFileLabel(virSecurityManagerPtr mgr,
- }
- 
- 
-+static int
-+virSecurityDACSetGraphicsLabel(virSecurityManagerPtr mgr,
-+                               virDomainDefPtr def,
-+                               virDomainGraphicsDefPtr gfx)
-+
-+{
-+    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
-+    virSecurityLabelDefPtr seclabel;
-+    uid_t user;
-+    gid_t group;
-+
-+    /* Skip chowning the shared render file if namespaces are disabled */
-+    if (!priv->mountNamespace)
-+        return 0;
-+
-+    seclabel = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);
-+    if (seclabel && !seclabel->relabel)
-+        return 0;
-+
-+    if (virSecurityDACGetIds(seclabel, priv, &user, &group, NULL, NULL) < 0)
-+        return -1;
-+
-+    if (gfx->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE &&
-+        gfx->data.spice.gl == VIR_TRISTATE_BOOL_YES &&
-+        gfx->data.spice.rendernode) {
-+        if (virSecurityDACSetOwnership(priv, NULL,
-+                                       gfx->data.spice.rendernode,
-+                                       user, group) < 0)
-+            return -1;
-+    }
-+
-+    return 0;
-+}
-+
-+
-+static int
-+virSecurityDACRestoreGraphicsLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
-+                               virDomainDefPtr def ATTRIBUTE_UNUSED,
-+                               virDomainGraphicsDefPtr gfx ATTRIBUTE_UNUSED)
-+
-+{
-+    /* The only graphics labelling we do is dependent on mountNamespaces,
-+       in which case 'restoring' the label doesn't actually accomplish
-+       anything, so there's nothing to do here */
-+    return 0;
-+}
-+
-+
- static int
- virSecurityDACSetInputLabel(virSecurityManagerPtr mgr,
-                             virDomainDefPtr def,
-@@ -1491,6 +1539,11 @@ virSecurityDACRestoreAllLabel(virSecurityManagerPtr mgr,
-             rc = -1;
-     }
- 
-+    for (i = 0; i < def->ngraphics; i++) {
-+        if (virSecurityDACRestoreGraphicsLabel(mgr, def, def->graphics[i]) < 0)
-+            return -1;
-+    }
-+
-     for (i = 0; i < def->ninputs; i++) {
-         if (virSecurityDACRestoreInputLabel(mgr, def, def->inputs[i]) < 0)
-             rc = -1;
-@@ -1611,6 +1664,11 @@ virSecurityDACSetAllLabel(virSecurityManagerPtr mgr,
-             return -1;
-     }
- 
-+    for (i = 0; i < def->ngraphics; i++) {
-+        if (virSecurityDACSetGraphicsLabel(mgr, def, def->graphics[i]) < 0)
-+            return -1;
-+    }
-+
-     for (i = 0; i < def->ninputs; i++) {
-         if (virSecurityDACSetInputLabel(mgr, def, def->inputs[i]) < 0)
-             return -1;

0003-wireshark-Move-WIRESHARK_VERSION-macro-definition.patch

@@ -0,0 +1,81 @@
+From 02a0e78bf54c903da8922c56bade9b3298ade351 Mon Sep 17 00:00:00 2001
+Message-ID: <02a0e78bf54c903da8922c56bade9b3298ade351.1760476767.git.crobinso@redhat.com>
+In-Reply-To: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+References: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+From: Michal Privoznik <mprivozn@redhat.com>
+Date: Mon, 13 Oct 2025 09:04:17 +0200
+Subject: [PATCH 3/8] wireshark: Move WIRESHARK_VERSION macro definition
+Content-type: text/plain
+
+Soon, other parts of the wireshark code will need to
+differentiate wrt wireshark version. Therefore, move the
+WIRESHARK_VERSION macro definition among with its deps into
+packet-libvirt.h.
+
+Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
+Reviewed-by: Peter Krempa <pkrempa@redhat.com>
+Signed-off-by: Cole Robinson <crobinso@redhat.com>
+---
+ tools/wireshark/src/packet-libvirt.h | 14 ++++++++++++++
+ tools/wireshark/src/plugin.c         | 14 --------------
+ 2 files changed, 14 insertions(+), 14 deletions(-)
+
+diff --git a/tools/wireshark/src/packet-libvirt.h b/tools/wireshark/src/packet-libvirt.h
+index 14e6e13696..15cfcb0534 100644
+--- a/tools/wireshark/src/packet-libvirt.h
++++ b/tools/wireshark/src/packet-libvirt.h
+@@ -19,5 +19,19 @@
+ 
+ #pragma once
+ 
++#ifdef WITH_WS_VERSION
++# include <wireshark/ws_version.h>
++#else
++# include <wireshark/config.h>
++# define WIRESHARK_VERSION_MAJOR VERSION_MAJOR
++# define WIRESHARK_VERSION_MINOR VERSION_MINOR
++# define WIRESHARK_VERSION_MICRO VERSION_MICRO
++#endif
++
++#define WIRESHARK_VERSION \
++    ((WIRESHARK_VERSION_MAJOR * 1000 * 1000) + \
++     (WIRESHARK_VERSION_MINOR * 1000) + \
++     (WIRESHARK_VERSION_MICRO))
++
+ void proto_register_libvirt(void);
+ void proto_reg_handoff_libvirt(void);
+diff --git a/tools/wireshark/src/plugin.c b/tools/wireshark/src/plugin.c
+index 19b25e7b1a..64317b5280 100644
+--- a/tools/wireshark/src/plugin.c
++++ b/tools/wireshark/src/plugin.c
+@@ -12,15 +12,6 @@
+ 
+ #include <config.h>
+ 
+-#ifdef WITH_WS_VERSION
+-# include <wireshark/ws_version.h>
+-#else
+-# include <wireshark/config.h>
+-# define WIRESHARK_VERSION_MAJOR VERSION_MAJOR
+-# define WIRESHARK_VERSION_MINOR VERSION_MINOR
+-# define WIRESHARK_VERSION_MICRO VERSION_MICRO
+-#endif
+-
+ #define HAVE_PLUGINS 1
+ #include <wireshark/epan/proto.h>
+ /* plugins are DLLs */
+@@ -32,11 +23,6 @@
+ /* Let the plugin version be the version of libvirt */
+ #define PLUGIN_VERSION VERSION
+ 
+-#define WIRESHARK_VERSION \
+-    ((WIRESHARK_VERSION_MAJOR * 1000 * 1000) + \
+-     (WIRESHARK_VERSION_MINOR * 1000) + \
+-     (WIRESHARK_VERSION_MICRO))
+-
+ #if WIRESHARK_VERSION < 2005000
+ 
+ WS_DLL_PUBLIC_DEF const gchar version[] = VERSION;
+-- 
+2.51.0
+

0004-qemu-ensure-TLS-clients-always-verify-the-server-cer.patch

@@ -1,72 +0,0 @@
-From: "Daniel P. Berrange" <berrange@redhat.com>
-Date: Thu, 5 Oct 2017 17:54:28 +0100
-Subject: [PATCH] qemu: ensure TLS clients always verify the server certificate
-
-The default_tls_x509_verify (and related) parameters in qemu.conf
-control whether the QEMU TLS servers request & verify certificates
-from clients. This works as a simple access control system for
-servers by requiring the CA to issue certs to permitted clients.
-This use of client certificates is disabled by default, since it
-requires extra work to issue client certificates.
-
-Unfortunately the code was using this configuration parameter when
-setting up both TLS clients and servers in QEMU. The result was that
-TLS clients for character devices and disk devices had verification
-turned off, meaning they would ignore errors while validating the
-server certificate.
-
-This allows for trivial MITM attacks between client and server,
-as any certificate returned by the attacker will be accepted by
-the client.
-
-This is assigned CVE-2017-1000256  / LSN-2017-0002
-
-Reviewed-by: Eric Blake <eblake@redhat.com>
-Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
-(cherry picked from commit 441d3eb6d1be940a67ce45a286602a967601b157)
-(cherry picked from commit dc6c41798d1eb5c52c75365ffa22f7672709dfa7)
----
- src/qemu/qemu_command.c                                                 | 2 +-
- tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev.args     | 2 +-
- .../qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args                 | 2 +-
- 3 files changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
-index 9a27987d4..ae78cd17e 100644
---- a/src/qemu/qemu_command.c
-+++ b/src/qemu/qemu_command.c
-@@ -718,7 +718,7 @@ qemuBuildTLSx509BackendProps(const char *tlspath,
-     if (virJSONValueObjectCreate(propsret,
-                                  "s:dir", path,
-                                  "s:endpoint", (isListen ? "server": "client"),
--                                 "b:verify-peer", verifypeer,
-+                                 "b:verify-peer", (isListen ? verifypeer : true),
-                                  NULL) < 0)
-         goto cleanup;
- 
-diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev.args
-index 5aff7734e..ab5f7e27f 100644
---- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev.args
-+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev.args
-@@ -26,7 +26,7 @@ server,nowait \
- localport=1111 \
- -device isa-serial,chardev=charserial0,id=serial0 \
- -object tls-creds-x509,id=objcharserial1_tls0,dir=/etc/pki/libvirt-chardev,\
--endpoint=client,verify-peer=no \
-+endpoint=client,verify-peer=yes \
- -chardev socket,id=charserial1,host=127.0.0.1,port=5555,\
- tls-creds=objcharserial1_tls0 \
- -device isa-serial,chardev=charserial1,id=serial1 \
-diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args
-index 91f1fe0cd..2567abbfa 100644
---- a/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args
-+++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args
-@@ -31,7 +31,7 @@ localport=1111 \
- data=9eao5F8qtkGt+seB1HYivWIxbtwUu6MQtg1zpj/oDtUsPr1q8wBYM91uEHCn6j/1,\
- keyid=masterKey0,iv=AAECAwQFBgcICQoLDA0ODw==,format=base64 \
- -object tls-creds-x509,id=objcharserial1_tls0,dir=/etc/pki/libvirt-chardev,\
--endpoint=client,verify-peer=no,passwordid=charserial1-secret0 \
-+endpoint=client,verify-peer=yes,passwordid=charserial1-secret0 \
- -chardev socket,id=charserial1,host=127.0.0.1,port=5555,\
- tls-creds=objcharserial1_tls0 \
- -device isa-serial,chardev=charserial1,id=serial1 \

0004-wireshark-Fix-int-type-of-some-virNetMessageHeader-m.patch

@@ -0,0 +1,133 @@
+From 7374c4ecbd591b02f7be4b2918addc6d5852aafb Mon Sep 17 00:00:00 2001
+Message-ID: <7374c4ecbd591b02f7be4b2918addc6d5852aafb.1760476767.git.crobinso@redhat.com>
+In-Reply-To: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+References: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+From: Michal Privoznik <mprivozn@redhat.com>
+Date: Mon, 13 Oct 2025 09:21:30 +0200
+Subject: [PATCH 4/8] wireshark: Fix int type of some virNetMessageHeader
+ members
+Content-type: text/plain
+
+Our virNetMessageHeader is a struct that's declared as follows:
+
+  struct virNetMessageHeader {
+      unsigned prog;
+      unsigned vers;
+      int proc;
+      virNetMessageType type;
+      unsigned serial;
+      virNetMessageStatus status;
+  };
+
+Now, per RFC 4506 enums are also encoded as signed integers. This
+means, that only 'prog', 'vers' and 'serial' are really unsigned
+integers. The others ('proc', 'type' and 'status') are encoded as
+signed integers. Fix their type when dissecting.
+
+While at it, also follow latest trend in wireshark and switch
+from guint32 to uint32_t.
+
+Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
+Reviewed-by: Peter Krempa <pkrempa@redhat.com>
+Signed-off-by: Cole Robinson <crobinso@redhat.com>
+---
+ tools/wireshark/src/packet-libvirt.c | 34 +++++++++++++++++++---------
+ 1 file changed, 23 insertions(+), 11 deletions(-)
+
+diff --git a/tools/wireshark/src/packet-libvirt.c b/tools/wireshark/src/packet-libvirt.c
+index da2aabd98a..af14c6bed7 100644
+--- a/tools/wireshark/src/packet-libvirt.c
++++ b/tools/wireshark/src/packet-libvirt.c
+@@ -92,7 +92,7 @@ typedef gboolean (*vir_xdr_dissector_t)(tvbuff_t *tvb, proto_tree *tree, XDR *xd
+ 
+ typedef struct vir_dissector_index vir_dissector_index_t;
+ struct vir_dissector_index {
+-    guint32             proc;
++    int32_t             proc;
+     vir_xdr_dissector_t args;
+     vir_xdr_dissector_t ret;
+     vir_xdr_dissector_t msg;
+@@ -275,8 +275,10 @@ dissect_xdr_array(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf, gint ett,
+ }
+ 
+ static vir_xdr_dissector_t
+-find_payload_dissector(guint32 proc, guint32 type,
+-                       const vir_dissector_index_t *pds, gsize length)
++find_payload_dissector(int32_t proc,
++                       enum vir_net_message_type type,
++                       const vir_dissector_index_t *pds,
++                       gsize length)
+ {
+     const vir_dissector_index_t *pd;
+     guint32 first, last, direction;
+@@ -309,6 +311,10 @@ find_payload_dissector(guint32 proc, guint32 type,
+         return pd->ret;
+     case VIR_NET_MESSAGE:
+         return pd->msg;
++    case VIR_NET_STREAM:
++    case VIR_NET_STREAM_HOLE:
++        /* Handled elsewhere */
++        return NULL;
+     }
+     return NULL;
+ }
+@@ -397,8 +403,12 @@ dissect_xdr_stream_hole(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf)
+ #include "libvirt/protocol.h"
+ 
+ static void
+-dissect_libvirt_payload(tvbuff_t *tvb, proto_tree *tree,
+-                        guint32 prog, guint32 proc, guint32 type, guint32 status)
++dissect_libvirt_payload(tvbuff_t *tvb,
++                        proto_tree *tree,
++                        uint32_t prog,
++                        int32_t proc,
++                        int32_t type,
++                        int32_t status)
+ {
+     gssize payload_length;
+ 
+@@ -430,7 +440,8 @@ dissect_libvirt_payload(tvbuff_t *tvb, proto_tree *tree,
+     return;
+ 
+  unknown:
+-    dbg("Cannot determine payload: Prog=%u, Proc=%u, Type=%u, Status=%u", prog, proc, type, status);
++    dbg("Cannot determine payload: Prog=%u, Proc=%d, Type=%d, Status=%d",
++        prog, proc, type, status);
+     proto_tree_add_item(tree, hf_libvirt_unknown, tvb, VIR_HEADER_LEN, -1, ENC_NA);
+ }
+ 
+@@ -439,7 +450,8 @@ dissect_libvirt_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+                         void *opaque G_GNUC_UNUSED)
+ {
+     goffset offset;
+-    guint32 prog, proc, type, serial, status;
++    uint32_t prog, serial;
++    int32_t proc, type, status;
+     const value_string *vs;
+ 
+     col_set_str(pinfo->cinfo, COL_PROTOCOL, "Libvirt");
+@@ -448,17 +460,17 @@ dissect_libvirt_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+     offset = 4; /* End of length field */
+     prog   = tvb_get_ntohl(tvb, offset); offset += 4;
+     offset += 4; /* Ignore version header field */
+-    proc   = tvb_get_ntohl(tvb, offset); offset += 4;
+-    type   = tvb_get_ntohl(tvb, offset); offset += 4;
++    proc   = tvb_get_ntohil(tvb, offset); offset += 4;
++    type   = tvb_get_ntohil(tvb, offset); offset += 4;
+     serial = tvb_get_ntohl(tvb, offset); offset += 4;
+-    status = tvb_get_ntohl(tvb, offset); offset += 4;
++    status = tvb_get_ntohil(tvb, offset); offset += 4;
+ 
+     col_add_fstr(pinfo->cinfo, COL_INFO, "Prog=%s",
+                  val_to_str(prog, program_strings, "%x"));
+ 
+     vs = get_program_data(prog, VIR_PROGRAM_PROCSTRINGS);
+     if (vs == NULL) {
+-        col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%u", proc);
++        col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%d", proc);
+     } else {
+         col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%s", val_to_str(proc, vs, "%d"));
+     }
+-- 
+2.51.0
+

0005-qemu-Move-snapshot-disk-validation-functions-into-on.patch

@@ -1,177 +0,0 @@
-From: Peter Krempa <pkrempa@redhat.com>
-Date: Wed, 15 Nov 2017 13:15:57 +0100
-Subject: [PATCH] qemu: Move snapshot disk validation functions into one
-
-Move the code so that both the new image and old image can be verified
-in the same function.
-
-(cherry picked from commit 8ffdeed455650557df531aafc66c20b31bd4e0c4)
----
- src/qemu/qemu_driver.c | 91 ++++++++++++++++++++------------------------------
- 1 file changed, 36 insertions(+), 55 deletions(-)
-
-diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
-index 1f9264639..57f0c2bf4 100644
---- a/src/qemu/qemu_driver.c
-+++ b/src/qemu/qemu_driver.c
-@@ -13793,17 +13793,19 @@ qemuDomainSnapshotCreateActiveInternal(virConnectPtr conn,
- 
- 
- static int
--qemuDomainSnapshotPrepareDiskExternalBackingInactive(virDomainDiskDefPtr disk)
-+qemuDomainSnapshotPrepareDiskExternalInactive(virDomainSnapshotDiskDefPtr snapdisk,
-+                                              virDomainDiskDefPtr domdisk)
- {
--    int actualType = virStorageSourceGetActualType(disk->src);
-+    int domDiskType = virStorageSourceGetActualType(domdisk->src);
-+    int snapDiskType = virStorageSourceGetActualType(snapdisk->src);
- 
--    switch ((virStorageType) actualType) {
-+    switch ((virStorageType) domDiskType) {
-     case VIR_STORAGE_TYPE_BLOCK:
-     case VIR_STORAGE_TYPE_FILE:
--        return 0;
-+        break;
- 
-     case VIR_STORAGE_TYPE_NETWORK:
--        switch ((virStorageNetProtocol) disk->src->protocol) {
-+        switch ((virStorageNetProtocol) domdisk->src->protocol) {
-         case VIR_STORAGE_NET_PROTOCOL_NONE:
-         case VIR_STORAGE_NET_PROTOCOL_NBD:
-         case VIR_STORAGE_NET_PROTOCOL_RBD:
-@@ -13820,7 +13822,7 @@ qemuDomainSnapshotPrepareDiskExternalBackingInactive(virDomainDiskDefPtr disk)
-             virReportError(VIR_ERR_INTERNAL_ERROR,
-                            _("external inactive snapshots are not supported on "
-                              "'network' disks using '%s' protocol"),
--                           virStorageNetProtocolTypeToString(disk->src->protocol));
-+                           virStorageNetProtocolTypeToString(domdisk->src->protocol));
-             return -1;
-         }
-         break;
-@@ -13831,7 +13833,23 @@ qemuDomainSnapshotPrepareDiskExternalBackingInactive(virDomainDiskDefPtr disk)
-     case VIR_STORAGE_TYPE_LAST:
-         virReportError(VIR_ERR_INTERNAL_ERROR,
-                        _("external inactive snapshots are not supported on "
--                         "'%s' disks"), virStorageTypeToString(actualType));
-+                         "'%s' disks"), virStorageTypeToString(domDiskType));
-+        return -1;
-+    }
-+
-+    switch ((virStorageType) snapDiskType) {
-+    case VIR_STORAGE_TYPE_BLOCK:
-+    case VIR_STORAGE_TYPE_FILE:
-+        break;
-+
-+    case VIR_STORAGE_TYPE_NETWORK:
-+    case VIR_STORAGE_TYPE_DIR:
-+    case VIR_STORAGE_TYPE_VOLUME:
-+    case VIR_STORAGE_TYPE_NONE:
-+    case VIR_STORAGE_TYPE_LAST:
-+        virReportError(VIR_ERR_INTERNAL_ERROR,
-+                       _("external inactive snapshots are not supported on "
-+                         "'%s' disks"), virStorageTypeToString(snapDiskType));
-         return -1;
-     }
- 
-@@ -13840,33 +13858,27 @@ qemuDomainSnapshotPrepareDiskExternalBackingInactive(virDomainDiskDefPtr disk)
- 
- 
- static int
--qemuDomainSnapshotPrepareDiskExternalBackingActive(virDomainDiskDefPtr disk)
-+qemuDomainSnapshotPrepareDiskExternalActive(virDomainSnapshotDiskDefPtr snapdisk,
-+                                            virDomainDiskDefPtr domdisk)
- {
--    if (disk->device == VIR_DOMAIN_DISK_DEVICE_LUN) {
-+    int actualType = virStorageSourceGetActualType(snapdisk->src);
-+
-+    if (domdisk->device == VIR_DOMAIN_DISK_DEVICE_LUN) {
-         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                        _("external active snapshots are not supported on scsi "
-                          "passthrough devices"));
-         return -1;
-     }
- 
--    return 0;
--}
--
--
--static int
--qemuDomainSnapshotPrepareDiskExternalOverlayActive(virDomainSnapshotDiskDefPtr disk)
--{
--    int actualType = virStorageSourceGetActualType(disk->src);
--
-     switch ((virStorageType) actualType) {
-     case VIR_STORAGE_TYPE_BLOCK:
-     case VIR_STORAGE_TYPE_FILE:
--        return 0;
-+        break;
- 
-     case VIR_STORAGE_TYPE_NETWORK:
--        switch ((virStorageNetProtocol) disk->src->protocol) {
-+        switch ((virStorageNetProtocol) snapdisk->src->protocol) {
-         case VIR_STORAGE_NET_PROTOCOL_GLUSTER:
--            return 0;
-+            break;
- 
-         case VIR_STORAGE_NET_PROTOCOL_NONE:
-         case VIR_STORAGE_NET_PROTOCOL_NBD:
-@@ -13883,7 +13895,7 @@ qemuDomainSnapshotPrepareDiskExternalOverlayActive(virDomainSnapshotDiskDefPtr d
-             virReportError(VIR_ERR_INTERNAL_ERROR,
-                            _("external active snapshots are not supported on "
-                              "'network' disks using '%s' protocol"),
--                           virStorageNetProtocolTypeToString(disk->src->protocol));
-+                           virStorageNetProtocolTypeToString(snapdisk->src->protocol));
-             return -1;
- 
-         }
-@@ -13903,31 +13915,6 @@ qemuDomainSnapshotPrepareDiskExternalOverlayActive(virDomainSnapshotDiskDefPtr d
- }
- 
- 
--static int
--qemuDomainSnapshotPrepareDiskExternalOverlayInactive(virDomainSnapshotDiskDefPtr disk)
--{
--    int actualType = virStorageSourceGetActualType(disk->src);
--
--    switch ((virStorageType) actualType) {
--    case VIR_STORAGE_TYPE_BLOCK:
--    case VIR_STORAGE_TYPE_FILE:
--        return 0;
--
--    case VIR_STORAGE_TYPE_NETWORK:
--    case VIR_STORAGE_TYPE_DIR:
--    case VIR_STORAGE_TYPE_VOLUME:
--    case VIR_STORAGE_TYPE_NONE:
--    case VIR_STORAGE_TYPE_LAST:
--        virReportError(VIR_ERR_INTERNAL_ERROR,
--                       _("external inactive snapshots are not supported on "
--                         "'%s' disks"), virStorageTypeToString(actualType));
--        return -1;
--    }
--
--    return 0;
--}
--
--
- static int
- qemuDomainSnapshotPrepareDiskExternal(virConnectPtr conn,
-                                       virDomainDiskDefPtr disk,
-@@ -13945,16 +13932,10 @@ qemuDomainSnapshotPrepareDiskExternal(virConnectPtr conn,
-         if (virStorageTranslateDiskSourcePool(conn, disk) < 0)
-             return -1;
- 
--        if (qemuDomainSnapshotPrepareDiskExternalBackingInactive(disk) < 0)
--            return -1;
--
--        if (qemuDomainSnapshotPrepareDiskExternalOverlayInactive(snapdisk) < 0)
-+        if (qemuDomainSnapshotPrepareDiskExternalInactive(snapdisk, disk) < 0)
-             return -1;
-     } else {
--        if (qemuDomainSnapshotPrepareDiskExternalBackingActive(disk) < 0)
--            return -1;
--
--        if (qemuDomainSnapshotPrepareDiskExternalOverlayActive(snapdisk) < 0)
-+        if (qemuDomainSnapshotPrepareDiskExternalActive(snapdisk, disk) < 0)
-             return -1;
-     }
- 

0005-wireshark-Don-t-special-case-retval-of-get_program_d.patch

@@ -0,0 +1,46 @@
+From 1086888f95a322101f8cf53b63c96600ccbeb882 Mon Sep 17 00:00:00 2001
+Message-ID: <1086888f95a322101f8cf53b63c96600ccbeb882.1760476767.git.crobinso@redhat.com>
+In-Reply-To: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+References: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+From: Michal Privoznik <mprivozn@redhat.com>
+Date: Fri, 10 Oct 2025 19:16:54 +0200
+Subject: [PATCH 5/8] wireshark: Don't special case retval of
+ get_program_data() in dissect_libvirt_message()
+Content-type: text/plain
+
+The get_program_data() function returns a pointer (in this
+specific case to an array of procedure strings) which, if
+non-NULL is then passed val_to_str(). Well, if val_to_str() sees
+NULL it is treated gracefully, i.e. like if the numeric value
+'proc' wasn't found in the array.
+
+Therefore, there's no need to special case call to
+col_append_fstr(). Both result into the same behaviour.
+
+Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
+Reviewed-by: Peter Krempa <pkrempa@redhat.com>
+Signed-off-by: Cole Robinson <crobinso@redhat.com>
+---
+ tools/wireshark/src/packet-libvirt.c | 6 +-----
+ 1 file changed, 1 insertion(+), 5 deletions(-)
+
+diff --git a/tools/wireshark/src/packet-libvirt.c b/tools/wireshark/src/packet-libvirt.c
+index af14c6bed7..6c729801d4 100644
+--- a/tools/wireshark/src/packet-libvirt.c
++++ b/tools/wireshark/src/packet-libvirt.c
+@@ -469,11 +469,7 @@ dissect_libvirt_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+                  val_to_str(prog, program_strings, "%x"));
+ 
+     vs = get_program_data(prog, VIR_PROGRAM_PROCSTRINGS);
+-    if (vs == NULL) {
+-        col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%d", proc);
+-    } else {
+-        col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%s", val_to_str(proc, vs, "%d"));
+-    }
++    col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%s", val_to_str(proc, vs, "%d"));
+ 
+     col_append_fstr(pinfo->cinfo, COL_INFO, " Type=%s Serial=%u Status=%s",
+                     val_to_str(type, type_strings, "%d"), serial,
+-- 
+2.51.0
+

0006-qemu-block-Add-function-to-check-if-storage-source-a.patch

@@ -1,55 +0,0 @@
-From: Peter Krempa <pkrempa@redhat.com>
-Date: Tue, 14 Nov 2017 15:34:46 +0100
-Subject: [PATCH] qemu: block: Add function to check if storage source allows
- concurrent access
-
-Storage source format backing a shared device (e.g. running a cluster
-filesystem) needs to support the sharing so that metadata are not
-corrupted. Add a central function for checking this.
-
-(cherry picked from commit 1fc3cd8731640aefc48bbd9fc489f21cb99c6f67)
----
- src/qemu/qemu_block.c | 15 +++++++++++++++
- src/qemu/qemu_block.h |  3 +++
- 2 files changed, 18 insertions(+)
-
-diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
-index 7fb12ea5a..4c0a5eb78 100644
---- a/src/qemu/qemu_block.c
-+++ b/src/qemu/qemu_block.c
-@@ -379,6 +379,21 @@ qemuBlockGetNodeData(virJSONValuePtr data)
- }
- 
- 
-+/**
-+ * qemuBlockStorageSourceSupportsConcurrentAccess:
-+ * @src: disk storage source
-+ *
-+ * Returns true if the given storage format supports concurrent access from two
-+ * separate processes.
-+ */
-+bool
-+qemuBlockStorageSourceSupportsConcurrentAccess(virStorageSourcePtr src)
-+{
-+    /* no need to check in backing chain since only RAW storage supports this */
-+    return src->format == VIR_STORAGE_FILE_RAW;
-+}
-+
-+
- /**
-  * qemuBlockStorageSourceBuildHostsJSONSocketAddress:
-  * @src: disk storage source
-diff --git a/src/qemu/qemu_block.h b/src/qemu/qemu_block.h
-index f0a2c9aa7..ebf3149ce 100644
---- a/src/qemu/qemu_block.h
-+++ b/src/qemu/qemu_block.h
-@@ -53,6 +53,9 @@ qemuBlockNodeNamesDetect(virQEMUDriverPtr driver,
- virHashTablePtr
- qemuBlockGetNodeData(virJSONValuePtr data);
- 
-+bool
-+qemuBlockStorageSourceSupportsConcurrentAccess(virStorageSourcePtr src);
-+
- virJSONValuePtr
- qemuBlockStorageSourceGetBackendProps(virStorageSourcePtr src);
- 

0006-wireshark-Introduce-and-use-vir_val_to_str.patch

@@ -0,0 +1,68 @@
+From ba2c4bdd5cbccd5c0673149cf76802c98b70d2f7 Mon Sep 17 00:00:00 2001
+Message-ID: <ba2c4bdd5cbccd5c0673149cf76802c98b70d2f7.1760476767.git.crobinso@redhat.com>
+In-Reply-To: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+References: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+From: Michal Privoznik <mprivozn@redhat.com>
+Date: Fri, 10 Oct 2025 18:23:18 +0200
+Subject: [PATCH 6/8] wireshark: Introduce and use vir_val_to_str()
+Content-type: text/plain
+
+Wireshark offers val_to_str() function which converts numeric
+value to string by looking up value ('val') in an array ('vs') of
+<val, string> pairs. If no corresponding string is found, then
+the value is formatted using given 'fmt' string.
+
+Starting from wireshark-4.6.0 not only this function gained
+another argument but also returns a strdup()-ed string. To keep
+our code simple, let's introduce a wrapper so which can be then
+adjusted as needed.
+
+Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
+Reviewed-by: Peter Krempa <pkrempa@redhat.com>
+Signed-off-by: Cole Robinson <crobinso@redhat.com>
+---
+ tools/wireshark/src/packet-libvirt.c | 17 +++++++++++++----
+ 1 file changed, 13 insertions(+), 4 deletions(-)
+
+diff --git a/tools/wireshark/src/packet-libvirt.c b/tools/wireshark/src/packet-libvirt.c
+index 6c729801d4..f6ad2c4578 100644
+--- a/tools/wireshark/src/packet-libvirt.c
++++ b/tools/wireshark/src/packet-libvirt.c
+@@ -140,6 +140,15 @@ static const value_string status_strings[] = {
+     { -1, NULL }
+ };
+ 
++static const char *
++G_GNUC_PRINTF(3, 0)
++vir_val_to_str(const uint32_t val,
++               const value_string *vs,
++               const char *fmt)
++{
++    return val_to_str(val, vs, fmt);
++}
++
+ static gboolean
+ dissect_xdr_string(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
+                    guint32 maxlen)
+@@ -466,14 +475,14 @@ dissect_libvirt_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+     status = tvb_get_ntohil(tvb, offset); offset += 4;
+ 
+     col_add_fstr(pinfo->cinfo, COL_INFO, "Prog=%s",
+-                 val_to_str(prog, program_strings, "%x"));
++                 vir_val_to_str(prog, program_strings, "%x"));
+ 
+     vs = get_program_data(prog, VIR_PROGRAM_PROCSTRINGS);
+-    col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%s", val_to_str(proc, vs, "%d"));
++    col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%s", vir_val_to_str(proc, vs, "%d"));
+ 
+     col_append_fstr(pinfo->cinfo, COL_INFO, " Type=%s Serial=%u Status=%s",
+-                    val_to_str(type, type_strings, "%d"), serial,
+-                    val_to_str(status, status_strings, "%d"));
++                    vir_val_to_str(type, type_strings, "%d"), serial,
++                    vir_val_to_str(status, status_strings, "%d"));
+ 
+     if (tree) {
+         gint *hf_proc;
+-- 
+2.51.0
+

0007-qemu-domain-Reject-shared-disk-access-if-backing-for.patch

@@ -1,146 +0,0 @@
-From: Peter Krempa <pkrempa@redhat.com>
-Date: Tue, 14 Nov 2017 15:37:09 +0100
-Subject: [PATCH] qemu: domain: Reject shared disk access if backing format
- does not support it
-
-Disk sharing between two VMs may corrupt the images if the format driver
-does not support it. Check that the user declared use of a supported
-storage format when they want to share the disk.
-
-Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1511480
-(cherry picked from commit 3b03a27cd00c2f032661d2bf8905795425752fc7)
----
- src/qemu/qemu_domain.c                             | 29 +++++++++++++++++++++-
- .../qemuxml2argv-disk-drive-shared-qcow.xml        | 28 +++++++++++++++++++++
- .../qemuxml2argv-disk-drive-shared.args            |  2 +-
- .../qemuxml2argv-disk-drive-shared.xml             |  2 +-
- tests/qemuxml2argvtest.c                           |  1 +
- 5 files changed, 59 insertions(+), 3 deletions(-)
- create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-qcow.xml
-
-diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
-index b98ffffae..42d17c1b0 100644
---- a/src/qemu/qemu_domain.c
-+++ b/src/qemu/qemu_domain.c
-@@ -25,6 +25,7 @@
- 
- #include "qemu_domain.h"
- #include "qemu_alias.h"
-+#include "qemu_block.h"
- #include "qemu_cgroup.h"
- #include "qemu_command.h"
- #include "qemu_process.h"
-@@ -3299,6 +3300,29 @@ qemuDomainRedirdevDefValidate(const virDomainRedirdevDef *def)
- }
- 
- 
-+static int
-+qemuDomainDeviceDefValidateDisk(const virDomainDiskDef *disk)
-+{
-+    if (disk->src->shared && !disk->src->readonly) {
-+        if (disk->src->format <= VIR_STORAGE_FILE_AUTO) {
-+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-+                           _("shared access for disk '%s' requires use of "
-+                             "explicitly specified disk format"), disk->dst);
-+            return -1;
-+        }
-+
-+        if (!qemuBlockStorageSourceSupportsConcurrentAccess(disk->src)) {
-+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-+                           _("shared access for disk '%s' requires use of "
-+                             "supported storage format"), disk->dst);
-+            return -1;
-+        }
-+    }
-+
-+    return 0;
-+}
-+
-+
- static int
- qemuDomainDeviceDefValidate(const virDomainDeviceDef *dev,
-                             const virDomainDef *def ATTRIBUTE_UNUSED,
-@@ -3308,7 +3332,10 @@ qemuDomainDeviceDefValidate(const virDomainDeviceDef *dev,
-     virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
-     int ret = -1;
- 
--    if (dev->type == VIR_DOMAIN_DEVICE_NET) {
-+    if (dev->type == VIR_DOMAIN_DEVICE_DISK) {
-+        if (qemuDomainDeviceDefValidateDisk(dev->data.disk) < 0)
-+            goto cleanup;
-+    } else if (dev->type == VIR_DOMAIN_DEVICE_NET) {
-         const virDomainNetDef *net = dev->data.net;
- 
-         if (net->guestIP.nroutes || net->guestIP.nips) {
-diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-qcow.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-qcow.xml
-new file mode 100644
-index 000000000..ca88a944b
---- /dev/null
-+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-qcow.xml
-@@ -0,0 +1,28 @@
-+<domain type='qemu'>
-+  <name>QEMUGuest1</name>
-+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-+  <memory unit='KiB'>219136</memory>
-+  <currentMemory unit='KiB'>219136</currentMemory>
-+  <vcpu placement='static'>1</vcpu>
-+  <os>
-+    <type arch='i686' machine='pc'>hvm</type>
-+    <boot dev='hd'/>
-+  </os>
-+  <clock offset='utc'/>
-+  <on_poweroff>destroy</on_poweroff>
-+  <on_reboot>restart</on_reboot>
-+  <on_crash>destroy</on_crash>
-+  <devices>
-+    <emulator>/usr/bin/qemu-system-i686</emulator>
-+    <disk type='block' device='disk'>
-+      <driver name='qemu' type='qcow2'/>
-+      <source dev='/dev/HostVG/QEMUGuest1'/>
-+      <target dev='hda' bus='ide'/>
-+      <shareable/>
-+      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
-+    </disk>
-+    <controller type='usb' index='0'/>
-+    <controller type='ide' index='0'/>
-+    <memballoon model='virtio'/>
-+  </devices>
-+</domain>
-diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.args
-index 502157bf8..326fde1b3 100644
---- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.args
-+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.args
-@@ -19,7 +19,7 @@ server,nowait \
- -no-acpi \
- -boot c \
- -usb \
---drive file=/dev/HostVG/QEMUGuest1,format=qcow2,if=none,id=drive-ide0-0-0,\
-+-drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0,\
- serial=XYZXYZXYZYXXYZYZYXYZY,cache=none \
- -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \
- -drive file=/dev/HostVG/QEMUGuest2,format=raw,if=none,media=cdrom,\
-diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml
-index 9f7472378..677c2b0b7 100644
---- a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml
-+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml
-@@ -15,7 +15,7 @@
-   <devices>
-     <emulator>/usr/bin/qemu-system-i686</emulator>
-     <disk type='block' device='disk'>
--      <driver name='qemu' type='qcow2'/>
-+      <driver name='qemu' type='raw'/>
-       <source dev='/dev/HostVG/QEMUGuest1'/>
-       <target dev='hda' bus='ide'/>
-       <shareable/>
-diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
-index 18f06e5aa..93f892229 100644
---- a/tests/qemuxml2argvtest.c
-+++ b/tests/qemuxml2argvtest.c
-@@ -895,6 +895,7 @@ mymain(void)
-             QEMU_CAPS_DRIVE_BOOT);
-     DO_TEST("disk-drive-shared",
-             QEMU_CAPS_DRIVE_SERIAL);
-+    DO_TEST_PARSE_ERROR("disk-drive-shared-qcow", NONE);
-     DO_TEST("disk-drive-error-policy-stop",
-             QEMU_CAPS_MONITOR_JSON);
-     DO_TEST("disk-drive-error-policy-enospace",

0007-wireshark-Don-t-leak-column-strings.patch

@@ -0,0 +1,165 @@
+From 002b9f559d69b92e77ab2d234df6966fecdaf0ec Mon Sep 17 00:00:00 2001
+Message-ID: <002b9f559d69b92e77ab2d234df6966fecdaf0ec.1760476767.git.crobinso@redhat.com>
+In-Reply-To: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+References: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+From: Michal Privoznik <mprivozn@redhat.com>
+Date: Fri, 10 Oct 2025 19:13:48 +0200
+Subject: [PATCH 7/8] wireshark: Don't leak column strings
+Content-type: text/plain
+
+One of the problems of using val_to_str() is that it may return a
+const string from given table ('vs'), OR return an allocated one.
+Since the caller has no idea which case it is, it resides to safe
+option and don't free returned string. But that might lead to a
+memleak. This behaviour is fixed with wireshark-4.6.0 and support
+for it will be introduced soon. But first, make vir_val_to_str()
+behave like fixed val_to_str() from newer wireshark: just always
+allocate the string.
+
+Now, if val_to_str() needs to allocate new memory it obtains
+allocator by calling wmem_packet_scope() which is what we may do
+too.
+
+Hand in hand with that, we need to free the memory using the
+correct allocator, hence wmem_free(). But let's put it into a
+wrapper vir_wmem_free() because just like val_to_str(), it'll
+need additional argument when adapting to new wireshark.
+
+Oh, and freeing the memory right after col_add_fstr() is safe as
+it uses vsnprintf() under the hood to format passed args.
+
+One last thing, the wmem.h file used to live under epan/wmem/ but
+then in v3.5.0~240 [1] was moved to wsutil/wmem/.
+
+1: https://gitlab.com/wireshark/wireshark/-/commit/7f9c1f5f92c131354fc8b2b88d473706786064c0
+Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
+Reviewed-by: Peter Krempa <pkrempa@redhat.com>
+Signed-off-by: Cole Robinson <crobinso@redhat.com>
+---
+ meson.build                          | 20 ++++++++++++++++
+ tools/wireshark/src/meson.build      |  1 +
+ tools/wireshark/src/packet-libvirt.c | 35 ++++++++++++++++++++++------
+ 3 files changed, 49 insertions(+), 7 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index bcc18b20e5..a1e0e5ecd5 100644
+--- a/meson.build
++++ b/meson.build
+@@ -1365,6 +1365,26 @@ if wireshark_dep.found()
+   if cc.check_header('wireshark/ws_version.h')
+     conf.set('WITH_WS_VERSION', 1)
+   endif
++
++  # Find wmem.h
++  # But it's not as easy as you'd think. Ubuntu 20.04 has split parts of
++  # libwireshark.so into libwsutil.so but:
++  # a) wireshark.pc never mentions it,
++  # b) libwsutil-dev package doesn't install pkg-config file.
++  # Fortunately, it's fixed in 24.04.
++  if cc.check_header('wireshark/epan/wmem/wmem.h', dependencies: wireshark_dep)
++    conf.set('WITH_WS_EPAN_WMEM', 1)
++  elif cc.check_header('wireshark/wsutil/wmem/wmem.h', dependencies: wireshark_dep)
++    conf.set('WITH_WS_WSUTIL_WMEM', 1)
++  else
++    error('Unable to locate wmem.h file')
++  endif
++
++  # TODO: drop wsutil dep once support for Ubuntu 20.04 is dropped
++  wsutil_dep = dependency('', required: false)
++  if not cc.has_function('wmem_free', dependencies: wireshark_dep)
++    wsutil_dep = cc.find_library('wsutil', required: true)
++  endif
+ endif
+ 
+ # generic build dependencies checks
+diff --git a/tools/wireshark/src/meson.build b/tools/wireshark/src/meson.build
+index 9b452dc5ca..ba0df913e0 100644
+--- a/tools/wireshark/src/meson.build
++++ b/tools/wireshark/src/meson.build
+@@ -9,6 +9,7 @@ shared_library(
+   ],
+   dependencies: [
+     wireshark_dep,
++    wsutil_dep,
+     xdr_dep,
+     tools_dep,
+   ],
+diff --git a/tools/wireshark/src/packet-libvirt.c b/tools/wireshark/src/packet-libvirt.c
+index f6ad2c4578..3178ac6f27 100644
+--- a/tools/wireshark/src/packet-libvirt.c
++++ b/tools/wireshark/src/packet-libvirt.c
+@@ -21,6 +21,11 @@
+ #include <wireshark/epan/proto.h>
+ #include <wireshark/epan/packet.h>
+ #include <wireshark/epan/dissectors/packet-tcp.h>
++#ifdef WITH_WS_EPAN_WMEM
++# include <wireshark/epan/wmem/wmem.h>
++#elif WITH_WS_WSUTIL_WMEM
++# include <wireshark/wsutil/wmem/wmem.h>
++#endif
+ #include <rpc/types.h>
+ #include <rpc/xdr.h>
+ #include "packet-libvirt.h"
+@@ -140,13 +145,19 @@ static const value_string status_strings[] = {
+     { -1, NULL }
+ };
+ 
+-static const char *
++static char *
+ G_GNUC_PRINTF(3, 0)
+ vir_val_to_str(const uint32_t val,
+                const value_string *vs,
+                const char *fmt)
+ {
+-    return val_to_str(val, vs, fmt);
++    return val_to_str_wmem(wmem_packet_scope(), val, vs, fmt);
++}
++
++static void
++vir_wmem_free(void *ptr)
++{
++    wmem_free(wmem_packet_scope(), ptr);
+ }
+ 
+ static gboolean
+@@ -462,6 +473,10 @@ dissect_libvirt_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+     uint32_t prog, serial;
+     int32_t proc, type, status;
+     const value_string *vs;
++    char *prog_str = NULL;
++    char *proc_str = NULL;
++    char *type_str = NULL;
++    char *status_str = NULL;
+ 
+     col_set_str(pinfo->cinfo, COL_PROTOCOL, "Libvirt");
+     col_clear(pinfo->cinfo, COL_INFO);
+@@ -474,15 +489,21 @@ dissect_libvirt_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+     serial = tvb_get_ntohl(tvb, offset); offset += 4;
+     status = tvb_get_ntohil(tvb, offset); offset += 4;
+ 
+-    col_add_fstr(pinfo->cinfo, COL_INFO, "Prog=%s",
+-                 vir_val_to_str(prog, program_strings, "%x"));
++    prog_str = vir_val_to_str(prog, program_strings, "%x");
++    col_add_fstr(pinfo->cinfo, COL_INFO, "Prog=%s", prog_str);
++    vir_wmem_free(prog_str);
+ 
+     vs = get_program_data(prog, VIR_PROGRAM_PROCSTRINGS);
+-    col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%s", vir_val_to_str(proc, vs, "%d"));
++    proc_str = vir_val_to_str(proc, vs, "%d");
++    col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%s", proc_str);
++    vir_wmem_free(proc_str);
+ 
++    type_str = vir_val_to_str(type, type_strings, "%d");
++    status_str = vir_val_to_str(status, status_strings, "%d");
+     col_append_fstr(pinfo->cinfo, COL_INFO, " Type=%s Serial=%u Status=%s",
+-                    vir_val_to_str(type, type_strings, "%d"), serial,
+-                    vir_val_to_str(status, status_strings, "%d"));
++                    type_str, serial, status_str);
++    vir_wmem_free(status_str);
++    vir_wmem_free(type_str);
+ 
+     if (tree) {
+         gint *hf_proc;
+-- 
+2.51.0
+

0008-qemu-snapshot-Disallow-snapshot-of-unsupported-share.patch

@@ -1,63 +0,0 @@
-From: Peter Krempa <pkrempa@redhat.com>
-Date: Wed, 15 Nov 2017 13:41:01 +0100
-Subject: [PATCH] qemu: snapshot: Disallow snapshot of unsupported shared disks
-
-Creating a snapshot would introduce a possibly unsupported member for
-sharing into the backing chain. Add a check to prevent that from
-happening.
-
-Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1511480
-(cherry picked from commit 9b2fbfa6f6b535b9f41a7503531d43d86d7a8868)
----
- src/qemu/qemu_driver.c | 24 ++++++++++++++++++++++++
- 1 file changed, 24 insertions(+)
-
-diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
-index 57f0c2bf4..91119a494 100644
---- a/src/qemu/qemu_driver.c
-+++ b/src/qemu/qemu_driver.c
-@@ -13792,6 +13792,24 @@ qemuDomainSnapshotCreateActiveInternal(virConnectPtr conn,
- }
- 
- 
-+static int
-+qemuDomainSnapshotPrepareDiskShared(virDomainSnapshotDiskDefPtr snapdisk,
-+                                    virDomainDiskDefPtr domdisk)
-+{
-+    if (!domdisk->src->shared || domdisk->src->readonly)
-+        return 0;
-+
-+    if (!qemuBlockStorageSourceSupportsConcurrentAccess(snapdisk->src)) {
-+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-+                       _("shared access for disk '%s' requires use of "
-+                         "supported storage format"), domdisk->dst);
-+        return -1;
-+    }
-+
-+    return 0;
-+}
-+
-+
- static int
- qemuDomainSnapshotPrepareDiskExternalInactive(virDomainSnapshotDiskDefPtr snapdisk,
-                                               virDomainDiskDefPtr domdisk)
-@@ -13853,6 +13871,9 @@ qemuDomainSnapshotPrepareDiskExternalInactive(virDomainSnapshotDiskDefPtr snapdi
-         return -1;
-     }
- 
-+    if (qemuDomainSnapshotPrepareDiskShared(snapdisk, domdisk) < 0)
-+        return -1;
-+
-     return 0;
- }
- 
-@@ -13911,6 +13932,9 @@ qemuDomainSnapshotPrepareDiskExternalActive(virDomainSnapshotDiskDefPtr snapdisk
-         return -1;
-     }
- 
-+    if (qemuDomainSnapshotPrepareDiskShared(snapdisk, domdisk) < 0)
-+        return -1;
-+
-     return 0;
- }
- 

0008-wireshark-Adapt-to-wireshark-4.6.0.patch

@@ -0,0 +1,493 @@
+From b42a12174c787b99cd6fcb29b44e4b13bd64ee58 Mon Sep 17 00:00:00 2001
+Message-ID: <b42a12174c787b99cd6fcb29b44e4b13bd64ee58.1760476767.git.crobinso@redhat.com>
+In-Reply-To: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+References: <b825bb556bd3967bf5422c243b77bd4038e317e2.1760476767.git.crobinso@redhat.com>
+From: Michal Privoznik <mprivozn@redhat.com>
+Date: Fri, 10 Oct 2025 15:22:34 +0200
+Subject: [PATCH 8/8] wireshark: Adapt to wireshark-4.6.0
+Content-type: text/plain
+
+The main difference is that wmem_packet_scope() is gone [1] but
+the packet_info struct has 'pool` member which points to the
+allocator used for given packet.
+
+Unfortunately, while we were given pointer to packet_info at the
+entry level to our dissector (dissect_libvirt() ->
+tcp_dissect_pdus() -> dissect_libvirt_message()) it was never
+propagated to generated/primitive dissectors.
+
+But not all dissectors need to allocate memory, so mark the new
+argument as unused. And while our generator could be rewritten so
+that the argument is annotated as unused iff it's really unused,
+I couldn't bother rewriting it. It's generated code after all.
+Too much work for little gain.
+
+Another significant change is that val_to_str() now requires new
+argument: pointer to allocator to use because it always allocates
+new memory [2][3].
+
+1: https://gitlab.com/wireshark/wireshark/-/commit/5ca5c9ca372e06881b23ba9f4fdcb6b479886444
+2: https://gitlab.com/wireshark/wireshark/-/commit/b63599762468e4cf1783419a5556377604d344bb
+3: https://gitlab.com/wireshark/wireshark/-/commit/84799be215313e61b83a3eaf074f89d6ee349b8c
+Resolves: https://gitlab.com/libvirt/libvirt/-/issues/823
+Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
+Reviewed-by: Peter Krempa <pkrempa@redhat.com>
+Signed-off-by: Cole Robinson <crobinso@redhat.com>
+---
+ tools/wireshark/src/packet-libvirt.c | 157 +++++++++++++++++++--------
+ tools/wireshark/util/genxdrstub.pl   |  18 +--
+ 2 files changed, 119 insertions(+), 56 deletions(-)
+
+diff --git a/tools/wireshark/src/packet-libvirt.c b/tools/wireshark/src/packet-libvirt.c
+index 3178ac6f27..c5c8fb4756 100644
+--- a/tools/wireshark/src/packet-libvirt.c
++++ b/tools/wireshark/src/packet-libvirt.c
+@@ -63,7 +63,7 @@ static gint ett_libvirt_stream_hole = -1;
+ 
+ #define XDR_PRIMITIVE_DISSECTOR(xtype, ctype, ftype) \
+     static gboolean \
+-    dissect_xdr_##xtype(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf) \
++    dissect_xdr_##xtype(tvbuff_t *tvb, packet_info *pinfo G_GNUC_UNUSED, proto_tree *tree, XDR *xdrs, int hf) \
+     { \
+         goffset start; \
+         ctype val; \
+@@ -93,7 +93,7 @@ XDR_PRIMITIVE_DISSECTOR(bool,    bool_t,   boolean)
+ 
+ VIR_WARNINGS_RESET
+ 
+-typedef gboolean (*vir_xdr_dissector_t)(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf);
++typedef gboolean (*vir_xdr_dissector_t)(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, XDR *xdrs, int hf);
+ 
+ typedef struct vir_dissector_index vir_dissector_index_t;
+ struct vir_dissector_index {
+@@ -146,22 +146,32 @@ static const value_string status_strings[] = {
+ };
+ 
+ static char *
+-G_GNUC_PRINTF(3, 0)
+-vir_val_to_str(const uint32_t val,
++G_GNUC_PRINTF(4, 0)
++vir_val_to_str(packet_info *pinfo,
++               const uint32_t val,
+                const value_string *vs,
+                const char *fmt)
+ {
+-    return val_to_str_wmem(wmem_packet_scope(), val, vs, fmt);
++#if WIRESHARK_VERSION < 4006000
++    return val_to_str_wmem(pinfo->pool, val, vs, fmt);
++#else
++    return val_to_str(pinfo->pool, val, vs, fmt);
++#endif
+ }
+ 
+ static void
+-vir_wmem_free(void *ptr)
++vir_wmem_free(packet_info *pinfo,
++              void *ptr)
+ {
+-    wmem_free(wmem_packet_scope(), ptr);
++    wmem_free(pinfo->pool, ptr);
+ }
+ 
+ static gboolean
+-dissect_xdr_string(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
++dissect_xdr_string(tvbuff_t *tvb,
++                   packet_info *pinfo G_GNUC_UNUSED,
++                   proto_tree *tree,
++                   XDR *xdrs,
++                   int hf,
+                    guint32 maxlen)
+ {
+     goffset start;
+@@ -179,7 +189,11 @@ dissect_xdr_string(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
+ }
+ 
+ static gboolean
+-dissect_xdr_opaque(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
++dissect_xdr_opaque(tvbuff_t *tvb,
++                   packet_info *pinfo,
++                   proto_tree *tree,
++                   XDR *xdrs,
++                   int hf,
+                    guint32 size)
+ {
+     goffset start;
+@@ -190,7 +204,7 @@ dissect_xdr_opaque(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
+     start = xdr_getpos(xdrs);
+     if ((rc = xdr_opaque(xdrs, (caddr_t)val, size))) {
+         gint len = xdr_getpos(xdrs) - start;
+-        const char *s = tvb_bytes_to_str(wmem_packet_scope(), tvb, start, len);
++        const char *s = tvb_bytes_to_str(pinfo->pool, tvb, start, len);
+ 
+         proto_tree_add_bytes_format_value(tree, hf, tvb, start, len, NULL, "%s", s);
+     } else {
+@@ -202,7 +216,11 @@ dissect_xdr_opaque(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
+ }
+ 
+ static gboolean
+-dissect_xdr_bytes(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
++dissect_xdr_bytes(tvbuff_t *tvb,
++                  packet_info *pinfo,
++                  proto_tree *tree,
++                  XDR *xdrs,
++                  int hf,
+                   guint32 maxlen)
+ {
+     goffset start;
+@@ -212,7 +230,7 @@ dissect_xdr_bytes(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
+     start = xdr_getpos(xdrs);
+     if (xdr_bytes(xdrs, (char **)&val, &length, maxlen)) {
+         gint len = xdr_getpos(xdrs) - start;
+-        const char *s = tvb_bytes_to_str(wmem_packet_scope(), tvb, start, len);
++        const char *s = tvb_bytes_to_str(pinfo->pool, tvb, start, len);
+ 
+         proto_tree_add_bytes_format_value(tree, hf, tvb, start, len, NULL, "%s", s);
+         free(val);
+@@ -224,7 +242,11 @@ dissect_xdr_bytes(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
+ }
+ 
+ static gboolean
+-dissect_xdr_pointer(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
++dissect_xdr_pointer(tvbuff_t *tvb,
++                    packet_info *pinfo,
++                    proto_tree *tree,
++                    XDR *xdrs,
++                    int hf,
+                     vir_xdr_dissector_t dissect)
+ {
+     goffset start;
+@@ -236,7 +258,7 @@ dissect_xdr_pointer(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
+         return FALSE;
+     }
+     if (not_null) {
+-        return dissect(tvb, tree, xdrs, hf);
++        return dissect(tvb, pinfo, tree, xdrs, hf);
+     } else {
+         proto_item *ti;
+         ti = proto_tree_add_item(tree, hf, tvb, start, xdr_getpos(xdrs) - start, ENC_NA);
+@@ -246,15 +268,22 @@ dissect_xdr_pointer(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf,
+ }
+ 
+ static gboolean
+-dissect_xdr_iterable(tvbuff_t *tvb, proto_item *ti, XDR *xdrs, gint ett, int rhf,
+-                     guint32 length, vir_xdr_dissector_t dissect, goffset start)
++dissect_xdr_iterable(tvbuff_t *tvb,
++                     packet_info *pinfo,
++                     proto_item *ti,
++                     XDR *xdrs,
++                     gint ett,
++                     int rhf,
++                     guint32 length,
++                     vir_xdr_dissector_t dissect,
++                     goffset start)
+ {
+     proto_tree *tree;
+     guint32 i;
+ 
+     tree = proto_item_add_subtree(ti, ett);
+     for (i = 0; i < length; i++) {
+-        if (!dissect(tvb, tree, xdrs, rhf))
++        if (!dissect(tvb, pinfo, tree, xdrs, rhf))
+             return FALSE;
+     }
+     proto_item_set_len(ti, xdr_getpos(xdrs) - start);
+@@ -262,8 +291,16 @@ dissect_xdr_iterable(tvbuff_t *tvb, proto_item *ti, XDR *xdrs, gint ett, int rhf
+ }
+ 
+ static gboolean
+-dissect_xdr_vector(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf, gint ett,
+-                   int rhf, const gchar *rtype, guint32 size, vir_xdr_dissector_t dissect)
++dissect_xdr_vector(tvbuff_t *tvb,
++                   packet_info *pinfo,
++                   proto_tree *tree,
++                   XDR *xdrs,
++                   int hf,
++                   gint ett,
++                   int rhf,
++                   const gchar *rtype,
++                   guint32 size,
++                   vir_xdr_dissector_t dissect)
+ {
+     goffset start;
+     proto_item *ti;
+@@ -271,12 +308,20 @@ dissect_xdr_vector(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf, gint ett,
+     start = xdr_getpos(xdrs);
+     ti = proto_tree_add_item(tree, hf, tvb, start, -1, ENC_NA);
+     proto_item_append_text(ti, " :: %s[%u]", rtype, size);
+-    return dissect_xdr_iterable(tvb, ti, xdrs, ett, rhf, size, dissect, start);
++    return dissect_xdr_iterable(tvb, pinfo, ti, xdrs, ett, rhf, size, dissect, start);
+ }
+ 
+ static gboolean
+-dissect_xdr_array(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf, gint ett,
+-                  int rhf, const gchar *rtype, guint32 maxlen, vir_xdr_dissector_t dissect)
++dissect_xdr_array(tvbuff_t *tvb,
++                  packet_info *pinfo,
++                  proto_tree *tree,
++                  XDR *xdrs,
++                  int hf,
++                  gint ett,
++                  int rhf,
++                  const gchar *rtype,
++                  guint32 maxlen,
++                  vir_xdr_dissector_t dissect)
+ {
+     goffset start;
+     proto_item *ti;
+@@ -291,7 +336,7 @@ dissect_xdr_array(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf, gint ett,
+ 
+     ti = proto_tree_add_item(tree, hf, tvb, start, -1, ENC_NA);
+     proto_item_append_text(ti, " :: %s<%u>", rtype, length);
+-    return dissect_xdr_iterable(tvb, ti, xdrs, ett, rhf, length, dissect, start);
++    return dissect_xdr_iterable(tvb, pinfo, ti, xdrs, ett, rhf, length, dissect, start);
+ }
+ 
+ static vir_xdr_dissector_t
+@@ -340,7 +385,10 @@ find_payload_dissector(int32_t proc,
+ }
+ 
+ static void
+-dissect_libvirt_stream(tvbuff_t *tvb, proto_tree *tree, gint payload_length)
++dissect_libvirt_stream(tvbuff_t *tvb,
++                       packet_info *pinfo G_GNUC_UNUSED,
++                       proto_tree *tree,
++                       gint payload_length)
+ {
+     proto_tree_add_item(tree, hf_libvirt_stream, tvb, VIR_HEADER_LEN,
+                         payload_length - VIR_HEADER_LEN, ENC_NA);
+@@ -357,6 +405,7 @@ dissect_libvirt_num_of_fds(tvbuff_t *tvb, proto_tree *tree)
+ 
+ static void
+ dissect_libvirt_fds(tvbuff_t *tvb G_GNUC_UNUSED,
++                    packet_info *pinfo G_GNUC_UNUSED,
+                     gint start G_GNUC_UNUSED,
+                     gint32 nfds G_GNUC_UNUSED)
+ {
+@@ -364,8 +413,12 @@ dissect_libvirt_fds(tvbuff_t *tvb G_GNUC_UNUSED,
+ }
+ 
+ static void
+-dissect_libvirt_payload_xdr_data(tvbuff_t *tvb, proto_tree *tree, gint payload_length,
+-                                 gint32 status, vir_xdr_dissector_t dissect)
++dissect_libvirt_payload_xdr_data(tvbuff_t *tvb,
++                                 packet_info *pinfo,
++                                 proto_tree *tree,
++                                 gint payload_length,
++                                 gint32 status,
++                                 vir_xdr_dissector_t dissect)
+ {
+     gint32 nfds = 0;
+     gint start = VIR_HEADER_LEN;
+@@ -384,17 +437,21 @@ dissect_libvirt_payload_xdr_data(tvbuff_t *tvb, proto_tree *tree, gint payload_l
+     payload_data = (caddr_t)tvb_memdup(NULL, payload_tvb, 0, payload_length);
+     xdrmem_create(&xdrs, payload_data, payload_length, XDR_DECODE);
+ 
+-    dissect(payload_tvb, tree, &xdrs, -1);
++    dissect(payload_tvb, pinfo, tree, &xdrs, -1);
+ 
+     xdr_destroy(&xdrs);
+     g_free(payload_data);
+ 
+     if (nfds != 0)
+-        dissect_libvirt_fds(tvb, start + payload_length, nfds);
++        dissect_libvirt_fds(tvb, pinfo, start + payload_length, nfds);
+ }
+ 
+ static gboolean
+-dissect_xdr_stream_hole(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf)
++dissect_xdr_stream_hole(tvbuff_t *tvb,
++                        packet_info *pinfo,
++                        proto_tree *tree,
++                        XDR *xdrs,
++                        int hf)
+ {
+     goffset start;
+     proto_item *ti;
+@@ -411,10 +468,10 @@ dissect_xdr_stream_hole(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf)
+     tree = proto_item_add_subtree(ti, ett_libvirt_stream_hole);
+ 
+     hf = hf_libvirt_stream_hole_length;
+-    if (!dissect_xdr_hyper(tvb, tree, xdrs, hf)) return FALSE;
++    if (!dissect_xdr_hyper(tvb, pinfo, tree, xdrs, hf)) return FALSE;
+ 
+     hf = hf_libvirt_stream_hole_flags;
+-    if (!dissect_xdr_u_int(tvb, tree, xdrs, hf)) return FALSE;
++    if (!dissect_xdr_u_int(tvb, pinfo, tree, xdrs, hf)) return FALSE;
+ 
+     proto_item_set_len(ti, xdr_getpos(xdrs) - start);
+     return TRUE;
+@@ -424,6 +481,7 @@ dissect_xdr_stream_hole(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf)
+ 
+ static void
+ dissect_libvirt_payload(tvbuff_t *tvb,
++                        packet_info *pinfo,
+                         proto_tree *tree,
+                         uint32_t prog,
+                         int32_t proc,
+@@ -447,13 +505,13 @@ dissect_libvirt_payload(tvbuff_t *tvb,
+         xd = find_payload_dissector(proc, type, pds, *len);
+         if (xd == NULL)
+             goto unknown;
+-        dissect_libvirt_payload_xdr_data(tvb, tree, payload_length, status, xd);
++        dissect_libvirt_payload_xdr_data(tvb, pinfo, tree, payload_length, status, xd);
+     } else if (status == VIR_NET_ERROR) {
+-        dissect_libvirt_payload_xdr_data(tvb, tree, payload_length, status, dissect_xdr_remote_error);
++        dissect_libvirt_payload_xdr_data(tvb, pinfo, tree, payload_length, status, dissect_xdr_remote_error);
+     } else if (type == VIR_NET_STREAM) { /* implicitly, status == VIR_NET_CONTINUE */
+-        dissect_libvirt_stream(tvb, tree, payload_length);
++        dissect_libvirt_stream(tvb, pinfo, tree, payload_length);
+     } else if (type == VIR_NET_STREAM_HOLE) {
+-        dissect_libvirt_payload_xdr_data(tvb, tree, payload_length, status, dissect_xdr_stream_hole);
++        dissect_libvirt_payload_xdr_data(tvb, pinfo, tree, payload_length, status, dissect_xdr_stream_hole);
+     } else {
+         goto unknown;
+     }
+@@ -489,21 +547,21 @@ dissect_libvirt_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+     serial = tvb_get_ntohl(tvb, offset); offset += 4;
+     status = tvb_get_ntohil(tvb, offset); offset += 4;
+ 
+-    prog_str = vir_val_to_str(prog, program_strings, "%x");
++    prog_str = vir_val_to_str(pinfo, prog, program_strings, "%x");
+     col_add_fstr(pinfo->cinfo, COL_INFO, "Prog=%s", prog_str);
+-    vir_wmem_free(prog_str);
++    vir_wmem_free(pinfo, prog_str);
+ 
+     vs = get_program_data(prog, VIR_PROGRAM_PROCSTRINGS);
+-    proc_str = vir_val_to_str(proc, vs, "%d");
++    proc_str = vir_val_to_str(pinfo, proc, vs, "%d");
+     col_append_fstr(pinfo->cinfo, COL_INFO, " Proc=%s", proc_str);
+-    vir_wmem_free(proc_str);
++    vir_wmem_free(pinfo, proc_str);
+ 
+-    type_str = vir_val_to_str(type, type_strings, "%d");
+-    status_str = vir_val_to_str(status, status_strings, "%d");
++    type_str = vir_val_to_str(pinfo, type, type_strings, "%d");
++    status_str = vir_val_to_str(pinfo, status, status_strings, "%d");
+     col_append_fstr(pinfo->cinfo, COL_INFO, " Type=%s Serial=%u Status=%s",
+                     type_str, serial, status_str);
+-    vir_wmem_free(status_str);
+-    vir_wmem_free(type_str);
++    vir_wmem_free(pinfo, status_str);
++    vir_wmem_free(pinfo, type_str);
+ 
+     if (tree) {
+         gint *hf_proc;
+@@ -532,21 +590,26 @@ dissect_libvirt_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
+         proto_tree_add_item(libvirt_tree, hf_libvirt_status,  tvb, offset, 4, ENC_NA); offset += 4;
+ 
+         /* Dissect payload remaining */
+-        dissect_libvirt_payload(tvb, libvirt_tree, prog, proc, type, status);
++        dissect_libvirt_payload(tvb, pinfo, libvirt_tree, prog, proc, type, status);
+     }
+ 
+     return 0;
+ }
+ 
+ static guint
+-get_message_len(packet_info *pinfo G_GNUC_UNUSED, tvbuff_t *tvb, int offset, void *data G_GNUC_UNUSED)
++get_message_len(packet_info *pinfo G_GNUC_UNUSED,
++                tvbuff_t *tvb,
++                int offset,
++                void *data G_GNUC_UNUSED)
+ {
+     return tvb_get_ntohl(tvb, offset);
+ }
+ 
+ static int
+-dissect_libvirt(tvbuff_t *tvb, packet_info *pinfo,
+-                proto_tree *tree, void *data G_GNUC_UNUSED)
++dissect_libvirt(tvbuff_t *tvb,
++                packet_info *pinfo,
++                proto_tree *tree,
++                void *data G_GNUC_UNUSED)
+ {
+     /* Another magic const - 4; simply, how much bytes
+      * is needed to tell the length of libvirt packet. */
+diff --git a/tools/wireshark/util/genxdrstub.pl b/tools/wireshark/util/genxdrstub.pl
+index 01b663a88c..f69695c091 100755
+--- a/tools/wireshark/util/genxdrstub.pl
++++ b/tools/wireshark/util/genxdrstub.pl
+@@ -250,7 +250,7 @@ sub xdr_type {
+ sub render_caller {
+     my ($self, $hfid) = @_;
+     my $name = $c->rinc( 'dissect_xdr_'.($self->idstrip || lc($self->xdr_type)) );
+-    "$name(tvb, tree, xdrs, hf)";
++    "$name(tvb, pinfo, tree, xdrs, hf)";
+ }
+ 
+ sub ft_type {
+@@ -345,7 +345,7 @@ BEGIN{::register_profile(
+ sub render_caller {
+     my ($self) = @_;
+     my ($klass) = ref($self) =~ /([^:]+)$/;
+-    sprintf '%s(tvb, tree, xdrs, hf, %s)',
++    sprintf '%s(tvb, pinfo, tree, xdrs, hf, %s)',
+         $c->rinc('dissect_xdr_'.lc($klass)),
+         $c->rinc('dissect_xdr_'.$self->reftype->idstrip);
+ }
+@@ -359,7 +359,7 @@ BEGIN{::register_profile(
+ sub render_caller {
+     my ($self, $hfid) = @_;
+     my ($klass) = ref($self) =~ /([^:]+)$/;
+-    sprintf '%s(tvb, tree, xdrs, hf, %s)',
++    sprintf '%s(tvb, pinfo, tree, xdrs, hf, %s)',
+         $c->rinc('dissect_xdr_'.lc($klass)), $self->length || '~0';
+ }
+ 
+@@ -447,7 +447,7 @@ BEGIN{::register_profile(
+ sub render_caller {
+     my ($self, $hfid) = @_;
+     my ($pname) = reverse split /__/, $hfid;
+-    sprintf 'dissect_xdr_array(tvb, tree, xdrs, hf, %s, %s, "%s", %s, %s)',
++    sprintf 'dissect_xdr_array(tvb, pinfo, tree, xdrs, hf, %s, %s, "%s", %s, %s)',
+         $c->rinc('ett_'.$self->idstrip),
+         $c->rinc("hf_$hfid\__$pname"),
+         $self->reftype->idstrip,
+@@ -476,7 +476,7 @@ BEGIN{::register_profile(
+ sub render_caller {
+     my ($self, $hfid) = @_;
+     my ($pname) = reverse split /__/, $hfid;
+-    sprintf 'dissect_xdr_vector(tvb, tree, xdrs, hf, %s, %s, "%s", %s, %s)',
++    sprintf 'dissect_xdr_vector(tvb, pinfo, tree, xdrs, hf, %s, %s, "%s", %s, %s)',
+         $c->rinc('ett_'.$self->idstrip),
+         $c->rinc("hf_$hfid\__$pname"),
+         $self->reftype->idstrip,
+@@ -857,7 +857,7 @@ __END__<<DUMMY # Dummy heredoc to disable perl syntax highlighting
+ my ($self, $ident) = @_;
+ return if $self->is_primitive;
+ %>
+-static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf)
++static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, packet_info *pinfo G_GNUC_UNUSED, proto_tree *tree, XDR *xdrs, int hf)
+ {
+     return <%= $self->dealias->render_caller($self->ident eq $ident ? undef : $ident) %>;
+ }
+@@ -865,7 +865,7 @@ static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, proto_tree *tree, XDR *
+ <% my ($self, $ident) = @_;
+    my $hfvar = $c->rinc('hf_'.$self->idstrip);
+ %>
+-static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf)
++static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, packet_info *pinfo G_GNUC_UNUSED, proto_tree *tree, XDR *xdrs, int hf)
+ {
+     goffset start;
+     proto_item *ti;
+@@ -890,7 +890,7 @@ static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, proto_tree *tree, XDR *
+ }
+ @@ Sym::Type::Enum#render_dissector
+ <% my ($self, $ident) = @_; %>
+-static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf)
++static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, packet_info *pinfo G_GNUC_UNUSED, proto_tree *tree, XDR *xdrs, int hf)
+ {
+     goffset start;
+     enum { DUMMY } es;
+@@ -914,7 +914,7 @@ static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, proto_tree *tree, XDR *
+ my ($self, $ident) = @_;
+ my $decl_type = $self->decl->type->idstrip;
+ %>
+-static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, proto_tree *tree, XDR *xdrs, int hf)
++static gboolean dissect_xdr_<%= $ident %>(tvbuff_t *tvb, packet_info *pinfo G_GNUC_UNUSED, proto_tree *tree, XDR *xdrs, int hf)
+ {
+     gboolean rc = TRUE;
+     goffset start;
+-- 
+2.51.0
+

0009-qemu-Disallow-pivot-of-shared-disks-to-unsupported-s.patch

@@ -1,34 +0,0 @@
-From: Peter Krempa <pkrempa@redhat.com>
-Date: Wed, 15 Nov 2017 14:33:11 +0100
-Subject: [PATCH] qemu: Disallow pivot of shared disks to unsupported storage
-
-Pivoting to a unsupported storage type might break the assumption that
-shared disks will not corrupt metadata.
-
-Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1511480
-(cherry picked from commit 2b41c86294786c07f53afa633fe3dce703debc3c)
----
- src/qemu/qemu_driver.c | 10 ++++++++++
- 1 file changed, 10 insertions(+)
-
-diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
-index 91119a494..208ccc9bc 100644
---- a/src/qemu/qemu_driver.c
-+++ b/src/qemu/qemu_driver.c
-@@ -16325,6 +16325,16 @@ qemuDomainBlockPivot(virQEMUDriverPtr driver,
-         goto cleanup;
-     }
- 
-+    /* When pivoting to a shareable disk we need to make sure that the disk can
-+     * be safely shared, since block copy might have changed the format. */
-+    if (disk->src->shared && !disk->src->readonly &&
-+        !qemuBlockStorageSourceSupportsConcurrentAccess(disk->mirror)) {
-+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
-+                       _("can't pivot a shared disk to a storage volume not "
-+                         "supporting sharing"));
-+        goto cleanup;
-+    }
-+
-     /* For active commit, the mirror is part of the already labeled
-      * chain.  For blockcopy, we previously labeled only the top-level
-      * image; but if the user is reusing an external image that

0010-qemu-caps-Add-capability-for-share-rw-disk-option.patch

@@ -1,126 +0,0 @@
-From: Peter Krempa <pkrempa@redhat.com>
-Date: Wed, 15 Nov 2017 15:02:58 +0100
-Subject: [PATCH] qemu: caps: Add capability for 'share-rw' disk option
-
-'share-rw' for the disk device configures qemu to allow concurrent
-access to the backing storage.
-
-The capability is checked in various supported disk frontend buses since
-it does not make sense to partially backport it.
-
-(cherry picked from commit 860a3c4bea1d24773d8a495f213d5de3ac48a462)
----
- src/qemu/qemu_capabilities.c                      | 14 ++++++++++++++
- src/qemu/qemu_capabilities.h                      | 10 ++++++++++
- tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml |  1 +
- tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml   |  1 +
- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml  |  1 +
- 5 files changed, 27 insertions(+)
-
-diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
-index e7ea6f47c..2de84715e 100644
---- a/src/qemu/qemu_capabilities.c
-+++ b/src/qemu/qemu_capabilities.c
-@@ -439,6 +439,16 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
-               "virtio-net.tx_queue_size",
-               "chardev-reconnect",
-               "virtio-gpu.max_outputs",
-+
-+              /* 270 */
-+              "vxhs",
-+              "virtio-blk.num-queues",
-+              "machine.pseries.resize-hpt",
-+              "vmcoreinfo",
-+              "spapr-vty",
-+
-+              /* 275 */
-+              "disk-share-rw",
-     );
- 
- 
-@@ -1702,6 +1712,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsVirtioBlk[] = {
-     { "event_idx", QEMU_CAPS_VIRTIO_BLK_EVENT_IDX },
-     { "scsi", QEMU_CAPS_VIRTIO_BLK_SCSI },
-     { "logical_block_size", QEMU_CAPS_BLOCKIO },
-+    { "share-rw", QEMU_CAPS_DISK_SHARE_RW },
- };
- 
- static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsVirtioNet[] = {
-@@ -1732,10 +1743,12 @@ static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsVfioPCI[] = {
- static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsSCSIDisk[] = {
-     { "channel", QEMU_CAPS_SCSI_DISK_CHANNEL },
-     { "wwn", QEMU_CAPS_SCSI_DISK_WWN },
-+    { "share-rw", QEMU_CAPS_DISK_SHARE_RW },
- };
- 
- static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsIDEDrive[] = {
-     { "wwn", QEMU_CAPS_IDE_DRIVE_WWN },
-+    { "share-rw", QEMU_CAPS_DISK_SHARE_RW },
- };
- 
- static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsPiix4PM[] = {
-@@ -1766,6 +1779,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsQ35PCIHost[] = {
- 
- static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsUSBStorage[] = {
-     { "removable", QEMU_CAPS_USB_STORAGE_REMOVABLE },
-+    { "share-rw", QEMU_CAPS_DISK_SHARE_RW },
- };
- 
- static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsKVMPit[] = {
-diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
-index f32687d4a..9c92d6b46 100644
---- a/src/qemu/qemu_capabilities.h
-+++ b/src/qemu/qemu_capabilities.h
-@@ -426,6 +426,16 @@ typedef enum {
-     QEMU_CAPS_CHARDEV_RECONNECT, /* -chardev reconnect */
-     QEMU_CAPS_VIRTIO_GPU_MAX_OUTPUTS, /* -device virtio-(vga|gpu-*),max-outputs= */
- 
-+    /* 270 */
-+    QEMU_CAPS_VXHS, /* -drive file.driver=vxhs via query-qmp-schema */
-+    QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES, /* virtio-blk-*.num-queues */
-+    QEMU_CAPS_MACHINE_PSERIES_RESIZE_HPT, /* -machine pseries,resize-hpt */
-+    QEMU_CAPS_DEVICE_VMCOREINFO, /* -device vmcoreinfo */
-+    QEMU_CAPS_DEVICE_SPAPR_VTY, /* -device spapr-vty */
-+
-+    /* 275 */
-+    QEMU_CAPS_DISK_SHARE_RW, /* share-rw=on for concurrent disk access */
-+
-     QEMU_CAPS_LAST /* this must always be the last item */
- } virQEMUCapsFlags;
- 
-diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml
-index a373a6db6..9551907c6 100644
---- a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml
-@@ -172,6 +172,7 @@
-   <flag name='vnc-multi-servers'/>
-   <flag name='chardev-reconnect'/>
-   <flag name='virtio-gpu.max_outputs'/>
-+  <flag name='disk-share-rw'/>
-   <version>2009000</version>
-   <kvmVersion>0</kvmVersion>
-   <package> (v2.9.0)</package>
-diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
-index e80782cfb..0a6fbd077 100644
---- a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
-@@ -137,6 +137,7 @@
-   <flag name='vnc-multi-servers'/>
-   <flag name='chardev-reconnect'/>
-   <flag name='virtio-gpu.max_outputs'/>
-+  <flag name='disk-share-rw'/>
-   <version>2009000</version>
-   <kvmVersion>0</kvmVersion>
-   <package></package>
-diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
-index 3641d0332..1294ebdb3 100644
---- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
-@@ -220,6 +220,7 @@
-   <flag name='vnc-multi-servers'/>
-   <flag name='chardev-reconnect'/>
-   <flag name='virtio-gpu.max_outputs'/>
-+  <flag name='disk-share-rw'/>
-   <version>2009000</version>
-   <kvmVersion>0</kvmVersion>
-   <package> (v2.9.0)</package>

0011-qemu-command-Mark-shared-disks-as-such-in-qemu.patch

@@ -1,133 +0,0 @@
-From: Peter Krempa <pkrempa@redhat.com>
-Date: Wed, 15 Nov 2017 15:21:14 +0100
-Subject: [PATCH] qemu: command: Mark <shared/> disks as such in qemu
-
-Qemu has now an internal mechanism for locking images to fix specific
-cases of disk corruption. This requires libvirt to mark the image as
-shared so that qemu lifts certain restrictions.
-
-Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1378242
-(cherry picked from commit 28907b0043fbf71085a798372ab9c816ba043b93)
----
- src/qemu/qemu_command.c                            |  4 +++
- .../qemuxml2argv-disk-drive-shared-locking.args    | 32 +++++++++++++++++
- .../qemuxml2argv-disk-drive-shared-locking.xml     | 42 ++++++++++++++++++++++
- tests/qemuxml2argvtest.c                           |  2 ++
- 4 files changed, 80 insertions(+)
- create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-locking.args
- create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-locking.xml
-
-diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
-index ae78cd17e..883525752 100644
---- a/src/qemu/qemu_command.c
-+++ b/src/qemu/qemu_command.c
-@@ -2075,6 +2075,10 @@ qemuBuildDriveDevStr(const virDomainDef *def,
-         goto error;
-     }
- 
-+    if (disk->src->shared &&
-+        virQEMUCapsGet(qemuCaps, QEMU_CAPS_DISK_SHARE_RW))
-+        virBufferAddLit(&opt, ",share-rw=on");
-+
-     if (!(drivealias = qemuAliasFromDisk(disk)))
-         goto error;
-     virBufferAsprintf(&opt, ",drive=%s,id=%s", drivealias, disk->info.alias);
-diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-locking.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-locking.args
-new file mode 100644
-index 000000000..cdf17f26d
---- /dev/null
-+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-locking.args
-@@ -0,0 +1,32 @@
-+LC_ALL=C \
-+PATH=/bin \
-+HOME=/home/test \
-+USER=test \
-+LOGNAME=test \
-+QEMU_AUDIO_DRV=none \
-+/usr/bin/qemu-system-i686 \
-+-name QEMUGuest1 \
-+-S \
-+-M pc \
-+-m 214 \
-+-smp 1,sockets=1,cores=1,threads=1 \
-+-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
-+-nographic \
-+-nodefaults \
-+-chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\
-+server,nowait \
-+-mon chardev=charmonitor,id=monitor,mode=readline \
-+-no-acpi \
-+-boot c \
-+-device virtio-scsi-pci,id=scsi0,bus=pci.0,addr=0x3 \
-+-usb \
-+-drive file=/dev/ide,format=raw,if=none,id=drive-ide0-0-0,cache=none \
-+-device ide-drive,bus=ide.0,unit=0,share-rw=on,drive=drive-ide0-0-0,\
-+id=ide0-0-0 \
-+-drive file=/dev/scsi,format=raw,if=none,id=drive-scsi0-0-0-0,cache=none \
-+-device scsi-disk,bus=scsi0.0,channel=0,scsi-id=0,lun=0,share-rw=on,\
-+drive=drive-scsi0-0-0-0,id=scsi0-0-0-0 \
-+-drive file=/dev/virtio,format=raw,if=none,id=drive-virtio-disk0,cache=none \
-+-device virtio-blk-pci,bus=pci.0,addr=0x4,share-rw=on,drive=drive-virtio-disk0,\
-+id=virtio-disk0 \
-+-device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5
-diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-locking.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-locking.xml
-new file mode 100644
-index 000000000..dd48857a3
---- /dev/null
-+++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared-locking.xml
-@@ -0,0 +1,42 @@
-+<domain type='qemu'>
-+  <name>QEMUGuest1</name>
-+  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
-+  <memory unit='KiB'>219136</memory>
-+  <currentMemory unit='KiB'>219136</currentMemory>
-+  <vcpu placement='static'>1</vcpu>
-+  <os>
-+    <type arch='i686' machine='pc'>hvm</type>
-+    <boot dev='hd'/>
-+  </os>
-+  <clock offset='utc'/>
-+  <on_poweroff>destroy</on_poweroff>
-+  <on_reboot>restart</on_reboot>
-+  <on_crash>destroy</on_crash>
-+  <devices>
-+    <emulator>/usr/bin/qemu-system-i686</emulator>
-+    <disk type='block' device='disk'>
-+      <driver name='qemu' type='raw'/>
-+      <source dev='/dev/ide'/>
-+      <target dev='hda' bus='ide'/>
-+      <shareable/>
-+      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
-+    </disk>
-+    <disk type='block' device='disk'>
-+      <driver name='qemu' type='raw'/>
-+      <source dev='/dev/scsi'/>
-+      <target dev='sda' bus='scsi'/>
-+      <shareable/>
-+      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
-+    </disk>
-+    <disk type='block' device='disk'>
-+      <driver name='qemu' type='raw'/>
-+      <source dev='/dev/virtio'/>
-+      <target dev='vda' bus='virtio'/>
-+      <shareable/>
-+    </disk>
-+    <controller type='usb' index='0'/>
-+    <controller type='ide' index='0'/>
-+    <controller type='scsi' index='0' model='virtio-scsi'/>
-+    <memballoon model='virtio'/>
-+  </devices>
-+</domain>
-diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
-index 93f892229..9585fdb70 100644
---- a/tests/qemuxml2argvtest.c
-+++ b/tests/qemuxml2argvtest.c
-@@ -896,6 +896,8 @@ mymain(void)
-     DO_TEST("disk-drive-shared",
-             QEMU_CAPS_DRIVE_SERIAL);
-     DO_TEST_PARSE_ERROR("disk-drive-shared-qcow", NONE);
-+    DO_TEST("disk-drive-shared-locking",
-+            QEMU_CAPS_VIRTIO_SCSI, QEMU_CAPS_DISK_SHARE_RW);
-     DO_TEST("disk-drive-error-policy-stop",
-             QEMU_CAPS_MONITOR_JSON);
-     DO_TEST("disk-drive-error-policy-enospace",

0101-util-probe-Add-quiet-versions-of-the-PROBE-macro.patch

@@ -1,36 +0,0 @@
-From: Peter Krempa <pkrempa@redhat.com>
-Date: Wed, 20 Dec 2017 12:58:36 +0100
-Subject: [PATCH] util: probe: Add quiet versions of the "PROBE" macro
-
-PROBE macro adds a logging entry, when used in places seeing a lot of
-traffic this can cause a significant slowdown.
-
-(cherry picked from commit f06e488d5484031a76e7ed231c8fef8fa1181d2c)
----
- src/util/virprobe.h | 8 ++++++++
- 1 file changed, 8 insertions(+)
-
-diff --git a/src/util/virprobe.h b/src/util/virprobe.h
-index 7565954af..bd8c32964 100644
---- a/src/util/virprobe.h
-+++ b/src/util/virprobe.h
-@@ -90,11 +90,19 @@
-         PROBE_EXPAND(LIBVIRT_ ## NAME,                       \
-                      VIR_ADD_CASTS(__VA_ARGS__));            \
-     }
-+
-+#  define PROBE_QUIET(NAME, FMT, ...) \
-+    if (LIBVIRT_ ## NAME ## _ENABLED()) { \
-+        PROBE_EXPAND(LIBVIRT_ ## NAME, \
-+                     VIR_ADD_CASTS(__VA_ARGS__)); \
-+    }
- # else
- #  define PROBE(NAME, FMT, ...)                              \
-     VIR_INFO_INT(&virLogSelf,                                \
-                  __FILE__, __LINE__, __func__,               \
-                  #NAME ": " FMT, __VA_ARGS__);
-+
-+#  define PROBE_QUIET(NAME, FMT, ...)
- # endif
- 
- #endif /* __VIR_PROBE_H__ */

0102-qemu-monitor-Decrease-logging-verbosity.patch

@@ -1,49 +0,0 @@
-From: Peter Krempa <pkrempa@redhat.com>
-Date: Wed, 20 Dec 2017 13:09:07 +0100
-Subject: [PATCH] qemu: monitor: Decrease logging verbosity
-
-The PROBE macro used in qemuMonitorIOProcess and the VIR_DEBUG message
-in qemuMonitorJSONIOProcess create a lot of logging churn when debug
-logging is enabled during monitor communication.
-
-The messages logged from the PROBE macro are rather useless since they
-are reporting the partial state of receiving the reply from qemu. The
-actual full reply is still logged in qemuMonitorJSONIOProcessLine once
-the full message is received.
-
-(cherry picked from commit f10bb3347b43d900ff361cda5fe1996782284991)
----
- src/qemu/qemu_monitor.c      | 4 ++--
- src/qemu/qemu_monitor_json.c | 3 +++
- 2 files changed, 5 insertions(+), 2 deletions(-)
-
-diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
-index 19082d8bf..3def28852 100644
---- a/src/qemu/qemu_monitor.c
-+++ b/src/qemu/qemu_monitor.c
-@@ -434,8 +434,8 @@ qemuMonitorIOProcess(qemuMonitorPtr mon)
- # endif
- #endif
- 
--    PROBE(QEMU_MONITOR_IO_PROCESS,
--          "mon=%p buf=%s len=%zu", mon, mon->buffer, mon->bufferOffset);
-+    PROBE_QUIET(QEMU_MONITOR_IO_PROCESS, "mon=%p buf=%s len=%zu",
-+                mon, mon->buffer, mon->bufferOffset);
- 
-     if (mon->json)
-         len = qemuMonitorJSONIOProcess(mon,
-diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
-index df5fb7c8f..461aae089 100644
---- a/src/qemu/qemu_monitor_json.c
-+++ b/src/qemu/qemu_monitor_json.c
-@@ -259,7 +259,10 @@ int qemuMonitorJSONIOProcess(qemuMonitorPtr mon,
-         }
-     }
- 
-+#if DEBUG_IO
-     VIR_DEBUG("Total used %d bytes out of %zd available in buffer", used, len);
-+#endif
-+
-     return used;
- }
- 

0103-virlog-determine-the-hostname-on-startup-CVE-2018-67.patch

@@ -1,63 +0,0 @@
-From: Lubomir Rintel <lkundrak@v3.sk>
-Date: Sat, 27 Jan 2018 23:43:58 +0100
-Subject: [PATCH] virlog: determine the hostname on startup CVE-2018-6764
-
-At later point it might not be possible or even safe to use getaddrinfo(). It
-can in turn result in a load of NSS module.
-
-Notably, on a LXC container startup we may find ourselves with the guest
-filesystem already having replaced the host one. Loading a NSS module
-from the guest tree would allow a malicous guest to escape the
-confinement of its container environment because libvirt will not yet
-have locked it down.
-
-(cherry picked from commit 759b4d1b0fe5f4d84d98b99153dfa7ac289dd167)
----
- src/util/virlog.c | 14 +++++++++-----
- 1 file changed, 9 insertions(+), 5 deletions(-)
-
-diff --git a/src/util/virlog.c b/src/util/virlog.c
-index d45a451a7..05e0e199e 100644
---- a/src/util/virlog.c
-+++ b/src/util/virlog.c
-@@ -64,6 +64,7 @@
- VIR_LOG_INIT("util.log");
- 
- static regex_t *virLogRegex;
-+static char *virLogHostname;
- 
- 
- #define VIR_LOG_DATE_REGEX "[0-9]{4}-[0-9]{2}-[0-9]{2}"
-@@ -271,6 +272,12 @@ virLogOnceInit(void)
-             VIR_FREE(virLogRegex);
-     }
- 
-+    /* We get and remember the hostname early, because at later time
-+     * it might not be possible to load NSS modules via getaddrinfo()
-+     * (e.g. at container startup the host filesystem will not be
-+     * accessible anymore. */
-+    virLogHostname = virGetHostnameQuiet();
-+
-     virLogUnlock();
-     return 0;
- }
-@@ -466,17 +473,14 @@ static int
- virLogHostnameString(char **rawmsg,
-                      char **msg)
- {
--    char *hostname = virGetHostnameQuiet();
-     char *hoststr;
- 
--    if (!hostname)
-+    if (!virLogHostname)
-         return -1;
- 
--    if (virAsprintfQuiet(&hoststr, "hostname: %s", hostname) < 0) {
--        VIR_FREE(hostname);
-+    if (virAsprintfQuiet(&hoststr, "hostname: %s", virLogHostname) < 0) {
-         return -1;
-     }
--    VIR_FREE(hostname);
- 
-     if (virLogFormatString(msg, 0, NULL, VIR_LOG_INFO, hoststr) < 0) {
-         VIR_FREE(hoststr);

0104-util-Fix-syntax-check.patch

@@ -1,27 +0,0 @@
-From: Andrea Bolognani <abologna@redhat.com>
-Date: Wed, 7 Feb 2018 14:39:18 +0100
-Subject: [PATCH] util: Fix syntax-check
-
-Broken by 759b4d1b0fe5f4d84d98b99153dfa7ac289dd167.
-
-Signed-off-by: Andrea Bolognani <abologna@redhat.com>
-(cherry picked from commit 6ce3acc129bfdbe7fd02bcb8bbe8af6d13903684)
----
- src/util/virlog.c | 3 +--
- 1 file changed, 1 insertion(+), 2 deletions(-)
-
-diff --git a/src/util/virlog.c b/src/util/virlog.c
-index 05e0e199e..056b53cda 100644
---- a/src/util/virlog.c
-+++ b/src/util/virlog.c
-@@ -478,9 +478,8 @@ virLogHostnameString(char **rawmsg,
-     if (!virLogHostname)
-         return -1;
- 
--    if (virAsprintfQuiet(&hoststr, "hostname: %s", virLogHostname) < 0) {
-+    if (virAsprintfQuiet(&hoststr, "hostname: %s", virLogHostname) < 0)
-         return -1;
--    }
- 
-     if (virLogFormatString(msg, 0, NULL, VIR_LOG_INFO, hoststr) < 0) {
-         VIR_FREE(hoststr);

0105-log-fix-deadlock-obtaining-hostname-related-CVE-2018.patch

@@ -1,121 +0,0 @@
-From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
-Date: Mon, 12 Feb 2018 10:03:08 +0000
-Subject: [PATCH] log: fix deadlock obtaining hostname (related CVE-2018-6764)
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-The fix for CVE-2018-6764 introduced a potential deadlock scenario
-that gets triggered by the NSS module when virGetHostname() calls
-getaddrinfo to resolve the hostname:
-
- #0  0x00007f6e714b57e7 in futex_wait
- #1  futex_wait_simple
- #2  __pthread_once_slow
- #3  0x00007f6e71d16e7d in virOnce
- #4  0x00007f6e71d0997c in virLogInitialize
- #5  0x00007f6e71d0a09a in virLogVMessage
- #6  0x00007f6e71d09ffd in virLogMessage
- #7  0x00007f6e71d0db22 in virObjectNew
- #8  0x00007f6e71d0dbf1 in virObjectLockableNew
- #9  0x00007f6e71d0d3e5 in virMacMapNew
- #10 0x00007f6e71cdc50a in findLease
- #11 0x00007f6e71cdcc56 in _nss_libvirt_gethostbyname4_r
- #12 0x00007f6e724631fc in gaih_inet
- #13 0x00007f6e72464697 in __GI_getaddrinfo
- #14 0x00007f6e71d19e81 in virGetHostnameImpl
- #15 0x00007f6e71d1a057 in virGetHostnameQuiet
- #16 0x00007f6e71d09936 in virLogOnceInit
- #17 0x00007f6e71d09952 in virLogOnce
- #18 0x00007f6e714b5829 in __pthread_once_slow
- #19 0x00007f6e71d16e7d in virOnce
- #20 0x00007f6e71d0997c in virLogInitialize
- #21 0x00007f6e71d0a09a in virLogVMessage
- #22 0x00007f6e71d09ffd in virLogMessage
- #23 0x00007f6e71d0db22 in virObjectNew
- #24 0x00007f6e71d0dbf1 in virObjectLockableNew
- #25 0x00007f6e71d0d3e5 in virMacMapNew
- #26 0x00007f6e71cdc50a in findLease
- #27 0x00007f6e71cdc839 in _nss_libvirt_gethostbyname3_r
- #28 0x00007f6e71cdc724 in _nss_libvirt_gethostbyname2_r
- #29 0x00007f6e7248f72f in __gethostbyname2_r
- #30 0x00007f6e7248f494 in gethostbyname2
- #31 0x000056348c30c36d in hosts_keys
- #32 0x000056348c30b7d2 in main
-
-Fortunately the extra stuff virGetHostname does is totally irrelevant to
-the needs of the logging code, so we can just inline a call to the
-native hostname() syscall directly.
-
-Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
-(cherry picked from commit c2dc6698c88fb591639e542c8ecb0076c54f3dfb)
----
- cfg.mk            |  2 +-
- src/util/virlog.c | 20 ++++++++++++++------
- 2 files changed, 15 insertions(+), 7 deletions(-)
-
-diff --git a/cfg.mk b/cfg.mk
-index 56cb14bd9..a4131592c 100644
---- a/cfg.mk
-+++ b/cfg.mk
-@@ -1158,7 +1158,7 @@ _src2=src/(util/vircommand|libvirt|lxc/lxc_controller|locking/lock_daemon|loggin
- exclude_file_name_regexp--sc_prohibit_fork_wrappers = \
-   (^($(_src2)|tests/testutils|daemon/libvirtd)\.c$$)
- 
--exclude_file_name_regexp--sc_prohibit_gethostname = ^src/util/virutil\.c$$
-+exclude_file_name_regexp--sc_prohibit_gethostname = ^src/util/vir(util|log)\.c$$
- 
- exclude_file_name_regexp--sc_prohibit_internal_functions = \
-   ^src/(util/(viralloc|virutil|virfile)\.[hc]|esx/esx_vi\.c)$$
-diff --git a/src/util/virlog.c b/src/util/virlog.c
-index 056b53cda..f76fc2caf 100644
---- a/src/util/virlog.c
-+++ b/src/util/virlog.c
-@@ -64,7 +64,7 @@
- VIR_LOG_INIT("util.log");
- 
- static regex_t *virLogRegex;
--static char *virLogHostname;
-+static char virLogHostname[HOST_NAME_MAX+1];
- 
- 
- #define VIR_LOG_DATE_REGEX "[0-9]{4}-[0-9]{2}-[0-9]{2}"
-@@ -261,6 +261,8 @@ virLogPriorityString(virLogPriority lvl)
- static int
- virLogOnceInit(void)
- {
-+    int r;
-+
-     if (virMutexInit(&virLogMutex) < 0)
-         return -1;
- 
-@@ -275,8 +277,17 @@ virLogOnceInit(void)
-     /* We get and remember the hostname early, because at later time
-      * it might not be possible to load NSS modules via getaddrinfo()
-      * (e.g. at container startup the host filesystem will not be
--     * accessible anymore. */
--    virLogHostname = virGetHostnameQuiet();
-+     * accessible anymore.
-+     * Must not use virGetHostname though as that causes re-entrancy
-+     * problems if it triggers logging codepaths
-+     */
-+    r = gethostname(virLogHostname, sizeof(virLogHostname));
-+    if (r == -1) {
-+        ignore_value(virStrcpy(virLogHostname,
-+                               "(unknown)", sizeof(virLogHostname)));
-+    } else {
-+        NUL_TERMINATE(virLogHostname);
-+    }
- 
-     virLogUnlock();
-     return 0;
-@@ -475,9 +486,6 @@ virLogHostnameString(char **rawmsg,
- {
-     char *hoststr;
- 
--    if (!virLogHostname)
--        return -1;
--
-     if (virAsprintfQuiet(&hoststr, "hostname: %s", virLogHostname) < 0)
-         return -1;
- 

0106-qemuDomainAttachDeviceMknodHelper-Remove-symlink-bef.patch

@@ -1,59 +0,0 @@
-From: Michal Privoznik <mprivozn@redhat.com>
-Date: Thu, 4 Jan 2018 11:11:53 +0100
-Subject: [PATCH] qemuDomainAttachDeviceMknodHelper: Remove symlink before
- creating it
-
-https://bugzilla.redhat.com/show_bug.cgi?id=1528502
-
-So imagine you have /dev/blah symlink which points to /dev/sda.
-You attach /dev/blah as disk to your domain. Libvirt correctly
-creates the /dev/blah -> /dev/sda symlink in the qemu namespace.
-However, then you detach the disk, change the symlink so that it
-points to /dev/sdb and tries to attach the disk again. This time,
-however, the attach fails (well, qemu attaches wrong disk)
-because the code assumes that symlinks don't change. Well they
-do.
-
-This is inspired by test fix written by Eduardo Habkost.
-
-Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
-Reviewed-by: Andrea Bolognani <abologna@redhat.com>
-(cherry picked from commit db98e7f67ea0d7699410f514f01947cef5128a6c)
----
- src/qemu/qemu_domain.c | 22 ++++++++++++++++------
- 1 file changed, 16 insertions(+), 6 deletions(-)
-
-diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
-index 42d17c1b0..e0f4aaafa 100644
---- a/src/qemu/qemu_domain.c
-+++ b/src/qemu/qemu_domain.c
-@@ -8864,13 +8864,23 @@ qemuDomainAttachDeviceMknodHelper(pid_t pid ATTRIBUTE_UNUSED,
- 
-     if (isLink) {
-         VIR_DEBUG("Creating symlink %s -> %s", data->file, data->target);
-+
-+        /* First, unlink the symlink target. Symlinks change and
-+         * therefore we have no guarantees that pre-existing
-+         * symlink is still valid. */
-+        if (unlink(data->file) < 0 &&
-+            errno != ENOENT) {
-+            virReportSystemError(errno,
-+                                 _("Unable to remove symlink %s"),
-+                                 data->file);
-+            goto cleanup;
-+        }
-+
-         if (symlink(data->target, data->file) < 0) {
--            if (errno != EEXIST) {
--                virReportSystemError(errno,
--                                     _("Unable to create symlink %s"),
--                                     data->target);
--                goto cleanup;
--            }
-+            virReportSystemError(errno,
-+                                 _("Unable to create symlink %s (pointing to %s)"),
-+                                 data->file, data->target);
-+            goto cleanup;
-         } else {
-             delDevice = true;
-         }

0107-nwfilter-increase-pcap-buffer-size-to-be-compatible-.patch

@@ -1,110 +0,0 @@
-From ce5aebeacd10a1c15cb3ee46a59c8b5ff235589e Mon Sep 17 00:00:00 2001
-Message-Id: <ce5aebeacd10a1c15cb3ee46a59c8b5ff235589e.1530632895.git.crobinso@redhat.com>
-From: Laine Stump <laine@laine.org>
-Date: Wed, 25 Apr 2018 17:12:03 -0400
-Subject: [PATCH] nwfilter: increase pcap buffer size to be compatible with
- TPACKET_V3
-
-When an nwfilter rule sets the parameter CTRL_IP_LEARNING to "dhcp",
-this turns on the "dhcpsnoop" thread, which uses libpcap to monitor
-traffic on the domain's tap device and extract the IP address from the
-DHCP response.
-
-If libpcap on the host is built with HAVE_TPACKET3 defined (to enable
-support for TPACKET_V3), the dhcpsnoop code's initialization of the
-libpcap socket would fail with the following error:
-
-  virNWFilterSnoopDHCPOpen:1134 : internal error: pcap_setfilter: can't remove kernel filter: Bad file descriptor
-
-It turns out that this was because TPACKET_V3 requires a larger buffer
-size than libvirt was setting (we were setting it to 128k). Changing
-the buffer size to 256k eliminates the error, and the dhcpsnoop thread
-once again works properly.
-
-A fuller explanation of why TPACKET_V3 requires such a large buffer,
-for future git spelunkers:
-
-libpcap calls setsockopt(... SOL_PACKET, PACKET_RX_RING...) to setup a
-ring buffer for receiving packets; two of the attributes sent to this
-API are called tp_frame_size, and tp_frame_nr. If libpcap was built
-with HAVE_TPACKET3 defined, tp_trame_size is set to MAXIMUM_SNAPLEN
-(defined in libpcap sources as 262144) and tp_frame_nr is set to:
-
- [the buffer size we set, i.e. PCAP_BUFFERSIZE i.e. 262144] / tp_frame_size.
-
-So if PCAP_BUFFERSIZE < MAXIMUM_SNAPLEN, then tp_frame_nr (the number
-of frames in the ring buffer) is 0, which is nonsensical. This same
-value is later used as a multiplier to determine the size for a call
-to malloc() (which would also fail).
-
-(NB: if HAVE_TPACKET3 is *not* defined, then tp_frame_size is set to
-the snaplen set by the user (in our case 576) plus a small amount to
-account for ethernet headers, so 256k is far more than adequate)
-
-Since the TPACKET_V3 code in libpcap actually reads multiple packets
-into each frame, it's not a problem to have only a single frame
-(especially when we are monitoring such infrequent traffic), so it's
-okay to set this relatively small buffer size (in comparison to the
-default, which is 2MB), which is important since every guest using
-dhcp snooping in a nwfilter rule will hold 2 of these buffers for the
-entire life of the guest.
-
-Thanks to Christian Ehrhardt for discovering that buffer size was the
-problem (this was not at all obvious from the error that was logged!)
-
-Resolves: https://bugzilla.redhat.com/1547237
-Fixes: https://bugs.launchpad.net/libvirt/+bug/1758037
-
-Signed-off-by: Laine Stump <laine@laine.org>
-Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> (V1)
-Reviewed-by: John Ferlan <jferlan@redhat.com>
-Tested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
-Signed-off-by: Cole Robinson <crobinso@redhat.com>
----
- src/nwfilter/nwfilter_dhcpsnoop.c | 22 +++++++++++++++++++---
- 1 file changed, 19 insertions(+), 3 deletions(-)
-
-diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c
-index 6069e70460..50cfb944a2 100644
---- a/src/nwfilter/nwfilter_dhcpsnoop.c
-+++ b/src/nwfilter/nwfilter_dhcpsnoop.c
-@@ -256,10 +256,21 @@ struct _virNWFilterDHCPDecodeJob {
- # define DHCP_BURST_INTERVAL_S  10 /* sec */
- 
- /*
-- * libpcap 1.5 requires a 128kb buffer
-- * 128 kb is bigger than (DHCP_PKT_BURST * PCAP_PBUFSIZE / 2)
-+ * NB: Any libpcap built with HAVE_TPACKET3 will require
-+ * PCAP_BUFFERSIZE to be at least 262144 (although
-+ * pcap_set_buffer_size() with a lower value will succeed, and the
-+ * error will only show up later when pcap_setfilter() is called).
-+ *
-+ * It is possible that in the future libpcap could increase the
-+ * minimum size even further, but due to the fact that each guest
-+ * using dhcp snooping keeps 2 pcap sockets open (and thus 2 buffers
-+ * allocated) for the life of the guest, we want to minimize the
-+ * length of the buffer, so instead of leaving it at the default size
-+ * (2MB), we are setting it to the minimum viable size and including
-+ * this clue in the source to help quickly resolve the problem when/if
-+ * it reoccurs.
-  */
--# define PCAP_BUFFERSIZE        (128 * 1024)
-+# define PCAP_BUFFERSIZE        (256 * 1024)
- 
- # define MAX_QUEUED_JOBS        (DHCP_PKT_BURST + 2 * DHCP_PKT_RATE)
- 
-@@ -1114,6 +1125,11 @@ virNWFilterSnoopDHCPOpen(const char *ifname, virMacAddr *mac,
-         goto cleanup_nohandle;
-     }
- 
-+    /* IMPORTANT: If there is any failure of *any* pcap_* function
-+     * during setup of the socket, look to the comment where
-+     * PCAP_BUFFERSIZE is defined. It may be too small, even if the
-+     * generated error doesn't imply that.
-+     */
-     if (pcap_set_snaplen(handle, PCAP_PBUFSIZE) < 0 ||
-         pcap_set_buffer_size(handle, PCAP_BUFFERSIZE) < 0 ||
-         pcap_activate(handle) < 0) {
--- 
-2.17.1
-

1000-util-add-virFileReadHeaderQuiet-wrapper-around-virFi.patch

@@ -1,74 +0,0 @@
-From e18672ce9a5fff383992fd6e842d1cbe85c141ea Mon Sep 17 00:00:00 2001
-From: Paolo Bonzini <pbonzini@redhat.com>
-Date: Tue, 12 Dec 2017 16:23:40 +0100
-Subject: [PATCH 10/19] util: add virFileReadHeaderQuiet wrapper around
- virFileReadHeaderFD
-
-CVE-2017-5715
-
-Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
----
- src/libvirt_private.syms |  1 +
- src/util/virfile.c       | 19 +++++++++++++++++++
- src/util/virfile.h       |  2 ++
- 3 files changed, 22 insertions(+)
-
-diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
-index f30a04b145..29b73fa046 100644
---- a/src/libvirt_private.syms
-+++ b/src/libvirt_private.syms
-@@ -1703,6 +1703,7 @@ virFileReadAll;
- virFileReadAllQuiet;
- virFileReadBufQuiet;
- virFileReadHeaderFD;
-+virFileReadHeaderQuiet;
- virFileReadLimFD;
- virFileReadLink;
- virFileReadValueBitmap;
-diff --git a/src/util/virfile.c b/src/util/virfile.c
-index 2f28e83f44..269db995ff 100644
---- a/src/util/virfile.c
-+++ b/src/util/virfile.c
-@@ -1356,6 +1356,25 @@ virFileReadHeaderFD(int fd, int maxlen, char **buf)
- }
- 
- 
-+int
-+virFileReadHeaderQuiet(const char *path,
-+                       int maxlen,
-+                       char **buf)
-+{
-+    int fd;
-+    int len;
-+
-+    fd = open(path, O_RDONLY);
-+    if (fd < 0)
-+        return -1;
-+
-+    len = virFileReadHeaderFD(fd, maxlen, buf);
-+    VIR_FORCE_CLOSE(fd);
-+
-+    return len;
-+}
-+
-+
- /* A wrapper around saferead_lim that maps a failure due to
-    exceeding the maximum size limitation to EOVERFLOW.  */
- int
-diff --git a/src/util/virfile.h b/src/util/virfile.h
-index 57ceb80721..657e7216fb 100644
---- a/src/util/virfile.h
-+++ b/src/util/virfile.h
-@@ -129,6 +129,8 @@ int virFileDeleteTree(const char *dir);
- 
- int virFileReadHeaderFD(int fd, int maxlen, char **buf)
-     ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(3);
-+int virFileReadHeaderQuiet(const char *path, int maxlen, char **buf)
-+    ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3);
- int virFileReadLimFD(int fd, int maxlen, char **buf)
-     ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(3);
- int virFileReadAll(const char *path, int maxlen, char **buf)
--- 
-2.17.0
-

1001-cpu_x86-Copy-CPU-signature-from-ancestor.patch

@@ -1,36 +0,0 @@
-From a84e70ad247da5d3ad13615efd70b91951392aa1 Mon Sep 17 00:00:00 2001
-From: Jiri Denemark <jdenemar@redhat.com>
-Date: Fri, 5 Jan 2018 17:43:03 +0100
-Subject: [PATCH 12/19] cpu_x86: Copy CPU signature from ancestor
-
-When specifying a new CPU model in cpu_map.xml as an extension to an
-existing model, we forgot to copy the signature (family + model) from
-the original CPU model.
-
-We don't use this way of specifying CPU models, but it's still supported
-and it becomes useful when someone wants to quickly hack up a CPU model
-for testing or when creating additional variants of existing models to
-help with fixing some spectral issues.
-
-Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
-Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
-(cherry picked from commit b427cf4831d0ea7aac9dd1a3aa7682478356a483)
----
- src/cpu/cpu_x86.c | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
-index 2864454211..3b7a6f95fe 100644
---- a/src/cpu/cpu_x86.c
-+++ b/src/cpu/cpu_x86.c
-@@ -1206,6 +1206,7 @@ x86ModelParse(xmlXPathContextPtr ctxt,
-         VIR_FREE(name);
- 
-         model->vendor = ancestor->vendor;
-+        model->signature = ancestor->signature;
-         if (x86DataCopy(&model->data, &ancestor->data) < 0)
-             goto error;
-     }
--- 
-2.17.0
-

1002-util-introduce-virHostCPUGetMicrocodeVersion.patch

@@ -1,97 +0,0 @@
-From de12d97c029d6644bb42afaa38410c4263bef41f Mon Sep 17 00:00:00 2001
-From: Paolo Bonzini <pbonzini@redhat.com>
-Date: Tue, 12 Dec 2017 16:23:41 +0100
-Subject: [PATCH 13/19] util: introduce virHostCPUGetMicrocodeVersion
-
-This new API reads host's CPU microcode version from /proc/cpuinfo.
-
-Unfortunately, there is no other way of reading microcode version which
-would be usable from both system and session daemon.
-
-CVE-2017-5715
-
-Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
----
- src/libvirt_private.syms |  1 +
- src/util/virhostcpu.c    | 43 ++++++++++++++++++++++++++++++++++++++++
- src/util/virhostcpu.h    |  2 ++
- 3 files changed, 46 insertions(+)
-
-diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
-index 29b73fa046..0ecd58a12c 100644
---- a/src/libvirt_private.syms
-+++ b/src/libvirt_private.syms
-@@ -1811,6 +1811,7 @@ virHostCPUGetCount;
- virHostCPUGetInfo;
- virHostCPUGetKVMMaxVCPUs;
- virHostCPUGetMap;
-+virHostCPUGetMicrocodeVersion;
- virHostCPUGetOnline;
- virHostCPUGetOnlineBitmap;
- virHostCPUGetPresentBitmap;
-diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c
-index c485a97211..713fdec553 100644
---- a/src/util/virhostcpu.c
-+++ b/src/util/virhostcpu.c
-@@ -1206,3 +1206,46 @@ virHostCPUGetKVMMaxVCPUs(void)
-     return -1;
- }
- #endif /* HAVE_LINUX_KVM_H */
-+
-+
-+#ifdef __linux__
-+
-+unsigned int
-+virHostCPUGetMicrocodeVersion(void)
-+{
-+    char *outbuf = NULL;
-+    char *cur;
-+    unsigned int version = 0;
-+
-+    if (virFileReadHeaderQuiet(CPUINFO_PATH, 4096, &outbuf) < 0) {
-+        char ebuf[1024];
-+        VIR_DEBUG("Failed to read microcode version from %s: %s",
-+                  CPUINFO_PATH, virStrerror(errno, ebuf, sizeof(ebuf)));
-+        return 0;
-+    }
-+
-+    /* Account for format 'microcode    : XXXX'*/
-+    if (!(cur = strstr(outbuf, "microcode")) ||
-+        !(cur = strchr(cur, ':')))
-+        goto cleanup;
-+    cur++;
-+
-+    /* Linux places the microcode revision in a 32-bit integer, so
-+     * ui is fine for us too.  */
-+    if (virStrToLong_ui(cur, &cur, 0, &version) < 0)
-+        goto cleanup;
-+
-+ cleanup:
-+    VIR_FREE(outbuf);
-+    return version;
-+}
-+
-+#else
-+
-+unsigned int
-+virHostCPUGetMicrocodeVersion(void)
-+{
-+    return 0;
-+}
-+
-+#endif
-diff --git a/src/util/virhostcpu.h b/src/util/virhostcpu.h
-index 67033de842..f9f3359288 100644
---- a/src/util/virhostcpu.h
-+++ b/src/util/virhostcpu.h
-@@ -66,4 +66,6 @@ virBitmapPtr virHostCPUGetSiblingsList(unsigned int cpu);
- 
- int virHostCPUGetOnline(unsigned int cpu, bool *online);
- 
-+unsigned int virHostCPUGetMicrocodeVersion(void);
-+
- #endif /* __VIR_HOSTCPU_H__*/
--- 
-2.17.0
-

1003-cpu_x86-Rename-virCPUx86MapInitialize.patch

@@ -1,51 +0,0 @@
-From a0ad8c160ed81417e4d5b46adf3118df1b6b1b77 Mon Sep 17 00:00:00 2001
-From: Jiri Denemark <jdenemar@redhat.com>
-Date: Wed, 13 Dec 2017 22:30:31 +0100
-Subject: [PATCH 14/19] cpu_x86: Rename virCPUx86MapInitialize
-
-The function will be used to initialize internal data of the x86 CPU
-driver (including the CPU map).
-
-CVE-2017-5715
-
-Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
----
- src/cpu/cpu_x86.c | 8 ++++----
- 1 file changed, 4 insertions(+), 4 deletions(-)
-
-diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
-index 3b7a6f95fe..0cb0dcacb3 100644
---- a/src/cpu/cpu_x86.c
-+++ b/src/cpu/cpu_x86.c
-@@ -153,8 +153,8 @@ struct _virCPUx86Map {
- };
- 
- static virCPUx86MapPtr cpuMap;
--int virCPUx86MapOnceInit(void);
--VIR_ONCE_GLOBAL_INIT(virCPUx86Map);
-+int virCPUx86DriverOnceInit(void);
-+VIR_ONCE_GLOBAL_INIT(virCPUx86Driver);
- 
- 
- typedef enum {
-@@ -1387,7 +1387,7 @@ virCPUx86LoadMap(void)
- 
- 
- int
--virCPUx86MapOnceInit(void)
-+virCPUx86DriverOnceInit(void)
- {
-     if (!(cpuMap = virCPUx86LoadMap()))
-         return -1;
-@@ -1399,7 +1399,7 @@ virCPUx86MapOnceInit(void)
- static virCPUx86MapPtr
- virCPUx86GetMap(void)
- {
--    if (virCPUx86MapInitialize() < 0)
-+    if (virCPUx86DriverInitialize() < 0)
-         return NULL;
- 
-     return cpuMap;
--- 
-2.17.0
-

1004-conf-include-x86-microcode-version-in-virsh-capabilt.patch

@@ -1,133 +0,0 @@
-From c628c42493170bfd70f30d9fb56d0067e6e4828a Mon Sep 17 00:00:00 2001
-From: Paolo Bonzini <pbonzini@redhat.com>
-Date: Tue, 19 Jun 2018 16:47:20 +0100
-Subject: [PATCH 15/19] conf: include x86 microcode version in virsh
- capabiltiies
-
-A microcode update can cause the CPUID bits to change; an example
-from the past was the update that disabled TSX on several Haswell and
-Broadwell machines.
-
-In order to track the x86 microcode version in the QEMU capabilities,
-we have to fetch it and store it in the host CPU.  This also makes the
-version visible in "virsh capabilities", which is a nice side effect.
-
-CVE-2017-5715
-
-Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
----
- src/conf/cpu_conf.c | 14 ++++++++++++++
- src/conf/cpu_conf.h |  1 +
- src/cpu/cpu_x86.c   |  9 +++++++++
- 3 files changed, 24 insertions(+)
-
-diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
-index c21d11d244..3f3c25320e 100644
---- a/src/conf/cpu_conf.c
-+++ b/src/conf/cpu_conf.c
-@@ -127,6 +127,7 @@ virCPUDefCopyModelFilter(virCPUDefPtr dst,
-         VIR_STRDUP(dst->vendor_id, src->vendor_id) < 0 ||
-         VIR_ALLOC_N(dst->features, src->nfeatures) < 0)
-         return -1;
-+    dst->microcodeVersion = src->microcodeVersion;
-     dst->nfeatures_max = src->nfeatures;
-     dst->nfeatures = 0;
- 
-@@ -178,6 +179,7 @@ virCPUDefStealModel(virCPUDefPtr dst,
- 
-     VIR_STEAL_PTR(dst->model, src->model);
-     VIR_STEAL_PTR(dst->features, src->features);
-+    dst->microcodeVersion = src->microcodeVersion;
-     dst->nfeatures_max = src->nfeatures_max;
-     src->nfeatures_max = 0;
-     dst->nfeatures = src->nfeatures;
-@@ -379,6 +381,14 @@ virCPUDefParseXML(xmlXPathContextPtr ctxt,
-             goto cleanup;
-         }
-         VIR_FREE(arch);
-+
-+        if (virXPathBoolean("boolean(./microcode[1]/@version)", ctxt) > 0 &&
-+            virXPathUInt("string(./microcode[1]/@version)", ctxt,
-+                         &def->microcodeVersion) < 0) {
-+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-+                           _("invalid microcode version"));
-+            goto cleanup;
-+        }
-     }
- 
-     if (!(def->model = virXPathString("string(./model[1])", ctxt)) &&
-@@ -723,6 +733,10 @@ virCPUDefFormatBuf(virBufferPtr buf,
-     if (formatModel && def->vendor)
-         virBufferEscapeString(buf, "<vendor>%s</vendor>\n", def->vendor);
- 
-+    if (def->type == VIR_CPU_TYPE_HOST && def->microcodeVersion)
-+        virBufferAsprintf(buf, "<microcode version='%u'/>\n",
-+                          def->microcodeVersion);
-+
-     if (def->sockets && def->cores && def->threads) {
-         virBufferAddLit(buf, "<topology");
-         virBufferAsprintf(buf, " sockets='%u'", def->sockets);
-diff --git a/src/conf/cpu_conf.h b/src/conf/cpu_conf.h
-index b44974f47e..a30ecf8681 100644
---- a/src/conf/cpu_conf.h
-+++ b/src/conf/cpu_conf.h
-@@ -133,6 +133,7 @@ struct _virCPUDef {
-     char *vendor_id;    /* vendor id returned by CPUID in the guest */
-     int fallback;       /* enum virCPUFallback */
-     char *vendor;
-+    unsigned int microcodeVersion;
-     unsigned int sockets;
-     unsigned int cores;
-     unsigned int threads;
-diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
-index 0cb0dcacb3..41aaa61c35 100644
---- a/src/cpu/cpu_x86.c
-+++ b/src/cpu/cpu_x86.c
-@@ -33,6 +33,7 @@
- #include "virbuffer.h"
- #include "virendian.h"
- #include "virstring.h"
-+#include "virhostcpu.h"
- 
- #define VIR_FROM_THIS VIR_FROM_CPU
- 
-@@ -153,6 +154,8 @@ struct _virCPUx86Map {
- };
- 
- static virCPUx86MapPtr cpuMap;
-+static unsigned int microcodeVersion;
-+
- int virCPUx86DriverOnceInit(void);
- VIR_ONCE_GLOBAL_INIT(virCPUx86Driver);
- 
-@@ -1392,6 +1395,8 @@ virCPUx86DriverOnceInit(void)
-     if (!(cpuMap = virCPUx86LoadMap()))
-         return -1;
- 
-+    microcodeVersion = virHostCPUGetMicrocodeVersion();
-+
-     return 0;
- }
- 
-@@ -2409,6 +2414,9 @@ virCPUx86GetHost(virCPUDefPtr cpu,
-     virCPUDataPtr cpuData = NULL;
-     int ret = -1;
- 
-+    if (virCPUx86DriverInitialize() < 0)
-+        goto cleanup;
-+
-     if (!(cpuData = virCPUDataNew(archs[0])))
-         goto cleanup;
- 
-@@ -2417,6 +2425,7 @@ virCPUx86GetHost(virCPUDefPtr cpu,
-         goto cleanup;
- 
-     ret = x86DecodeCPUData(cpu, cpuData, models, nmodels, NULL);
-+    cpu->microcodeVersion = microcodeVersion;
- 
-  cleanup:
-     virCPUx86DataFree(cpuData);
--- 
-2.17.0
-

1005-qemu-capabilities-force-update-if-the-microcode-vers.patch

@@ -1,535 +0,0 @@
-From a31edb693bb79f1ad8931db284f1dbceae178f27 Mon Sep 17 00:00:00 2001
-From: Paolo Bonzini <pbonzini@redhat.com>
-Date: Tue, 19 Jun 2018 16:50:02 +0100
-Subject: [PATCH 16/19] qemu: capabilities: force update if the microcode
- version does not match
-
-A microcode update can cause the CPUID bits to change; an example
-from the past was the update that disabled TSX on several Haswell
-and Broadwell machines.
-
-Therefore, place microcode version in the virQEMUCaps struct and
-XML, and rebuild the cache if the versions do not match.
-
-CVE-2017-5715
-
-Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
----
- src/qemu/qemu_capabilities.c                  | 40 ++++++++++++++++++-
- src/qemu/qemu_capabilities.h                  |  6 ++-
- src/qemu/qemu_capspriv.h                      |  6 +++
- src/qemu/qemu_driver.c                        |  9 ++++-
- .../caps_1.2.2.x86_64.xml                     |  1 +
- .../caps_1.3.1.x86_64.xml                     |  1 +
- .../caps_1.4.2.x86_64.xml                     |  1 +
- .../caps_1.5.3.x86_64.xml                     |  1 +
- .../caps_1.6.0.x86_64.xml                     |  1 +
- .../caps_1.7.0.x86_64.xml                     |  1 +
- .../caps_2.1.1.x86_64.xml                     |  1 +
- .../caps_2.4.0.x86_64.xml                     |  1 +
- .../caps_2.5.0.x86_64.xml                     |  1 +
- .../caps_2.6.0-gicv2.aarch64.xml              |  1 +
- .../caps_2.6.0-gicv3.aarch64.xml              |  1 +
- .../caps_2.6.0.ppc64le.xml                    |  1 +
- .../caps_2.6.0.x86_64.xml                     |  1 +
- .../qemucapabilitiesdata/caps_2.7.0.s390x.xml |  1 +
- .../caps_2.7.0.x86_64.xml                     |  1 +
- .../qemucapabilitiesdata/caps_2.8.0.s390x.xml |  1 +
- .../caps_2.8.0.x86_64.xml                     |  1 +
- .../caps_2.9.0.ppc64le.xml                    |  1 +
- .../qemucapabilitiesdata/caps_2.9.0.s390x.xml |  1 +
- .../caps_2.9.0.x86_64.xml                     |  1 +
- tests/qemucapabilitiestest.c                  | 14 +++++--
- tests/qemucapsprobe.c                         |  2 +-
- tests/testutilsqemu.c                         |  2 +-
- 27 files changed, 89 insertions(+), 10 deletions(-)
-
-diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
-index 2de84715ea..72b70ce750 100644
---- a/src/qemu/qemu_capabilities.c
-+++ b/src/qemu/qemu_capabilities.c
-@@ -500,6 +500,7 @@ struct _virQEMUCaps {
-     unsigned int version;
-     unsigned int kvmVersion;
-     unsigned int libvirtVersion;
-+    unsigned int microcodeVersion;
-     char *package;
- 
-     virArch arch;
-@@ -2304,6 +2305,7 @@ virQEMUCapsPtr virQEMUCapsNewCopy(virQEMUCapsPtr qemuCaps)
- 
-     ret->version = qemuCaps->version;
-     ret->kvmVersion = qemuCaps->kvmVersion;
-+    ret->microcodeVersion = qemuCaps->microcodeVersion;
- 
-     if (VIR_STRDUP(ret->package, qemuCaps->package) < 0)
-         goto error;
-@@ -3809,6 +3811,7 @@ struct _virQEMUCapsCachePriv {
-     uid_t runUid;
-     gid_t runGid;
-     virArch hostArch;
-+    unsigned int microcodeVersion;
- };
- typedef struct _virQEMUCapsCachePriv virQEMUCapsCachePriv;
- typedef virQEMUCapsCachePriv *virQEMUCapsCachePrivPtr;
-@@ -3931,6 +3934,13 @@ virQEMUCapsLoadCache(virArch hostArch,
-         goto cleanup;
-     }
- 
-+    if (virXPathUInt("string(./microcodeVersion)", ctxt,
-+                     &qemuCaps->microcodeVersion) < 0) {
-+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-+                       _("missing microcode version in QEMU capabilities cache"));
-+        goto cleanup;
-+    }
-+
-     if (virXPathBoolean("boolean(./package)", ctxt) > 0) {
-         qemuCaps->package = virXPathString("string(./package)", ctxt);
-         if (!qemuCaps->package &&
-@@ -4195,6 +4205,9 @@ virQEMUCapsFormatCache(virQEMUCapsPtr qemuCaps)
-     virBufferAsprintf(&buf, "<kvmVersion>%d</kvmVersion>\n",
-                       qemuCaps->kvmVersion);
- 
-+    virBufferAsprintf(&buf, "<microcodeVersion>%u</microcodeVersion>\n",
-+                      qemuCaps->microcodeVersion);
-+
-     if (qemuCaps->package)
-         virBufferAsprintf(&buf, "<package>%s</package>\n",
-                           qemuCaps->package);
-@@ -4336,6 +4349,16 @@ virQEMUCapsIsValid(void *data,
-         return false;
-     }
- 
-+    if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM) &&
-+        priv->microcodeVersion != qemuCaps->microcodeVersion) {
-+        VIR_DEBUG("Outdated capabilities for '%s': microcode version changed "
-+                  "(%u vs %u)",
-+                  qemuCaps->binary,
-+                  priv->microcodeVersion,
-+                  qemuCaps->microcodeVersion);
-+        return false;
-+    }
-+
-     return true;
- }
- 
-@@ -5151,6 +5174,7 @@ virQEMUCapsNewForBinaryInternal(virArch hostArch,
-                                 const char *libDir,
-                                 uid_t runUid,
-                                 gid_t runGid,
-+                                unsigned int microcodeVersion,
-                                 bool qmpOnly)
- {
-     virQEMUCapsPtr qemuCaps;
-@@ -5207,6 +5231,9 @@ virQEMUCapsNewForBinaryInternal(virArch hostArch,
-     virQEMUCapsInitHostCPUModel(qemuCaps, hostArch, VIR_DOMAIN_VIRT_KVM);
-     virQEMUCapsInitHostCPUModel(qemuCaps, hostArch, VIR_DOMAIN_VIRT_QEMU);
- 
-+    if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM))
-+        qemuCaps->microcodeVersion = microcodeVersion;
-+
-  cleanup:
-     VIR_FREE(qmperr);
-     return qemuCaps;
-@@ -5228,6 +5255,7 @@ virQEMUCapsNewData(const char *binary,
-                                            priv->libDir,
-                                            priv->runUid,
-                                            priv->runGid,
-+                                           priv->microcodeVersion,
-                                            false);
- }
- 
-@@ -5310,7 +5338,8 @@ virFileCachePtr
- virQEMUCapsCacheNew(const char *libDir,
-                     const char *cacheDir,
-                     uid_t runUid,
--                    gid_t runGid)
-+                    gid_t runGid,
-+                    unsigned int microcodeVersion)
- {
-     char *capsCacheDir = NULL;
-     virFileCachePtr cache = NULL;
-@@ -5333,6 +5362,7 @@ virQEMUCapsCacheNew(const char *libDir,
- 
-     priv->runUid = runUid;
-     priv->runGid = runGid;
-+    priv->microcodeVersion = microcodeVersion;
- 
-  cleanup:
-     VIR_FREE(capsCacheDir);
-@@ -5810,3 +5840,11 @@ virQEMUCapsFillDomainCaps(virCapsPtr caps,
-         return -1;
-     return 0;
- }
-+
-+
-+void
-+virQEMUCapsSetMicrocodeVersion(virQEMUCapsPtr qemuCaps,
-+                               unsigned int microcodeVersion)
-+{
-+    qemuCaps->microcodeVersion = microcodeVersion;
-+}
-diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
-index 9c92d6b469..eea296c9c3 100644
---- a/src/qemu/qemu_capabilities.h
-+++ b/src/qemu/qemu_capabilities.h
-@@ -514,8 +514,10 @@ void virQEMUCapsFilterByMachineType(virQEMUCapsPtr qemuCaps,
-                                     const char *machineType);
- 
- virFileCachePtr virQEMUCapsCacheNew(const char *libDir,
--                                        const char *cacheDir,
--                                        uid_t uid, gid_t gid);
-+                                    const char *cacheDir,
-+                                    uid_t uid,
-+                                    gid_t gid,
-+                                    unsigned int microcodeVersion);
- virQEMUCapsPtr virQEMUCapsCacheLookup(virFileCachePtr cache,
-                                       const char *binary);
- virQEMUCapsPtr virQEMUCapsCacheLookupCopy(virFileCachePtr cache,
-diff --git a/src/qemu/qemu_capspriv.h b/src/qemu/qemu_capspriv.h
-index d05256bd35..38c14ffa01 100644
---- a/src/qemu/qemu_capspriv.h
-+++ b/src/qemu/qemu_capspriv.h
-@@ -36,6 +36,7 @@ virQEMUCapsNewForBinaryInternal(virArch hostArch,
-                                 const char *libDir,
-                                 uid_t runUid,
-                                 gid_t runGid,
-+                                unsigned int microcodeVersion,
-                                 bool qmpOnly);
- 
- int virQEMUCapsLoadCache(virArch hostArch,
-@@ -101,4 +102,9 @@ virQEMUCapsParseHelpStr(const char *qemu,
- int
- virQEMUCapsParseDeviceStr(virQEMUCapsPtr qemuCaps,
-                           const char *str);
-+
-+void
-+virQEMUCapsSetMicrocodeVersion(virQEMUCapsPtr qemuCaps,
-+                               unsigned int microcodeVersion);
-+
- #endif
-diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
-index 208ccc9bc3..d8dc5388ea 100644
---- a/src/qemu/qemu_driver.c
-+++ b/src/qemu/qemu_driver.c
-@@ -631,6 +631,8 @@ qemuStateInitialize(bool privileged,
-     gid_t run_gid = -1;
-     char *hugepagePath = NULL;
-     size_t i;
-+    virCPUDefPtr hostCPU = NULL;
-+    unsigned int microcodeVersion = 0;
- 
-     if (VIR_ALLOC(qemu_driver) < 0)
-         return -1;
-@@ -853,10 +855,15 @@ qemuStateInitialize(bool privileged,
-         run_gid = cfg->group;
-     }
- 
-+    if ((hostCPU = virCPUProbeHost(virArchFromHost())))
-+        microcodeVersion = hostCPU->microcodeVersion;
-+    virCPUDefFree(hostCPU);
-+
-     qemu_driver->qemuCapsCache = virQEMUCapsCacheNew(cfg->libDir,
-                                                      cfg->cacheDir,
-                                                      run_uid,
--                                                     run_gid);
-+                                                     run_gid,
-+                                                     microcodeVersion);
-     if (!qemu_driver->qemuCapsCache)
-         goto error;
- 
-diff --git a/tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml
-index 956284d5d3..f3f66cd8f5 100644
---- a/tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml
-@@ -111,6 +111,7 @@
-   <flag name='query-cpu-definitions'/>
-   <version>1002002</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>26900</microcodeVersion>
-   <package></package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='qemu64'/>
-diff --git a/tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml
-index 99384ce5e6..1c4d5ff4a4 100644
---- a/tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml
-@@ -129,6 +129,7 @@
-   <flag name='query-cpu-definitions'/>
-   <version>1003001</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>30198</microcodeVersion>
-   <package></package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='qemu64'/>
-diff --git a/tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml
-index aea043c57d..a50383c259 100644
---- a/tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml
-@@ -130,6 +130,7 @@
-   <flag name='query-cpu-definitions'/>
-   <version>1004002</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>30915</microcodeVersion>
-   <package></package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='Opteron_G5'/>
-diff --git a/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml
-index 6f860e4f25..ad3e122775 100644
---- a/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml
-@@ -142,6 +142,7 @@
-   <flag name='kernel-irqchip'/>
-   <version>1005003</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>47019</microcodeVersion>
-   <package></package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='Opteron_G5'/>
-diff --git a/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml
-index e5dc8360de..7b2324d697 100644
---- a/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml
-@@ -147,6 +147,7 @@
-   <flag name='kernel-irqchip'/>
-   <version>1006000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>45248</microcodeVersion>
-   <package></package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='Opteron_G5'/>
-diff --git a/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml
-index 86d87eaf0c..4ba509a753 100644
---- a/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml
-@@ -149,6 +149,7 @@
-   <flag name='kernel-irqchip'/>
-   <version>1007000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>50692</microcodeVersion>
-   <package></package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='Opteron_G5'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml
-index 2fa551b1a0..416703ac89 100644
---- a/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml
-@@ -165,6 +165,7 @@
-   <flag name='kernel-irqchip'/>
-   <version>2001001</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>59488</microcodeVersion>
-   <package></package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='Opteron_G5'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml
-index f97e4cb813..4550139e0c 100644
---- a/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml
-@@ -190,6 +190,7 @@
-   <flag name='virtio-gpu.max_outputs'/>
-   <version>2004000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>75653</microcodeVersion>
-   <package></package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='Opteron_G5'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml
-index 2ba40fc494..6072438688 100644
---- a/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml
-@@ -196,6 +196,7 @@
-   <flag name='virtio-gpu.max_outputs'/>
-   <version>2005000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>216775</microcodeVersion>
-   <package></package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='Opteron_G5'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml
-index 0b34fa30d4..6fc0ab25e0 100644
---- a/tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.6.0-gicv2.aarch64.xml
-@@ -174,6 +174,7 @@
-   <flag name='virtio-gpu.max_outputs'/>
-   <version>2006000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>228838</microcodeVersion>
-   <package></package>
-   <arch>aarch64</arch>
-   <cpu type='kvm' name='pxa262'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml
-index d41d578c7e..1846bf6a7c 100644
---- a/tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.6.0-gicv3.aarch64.xml
-@@ -174,6 +174,7 @@
-   <flag name='virtio-gpu.max_outputs'/>
-   <version>2006000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>228838</microcodeVersion>
-   <package></package>
-   <arch>aarch64</arch>
-   <cpu type='kvm' name='pxa262'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml
-index f1c9fc98a4..199fc2cd22 100644
---- a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml
-@@ -169,6 +169,7 @@
-   <flag name='virtio-gpu.max_outputs'/>
-   <version>2006000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>263602</microcodeVersion>
-   <package></package>
-   <arch>ppc64</arch>
-   <cpu type='kvm' name='default'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml
-index bdf006f6be..5897fbc0c9 100644
---- a/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml
-@@ -206,6 +206,7 @@
-   <flag name='virtio-gpu.max_outputs'/>
-   <version>2006000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>227579</microcodeVersion>
-   <package></package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='Opteron_G5'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
-index fe7bca93b9..4c208008be 100644
---- a/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
-@@ -136,6 +136,7 @@
-   <flag name='virtio-gpu.max_outputs'/>
-   <version>2007000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>217559</microcodeVersion>
-   <package></package>
-   <arch>s390x</arch>
-   <cpu type='kvm' name='host'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml
-index 3fd28f09fe..e3a154806c 100644
---- a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml
-@@ -209,6 +209,7 @@
-   <flag name='virtio-gpu.max_outputs'/>
-   <version>2007000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>239276</microcodeVersion>
-   <package> (v2.7.0)</package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='Opteron_G5'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
-index 21bbb820d0..f13c783d44 100644
---- a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
-@@ -138,6 +138,7 @@
-   <flag name='virtio-gpu.max_outputs'/>
-   <version>2007093</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>242460</microcodeVersion>
-   <package></package>
-   <arch>s390x</arch>
-   <hostCPU type='kvm' model='zEC12.2-base' migratability='no'>
-diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
-index 761f9d1415..f5bd1d7272 100644
---- a/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
-@@ -211,6 +211,7 @@
-   <flag name='virtio-gpu.max_outputs'/>
-   <version>2008000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>255931</microcodeVersion>
-   <package> (v2.8.0)</package>
-   <arch>x86_64</arch>
-   <cpu type='kvm' name='host' usable='yes'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml
-index 9551907c66..2d1d0f9a89 100644
---- a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml
-@@ -175,6 +175,7 @@
-   <flag name='disk-share-rw'/>
-   <version>2009000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>347135</microcodeVersion>
-   <package> (v2.9.0)</package>
-   <arch>ppc64</arch>
-   <cpu type='kvm' name='default'/>
-diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
-index 0a6fbd0776..3b733801f8 100644
---- a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
-@@ -140,6 +140,7 @@
-   <flag name='disk-share-rw'/>
-   <version>2009000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>265878</microcodeVersion>
-   <package></package>
-   <arch>s390x</arch>
-   <hostCPU type='kvm' model='z13.2-base' migratability='no'>
-diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
-index 1294ebdb31..086594def5 100644
---- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
-+++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
-@@ -223,6 +223,7 @@
-   <flag name='disk-share-rw'/>
-   <version>2009000</version>
-   <kvmVersion>0</kvmVersion>
-+  <microcodeVersion>321194</microcodeVersion>
-   <package> (v2.9.0)</package>
-   <arch>x86_64</arch>
-   <hostCPU type='kvm' model='base' migratability='yes'>
-diff --git a/tests/qemucapabilitiestest.c b/tests/qemucapabilitiestest.c
-index 3ae55fc62f..4608fffbb2 100644
---- a/tests/qemucapabilitiestest.c
-+++ b/tests/qemucapabilitiestest.c
-@@ -61,10 +61,16 @@ testQemuCaps(const void *opaque)
-                                   qemuMonitorTestGetMonitor(mon)) < 0)
-         goto cleanup;
- 
--    if (virQEMUCapsGet(capsActual, QEMU_CAPS_KVM) &&
--        virQEMUCapsInitQMPMonitorTCG(capsActual,
--                                     qemuMonitorTestGetMonitor(mon)) < 0)
--        goto cleanup;
-+    if (virQEMUCapsGet(capsActual, QEMU_CAPS_KVM)) {
-+        if (virQEMUCapsInitQMPMonitorTCG(capsActual,
-+                                         qemuMonitorTestGetMonitor(mon)) < 0)
-+            goto cleanup;
-+
-+        /* Fill microcodeVersion with a "random" value which is the file
-+         * length to provide a reproducible number for testing.
-+         */
-+        virQEMUCapsSetMicrocodeVersion(capsActual, virFileLength(repliesFile, -1));
-+    }
- 
-     if (!(actual = virQEMUCapsFormatCache(capsActual)))
-         goto cleanup;
-diff --git a/tests/qemucapsprobe.c b/tests/qemucapsprobe.c
-index 4b8d6229b4..a5f5a38b16 100644
---- a/tests/qemucapsprobe.c
-+++ b/tests/qemucapsprobe.c
-@@ -72,7 +72,7 @@ main(int argc, char **argv)
-         return EXIT_FAILURE;
- 
-     if (!(caps = virQEMUCapsNewForBinaryInternal(VIR_ARCH_NONE, argv[1], "/tmp",
--                                                 -1, -1, true)))
-+                                                 -1, -1, 0, true)))
-         return EXIT_FAILURE;
- 
-     virObjectUnref(caps);
-diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
-index 2c7124bf26..f8182033fc 100644
---- a/tests/testutilsqemu.c
-+++ b/tests/testutilsqemu.c
-@@ -603,7 +603,7 @@ int qemuTestDriverInit(virQEMUDriver *driver)
- 
-     /* Using /dev/null for libDir and cacheDir automatically produces errors
-      * upon attempt to use any of them */
--    driver->qemuCapsCache = virQEMUCapsCacheNew("/dev/null", "/dev/null", 0, 0);
-+    driver->qemuCapsCache = virQEMUCapsCacheNew("/dev/null", "/dev/null", 0, 0, 0);
-     if (!driver->qemuCapsCache)
-         goto error;
- 
--- 
-2.17.0
-

1006-cpu-add-CPU-features-and-model-for-indirect-branch-p.patch

@@ -1,142 +0,0 @@
-From ac0e85360cd8f25160b67ee9fb45663d20f82c1d Mon Sep 17 00:00:00 2001
-From: Paolo Bonzini <pbonzini@redhat.com>
-Date: Tue, 19 Jun 2018 16:51:13 +0100
-Subject: [PATCH 17/19] cpu: add CPU features and model for indirect branch
- prediction protection
-
-CVE-2017-5715
-
-Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
----
- src/cpu/cpu_map.xml | 44 ++++++++++++++++++++++++++++++++++++++++++++
- 1 file changed, 44 insertions(+)
-
-diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
-index 8e7ac4973d..c31e7ce36a 100644
---- a/src/cpu/cpu_map.xml
-+++ b/src/cpu/cpu_map.xml
-@@ -283,6 +283,9 @@
-     <feature name='avx512-4fmaps'>
-       <cpuid eax_in='0x07' ecx_in='0x00' edx='0x00000008'/>
-     </feature>
-+    <feature name='spec-ctrl'>
-+      <cpuid eax_in='0x07' ecx_in='0x00' edx='0x04000000'/>
-+    </feature>
- 
-     <!-- Processor Extended State Enumeration sub leaf 1 -->
-     <feature name='xsaveopt'>
-@@ -411,6 +414,11 @@
-       <cpuid eax_in='0x80000007' edx='0x00000100'/>
-     </feature>
- 
-+    <!-- More AMD-specific features -->
-+    <feature name='ibpb'>
-+      <cpuid eax_in='0x80000008' ebx='0x00001000'/>
-+    </feature>
-+
-     <!-- models -->
-     <model name='486'>
-       <feature name='fpu'/>
-@@ -857,6 +865,10 @@
-       <feature name='syscall'/>
-       <feature name='tsc'/>
-     </model>
-+    <model name='Nehalem-IBRS'>
-+      <model name='Nehalem'/>
-+      <feature name='spec-ctrl'/>
-+    </model>
- 
-     <model name='Westmere'>
-       <signature family='6' model='44'/>
-@@ -894,6 +906,10 @@
-       <feature name='syscall'/>
-       <feature name='tsc'/>
-     </model>
-+    <model name='Westmere-IBRS'>
-+      <model name='Westmere'/>
-+      <feature name='spec-ctrl'/>
-+    </model>
- 
-     <model name='SandyBridge'>
-       <signature family='6' model='42'/>
-@@ -937,6 +953,10 @@
-       <feature name='x2apic'/>
-       <feature name='xsave'/>
-     </model>
-+    <model name='SandyBridge-IBRS'>
-+      <model name='SandyBridge'/>
-+      <feature name='spec-ctrl'/>
-+    </model>
- 
-     <model name='IvyBridge'>
-       <signature family='6' model='58'/>
-@@ -986,6 +1006,10 @@
-       <feature name='x2apic'/>
-       <feature name='xsave'/>
-     </model>
-+    <model name='IvyBridge-IBRS'>
-+      <model name='IvyBridge'/>
-+      <feature name='spec-ctrl'/>
-+    </model>
- 
-     <model name='Haswell-noTSX'>
-       <signature family='6' model='60'/>
-@@ -1039,6 +1063,10 @@
-       <feature name='x2apic'/>
-       <feature name='xsave'/>
-     </model>
-+    <model name='Haswell-noTSX-IBRS'>
-+      <model name='Haswell-noTSX'/>
-+      <feature name='spec-ctrl'/>
-+    </model>
- 
-     <model name='Haswell'>
-       <signature family='6' model='60'/>
-@@ -1094,6 +1122,10 @@
-       <feature name='x2apic'/>
-       <feature name='xsave'/>
-     </model>
-+    <model name='Haswell-IBRS'>
-+      <model name='Haswell'/>
-+      <feature name='spec-ctrl'/>
-+    </model>
- 
-     <model name='Broadwell-noTSX'>
-       <signature family='6' model='61'/>
-@@ -1151,6 +1183,10 @@
-       <feature name='x2apic'/>
-       <feature name='xsave'/>
-     </model>
-+    <model name='Broadwell-noTSX-IBRS'>
-+      <model name='Broadwell-noTSX'/>
-+      <feature name='spec-ctrl'/>
-+    </model>
- 
-     <model name='Broadwell'>
-       <signature family='6' model='61'/>
-@@ -1210,6 +1246,10 @@
-       <feature name='x2apic'/>
-       <feature name='xsave'/>
-     </model>
-+    <model name='Broadwell-IBRS'>
-+      <model name='Broadwell'/>
-+      <feature name='spec-ctrl'/>
-+    </model>
- 
-     <model name='Skylake-Client'>
-       <signature family='6' model='94'/>
-@@ -1278,6 +1318,10 @@
-       <feature name='xsavec'/>
-       <feature name='xsaveopt'/>
-     </model>
-+    <model name='Skylake-Client-IBRS'>
-+      <model name='Skylake-Client'/>
-+      <feature name='spec-ctrl'/>
-+    </model>
- 
-     <!-- AMD CPUs -->
-     <model name='athlon'>
--- 
-2.17.0
-

1007-cpu-define-the-ssbd-CPUID-feature-bit-CVE-2018-3639.patch

@@ -1,37 +0,0 @@
-From 9a252992aa81b4873b22f174de9d345f4289051c Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
-Date: Mon, 21 May 2018 23:05:07 +0100
-Subject: [PATCH 18/19] cpu: define the 'ssbd' CPUID feature bit
- (CVE-2018-3639)
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-New microcode introduces the "Speculative Store Bypass Disable"
-CPUID feature bit. This needs to be exposed to guest OS to allow
-them to protect against CVE-2018-3639.
-
-Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
-Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
-(cherry picked from commit 1dbca2eccad58d91a5fd33962854f1a653638182)
----
- src/cpu/cpu_map.xml | 3 +++
- 1 file changed, 3 insertions(+)
-
-diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
-index c31e7ce36a..87301dc0ef 100644
---- a/src/cpu/cpu_map.xml
-+++ b/src/cpu/cpu_map.xml
-@@ -286,6 +286,9 @@
-     <feature name='spec-ctrl'>
-       <cpuid eax_in='0x07' ecx_in='0x00' edx='0x04000000'/>
-     </feature>
-+    <feature name='ssbd'>
-+      <cpuid eax_in='0x07' ecx_in='0x00' edx='0x80000000'/>
-+    </feature>
- 
-     <!-- Processor Extended State Enumeration sub leaf 1 -->
-     <feature name='xsaveopt'>
--- 
-2.17.0
-

1008-cpu-define-the-virt-ssbd-CPUID-feature-bit-CVE-2018-.patch

@@ -1,46 +0,0 @@
-From 7774fbbda1c886633eaf0015d6211fc0ad703bc7 Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
-Date: Mon, 21 May 2018 23:05:08 +0100
-Subject: [PATCH 19/19] cpu: define the 'virt-ssbd' CPUID feature bit
- (CVE-2018-3639)
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-Some AMD processors only support a non-architectural means of
-enabling Speculative Store Bypass Disable. To allow simplified
-handling in virtual environments, hypervisors will expose an
-architectural definition through CPUID bit 0x80000008_EBX[25].
-This needs to be exposed to guest OS running on AMD x86 hosts to
-allow them to protect against CVE-2018-3639.
-
-Note that since this CPUID bit won't be present in the host CPUID
-results on physical hosts, it will not be enabled automatically
-in guests configured with "host-model" CPU unless using QEMU
-version >= 2.9.0. Thus for older versions of QEMU, this feature
-must be manually enabled using policy=force. Guests using the
-"host-passthrough" CPU mode do not need special handling.
-
-Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
-Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
----
- src/cpu/cpu_map.xml | 3 +++
- 1 file changed, 3 insertions(+)
-
-diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml
-index 87301dc0ef..e31c9ae86c 100644
---- a/src/cpu/cpu_map.xml
-+++ b/src/cpu/cpu_map.xml
-@@ -421,6 +421,9 @@
-     <feature name='ibpb'>
-       <cpuid eax_in='0x80000008' ebx='0x00001000'/>
-     </feature>
-+    <feature name='virt-ssbd'>
-+      <cpuid eax_in='0x80000008' ebx='0x02000000'/>
-+    </feature>
- 
-     <!-- models -->
-     <model name='486'>
--- 
-2.17.0
-

Makefile

@@ -1,21 +0,0 @@
-# Makefile for source rpm: libvirt
-# $Id$
-NAME := libvirt
-SPECFILE = $(firstword $(wildcard *.spec))
-
-define find-makefile-common
-for d in common ../common ../../common ; do if [ -f $$d/Makefile.common ] ; then if [ -f $$d/CVS/Root -a -w $$d/Makefile.common ] ; then cd $$d ; cvs -Q update ; fi ; echo "$$d/Makefile.common" ; break ; fi ; done
-endef
-
-MAKEFILE_COMMON := $(shell $(find-makefile-common))
-
-ifeq ($(MAKEFILE_COMMON),)
-# attempt a checkout
-define checkout-makefile-common
-test -f CVS/Root && { cvs -Q -d $$(cat CVS/Root) checkout common && echo "common/Makefile.common" ; } || { echo "ERROR: I can't figure out how to checkout the 'common' module." ; exit -1 ; } >&2
-endef
-
-MAKEFILE_COMMON := $(shell $(checkout-makefile-common))
-endif
-
-include $(MAKEFILE_COMMON)

sources

@@ -1 +1 @@
-SHA512 (libvirt-3.7.0.tar.xz) = b3f7021ef4c6954430f8fa503f0c49e3df4f662b228cb631ba2c2139ecec2307dde6cec05037cc28663e82ab1001296c20c5c68acd183cd364dd484a7746f498
+SHA512 (libvirt-11.0.0.tar.xz) = ac5fd17d3f488c241017d967364e0441373e9ab0457dab1acfe84fd0b90353dc5d185cc7fcd2b0d7995af4137a3fa18371abb5511686456a9e720f7ec7829da9