Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
10e74b75cb | ||
|
|
67283bdf89 | ||
|
|
e092293a63 | ||
|
|
41a6b3c03f | ||
|
|
31256f3d0d | ||
|
|
abac39a1b8 | ||
|
|
39e9be886f | ||
|
|
3db4281bc0 | ||
|
|
249ba7e495 | ||
|
|
33a8555d08 | ||
|
|
dfb6f9eee6 | ||
|
|
f5c4597c0a | ||
|
|
766bb232e8 | ||
|
|
266d5e2fcb | ||
|
|
c6cfdf3963 | ||
|
|
e3da3b01fc | ||
|
|
b340367499 | ||
|
|
ca7cc971b8 | ||
|
|
774125b7ed | ||
|
|
afd39d2091 | ||
|
|
cc16b7cd3a | ||
|
|
be942ea860 | ||
|
|
938b89f090 | ||
|
|
f7283923a3 | ||
|
|
1ad100593a | ||
|
|
21608be3b1 | ||
|
|
6347aef63f | ||
|
|
1c5d25ffeb | ||
|
|
8386ba3e9d | ||
|
|
03d3983515 | ||
|
|
1b0f3aaf64 | ||
|
|
647354eaf9 | ||
|
|
1392d7120d | ||
|
|
f80d27e126 | ||
|
|
63cd2ced20 | ||
|
|
cad1b6966f | ||
|
|
a27f478451 | ||
|
|
b94faf01a5 | ||
|
|
60a70c925a | ||
|
|
e184d967ac | ||
|
|
985ee7390d | ||
|
|
156ce5b5c7 | ||
|
|
77b02695ab | ||
|
|
50057212b3 | ||
|
|
c61c2c83ef | ||
|
|
e3e721c529 | ||
|
|
7bf08eb7cb | ||
|
|
0862e2b778 | ||
|
|
9ae002fc72 | ||
|
|
7749fc4a26 | ||
|
|
5b0f05f970 | ||
|
|
36079ddefa | ||
|
|
9abc69f078 | ||
|
|
f4d251ad6e | ||
|
|
b0d2e09842 | ||
|
|
b0dd011728 | ||
|
|
2513c9ff81 | ||
|
|
9ef5501a94 | ||
|
|
659f2f0b36 | ||
|
|
f3cac3532b | ||
|
|
6eb56c2e71 | ||
|
|
93a549eb1a | ||
|
|
f2a998ce76 | ||
|
|
8556d44e84 | ||
|
|
f8539fae13 | ||
|
|
80a3188a20 | ||
|
|
56d89b1d61 | ||
|
|
2a7828bae8 | ||
|
|
c879325741 | ||
|
|
edf6aa6cd7 | ||
|
|
163b87484b | ||
|
|
5828ec5da6 | ||
|
|
adaeee1c2c | ||
|
|
200f2942a9 | ||
|
|
cbf07f0551 | ||
|
|
eb9ceebe38 | ||
|
|
507eb37491 | ||
|
|
3e211fa0f6 | ||
|
|
d4bb64489a | ||
|
|
6d908194bf | ||
|
|
2333a80c1a | ||
|
|
f4fd6d7df6 | ||
|
|
c1a3411c3b | ||
|
|
619904f37a | ||
|
|
044c5b0665 | ||
|
|
50aba9b5a0 | ||
|
|
c98b586e70 | ||
|
|
987430ba8b | ||
|
|
58043b20fb | ||
|
|
f1888958a6 | ||
|
|
6c3d79e65d | ||
|
|
dc9be9b9a7 | ||
|
|
5e0d67787a | ||
|
|
662f0e2ba4 | ||
|
|
66060fa395 | ||
|
|
83def04a25 | ||
|
|
535bbcdd91 | ||
|
|
417e4c9cf7 | ||
|
|
24d349fa37 | ||
|
|
9f3b22fec4 | ||
|
|
7285a57f5c | ||
|
|
9944fa190c | ||
|
|
1a44dca7d4 | ||
|
|
0c2262d602 | ||
|
|
da598118cf | ||
|
|
da34e517db | ||
|
|
7b17ccd035 | ||
|
|
908a2f2a46 | ||
|
|
acf19787de | ||
|
|
c269619b9a | ||
|
|
3f6336f446 | ||
|
|
a552a10ec8 | ||
|
|
bfb8157052 | ||
|
|
edb5200d83 | ||
|
|
fe3f90dedd | ||
|
|
437df85540 | ||
|
|
2d6cbe6672 | ||
|
|
97a323d7c2 | ||
|
|
cb839d3dfc | ||
|
|
dc6b512f3c | ||
|
|
ac122f4525 | ||
|
|
7744acbb6b | ||
|
|
3807f07c15 | ||
|
|
e484fdc92b | ||
|
|
6752fe8c9e | ||
|
|
15f52369ae | ||
|
|
65a0e26138 | ||
|
|
497e096592 | ||
|
|
03a98aaf59 | ||
|
|
5845f1efec | ||
|
|
a8d01eb9d7 | ||
|
|
6d76ba5956 | ||
|
|
a11202d9e2 | ||
|
|
bbfa59c8da | ||
|
|
b97ad8956c | ||
|
|
f9639a0012 | ||
|
|
c71e60c76c | ||
|
|
9764121247 | ||
|
|
a18ed3c492 | ||
|
|
9e2eeb32e3 | ||
|
|
8bf91f5d22 | ||
|
|
91d8eff569 | ||
|
|
a761ea338f | ||
|
|
7eef88add4 | ||
|
|
0c88a64234 | ||
|
|
c2f3be1f4d | ||
|
|
18b1c9d77e | ||
|
|
4528832026 | ||
|
|
037cd36ba2 | ||
|
|
b94fb6a393 | ||
|
|
b0c05ac2ae | ||
|
|
15c305caf3 | ||
|
|
bc1b3e59a7 | ||
|
|
3c4492c415 | ||
|
|
fecc0295a2 | ||
|
|
325dc837c6 | ||
|
|
5a45cb7f0d | ||
|
|
21269530e8 | ||
|
|
fc18e983e7 | ||
|
|
4a7cc743a9 | ||
|
|
4398397311 | ||
|
|
401f9087bc | ||
|
|
dd3698988e | ||
|
|
3df49002c2 | ||
|
|
1bf0aedb9f | ||
|
|
79accd5a6e | ||
|
|
422d548fce | ||
|
|
20ec6e955c | ||
|
|
406a235cbc | ||
|
|
4d15e56a38 | ||
|
|
8693111790 | ||
|
|
8461a521f2 | ||
|
|
511e2c5124 | ||
|
|
749dc3d3cb | ||
|
|
73c9e38f2c | ||
|
|
afe8184d3f | ||
|
|
7d77bf76aa | ||
|
|
7f0f1b831e | ||
|
|
d964be0097 | ||
|
|
a2479f539e | ||
|
|
c2c89ec6a3 | ||
|
|
d61e2404ba | ||
|
|
a2be167dfe | ||
|
|
15ca09e1da | ||
|
|
2cc07e6366 | ||
|
|
4dd4fe78a4 | ||
|
|
0bc22fb6f7 | ||
|
|
76097a6961 | ||
|
|
98cbf39fd3 | ||
|
|
d670e246d0 | ||
|
|
50e7b9a91d | ||
|
|
5cbc0451ce | ||
|
|
b420054636 | ||
|
|
143fedee46 | ||
|
|
88887cac0f | ||
|
|
579afc99f2 | ||
|
|
7f5808b9d0 | ||
|
|
4df5f77071 | ||
|
|
1bdd527daf | ||
|
|
e5fa1c00d2 | ||
|
|
18f7b8c79c | ||
|
|
782468f8e9 | ||
|
|
202e7d9569 | ||
|
|
0676a07265 | ||
|
|
f57ce74947 | ||
|
|
851cfde15b | ||
|
|
06123137eb | ||
|
|
6ccf3cb58c | ||
|
|
030ddaa4ef | ||
|
|
a8886736c4 | ||
|
|
4fd635e537 | ||
|
|
6210c457fc | ||
|
|
82926cfdf0 | ||
|
|
e7a3ca6f6b | ||
|
|
1ae6f647b7 | ||
|
|
48941c011f | ||
|
|
a3c4cc6f3d | ||
|
|
90fbcbd48f | ||
|
|
6efd96d995 | ||
|
|
21316e7a45 | ||
|
|
8adbb7a402 | ||
|
|
3f19d41908 | ||
|
|
34da93e0c9 | ||
|
|
208f506190 | ||
|
|
0ca715cad9 | ||
|
|
0f5d8c1c22 | ||
|
|
a56bcbd063 | ||
|
|
89c3fa751c | ||
|
|
051644ffcb | ||
|
|
2a9c282548 | ||
|
|
2ae80af461 | ||
|
|
7335ede0e1 | ||
|
|
6c92ba3805 | ||
|
|
446f680673 | ||
|
|
3f56aa2870 | ||
|
|
3cec91694f | ||
|
|
cb0cfa566f | ||
|
|
a27acebf66 | ||
|
|
99d3a0ca1a | ||
|
|
9c962ebc4f | ||
|
|
99cbbf6606 | ||
|
|
b73e509648 | ||
|
|
b23ff9c0f7 | ||
|
|
20f9ed9c4c | ||
|
|
04cb28c315 | ||
|
|
a74ea318d1 | ||
|
|
98ed6b4e36 | ||
|
|
2c49d1fd11 | ||
|
|
6e7bca6631 | ||
|
|
2fe145bb02 | ||
|
|
10b7d235e3 | ||
|
|
232e2e7de2 | ||
|
|
fb1e4b061e | ||
|
|
0b1a013081 | ||
|
|
a972457f43 | ||
|
|
67cfa34a05 | ||
|
|
fc2ebb7646 | ||
|
|
e92b461b4f | ||
|
|
b1ac7b5791 | ||
|
|
88424efe85 | ||
|
|
4e2aab98a2 | ||
|
|
f4bc1a2fe2 | ||
|
|
a4bf2768b8 | ||
|
|
47cd44e9da | ||
|
|
731c6b90ff | ||
|
|
47ca46905d | ||
|
|
860ffc5b13 | ||
|
|
611b2ee520 | ||
|
|
edcb926f9d | ||
|
|
caebff8304 | ||
|
|
8fa41135ca | ||
|
|
0debbff964 | ||
|
|
d6cc78be66 | ||
|
|
8d9645735e | ||
|
|
4c65f08330 | ||
|
|
2427f8f078 | ||
|
|
d168e4f934 | ||
|
|
4dd365589f | ||
|
|
50e253df29 | ||
|
|
cb71801a2b | ||
|
|
4a9c74e91d | ||
|
|
281508ec99 | ||
|
|
feb92626e1 | ||
|
|
93cadb0880 | ||
|
|
dd6b57aa60 | ||
|
|
b8cb754e9d | ||
|
|
dbe61507bd | ||
|
|
ce7b23d9d0 | ||
|
|
8ded6ff93e | ||
|
|
1ef96f3488 | ||
|
|
ee3bf37900 | ||
|
|
7452a06938 | ||
|
|
fe8f9ed9c4 | ||
|
|
1b64f74c82 | ||
|
|
c81949046d | ||
|
|
19dcb913e6 | ||
|
|
e4b5ba1a9d | ||
|
|
5f1a422d83 | ||
|
|
c5b0b3ef9d | ||
|
|
c0a04cb876 | ||
|
|
3cc7cdf12f | ||
|
|
6b531d9967 | ||
|
|
4d05ac021c | ||
|
|
d29aa84b17 | ||
|
|
a075adc818 | ||
|
|
4d0e63f99c | ||
|
|
9e11936ec5 | ||
|
|
a4075ec632 | ||
|
|
dadb59c95f | ||
|
|
e73cc6a9d8 | ||
|
|
10cd84e37f | ||
|
|
e63e2040cd |
@@ -0,0 +1,31 @@
|
||||
[suppress_function]
|
||||
symbol_version_regexp = LIBVIRT_PRIVATE.*
|
||||
soname_regexp = libvirt\\.so.*
|
||||
|
||||
[suppress_function]
|
||||
symbol_version_regexp = LIBVIRT_ADMIN_PRIVATE.*
|
||||
soname_regexp = libvirt-admin\\.so.*
|
||||
|
||||
[suppress_variable]
|
||||
symbol_version_regexp = LIBVIRT_PRIVATE.*
|
||||
soname_regexp = libvirt\\.so.*
|
||||
|
||||
[suppress_variable]
|
||||
symbol_version_regexp = LIBVIRT_ADMIN_PRIVATE.*
|
||||
soname_regexp = libvirt-admin\\.so.*
|
||||
|
||||
[suppress_function]
|
||||
symbol_version_regexp = .*
|
||||
soname_regexp = libvirt_storage_.*\\.so.*
|
||||
|
||||
[suppress_variable]
|
||||
symbol_version_regexp = .*
|
||||
soname_regexp = libvirt_storage_.*\\.so.*
|
||||
|
||||
[suppress_function]
|
||||
symbol_version_regexp = .*
|
||||
soname_regexp = libvirt_driver_.*\\.so.*
|
||||
|
||||
[suppress_variable]
|
||||
symbol_version_regexp = .*
|
||||
soname_regexp = libvirt_driver_.*\\.so.*
|
||||
+1
-1
@@ -2,4 +2,4 @@
|
||||
*.rpm
|
||||
i686
|
||||
x86_64
|
||||
libvirt-*.tar.gz
|
||||
libvirt-*.tar.xz
|
||||
|
||||
@@ -0,0 +1,41 @@
|
||||
From 845210011a9ffd9d17e30c51cbc81ba67c5d3166 Mon Sep 17 00:00:00 2001
|
||||
From: Michal Privoznik <mprivozn@redhat.com>
|
||||
Date: Tue, 20 Jan 2026 10:08:29 +0100
|
||||
Subject: [PATCH] esx: Allow connecting to IPv6 server
|
||||
MIME-Version: 1.0
|
||||
Content-Type: text/plain; charset=UTF-8
|
||||
Content-Transfer-Encoding: 8bit
|
||||
|
||||
When connecting to a VMWare server, the hostname from URI is
|
||||
resolved using esxUtil_ResolveHostname() which in turn calls
|
||||
getaddrinfo(). But in the hints argument, we restrict the return
|
||||
address to be IPv4 (AF_INET) which obviously fails if the address
|
||||
to resolve is an IPv6 address. Set the hint to AF_UNSPEC which
|
||||
allows both IPv4 and IPv6. While at it, also allow IPv4 addresses
|
||||
mapped in IPv6 by setting AI_V4MAPPED flag.
|
||||
|
||||
Resolves: https://issues.redhat.com/browse/RHEL-138300
|
||||
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
||||
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
||||
---
|
||||
src/esx/esx_util.c | 4 ++--
|
||||
1 file changed, 2 insertions(+), 2 deletions(-)
|
||||
|
||||
diff --git a/src/esx/esx_util.c b/src/esx/esx_util.c
|
||||
index 88b3dc893f..a6275babd5 100644
|
||||
--- a/src/esx/esx_util.c
|
||||
+++ b/src/esx/esx_util.c
|
||||
@@ -275,8 +275,8 @@ esxUtil_ResolveHostname(const char *hostname, char **ipAddress)
|
||||
int errcode;
|
||||
g_autofree char *address = NULL;
|
||||
|
||||
- hints.ai_flags = AI_ADDRCONFIG;
|
||||
- hints.ai_family = AF_INET;
|
||||
+ hints.ai_flags = AI_ADDRCONFIG | AI_V4MAPPED;
|
||||
+ hints.ai_family = AF_UNSPEC;
|
||||
hints.ai_socktype = SOCK_STREAM;
|
||||
hints.ai_protocol = 0;
|
||||
|
||||
--
|
||||
2.52.0
|
||||
|
||||
@@ -1,291 +0,0 @@
|
||||
From 96a7f7fa1953707e1eb9f0f638baf213507a5cb2 Mon Sep 17 00:00:00 2001
|
||||
From: Cole Robinson <crobinso@redhat.com>
|
||||
Date: Tue, 23 Sep 2014 11:35:57 -0400
|
||||
Subject: [PATCH] qemu_command: Split qemuBuildCpuArgStr
|
||||
|
||||
Move the CPU mode/model handling to its own function. This is just
|
||||
code movement and re-indentation.
|
||||
|
||||
(cherry picked from commit e1d872dc77c80d43036f928f83f560f2e9286148)
|
||||
---
|
||||
src/qemu/qemu_command.c | 226 ++++++++++++++++++++++++++----------------------
|
||||
1 file changed, 122 insertions(+), 104 deletions(-)
|
||||
|
||||
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
|
||||
index eb72451..db5ea35 100644
|
||||
--- a/src/qemu/qemu_command.c
|
||||
+++ b/src/qemu/qemu_command.c
|
||||
@@ -6140,139 +6140,162 @@ qemuBuildClockArgStr(virDomainClockDefPtr def)
|
||||
return NULL;
|
||||
}
|
||||
|
||||
-
|
||||
static int
|
||||
-qemuBuildCpuArgStr(virQEMUDriverPtr driver,
|
||||
- const virDomainDef *def,
|
||||
- const char *emulator,
|
||||
- virQEMUCapsPtr qemuCaps,
|
||||
- virArch hostarch,
|
||||
- char **opt,
|
||||
- bool *hasHwVirt,
|
||||
- bool migrating)
|
||||
+qemuBuildCpuModelArgStr(virQEMUDriverPtr driver,
|
||||
+ const virDomainDef *def,
|
||||
+ virBufferPtr buf,
|
||||
+ virQEMUCapsPtr qemuCaps,
|
||||
+ bool *hasHwVirt,
|
||||
+ bool migrating)
|
||||
{
|
||||
+ int ret = -1;
|
||||
+ size_t i;
|
||||
virCPUDefPtr host = NULL;
|
||||
virCPUDefPtr guest = NULL;
|
||||
virCPUDefPtr cpu = NULL;
|
||||
size_t ncpus = 0;
|
||||
char **cpus = NULL;
|
||||
- const char *default_model;
|
||||
virCPUDataPtr data = NULL;
|
||||
- bool have_cpu = false;
|
||||
char *compare_msg = NULL;
|
||||
- int ret = -1;
|
||||
- virBuffer buf = VIR_BUFFER_INITIALIZER;
|
||||
- size_t i;
|
||||
+ virCPUCompareResult cmp;
|
||||
+ const char *preferred;
|
||||
virCapsPtr caps = NULL;
|
||||
|
||||
- *hasHwVirt = false;
|
||||
-
|
||||
if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
|
||||
goto cleanup;
|
||||
|
||||
host = caps->host.cpu;
|
||||
|
||||
- if (def->os.arch == VIR_ARCH_I686)
|
||||
- default_model = "qemu32";
|
||||
- else
|
||||
- default_model = "qemu64";
|
||||
+ if (!host ||
|
||||
+ !host->model ||
|
||||
+ (ncpus = virQEMUCapsGetCPUDefinitions(qemuCaps, &cpus)) == 0) {
|
||||
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||
+ _("CPU specification not supported by hypervisor"));
|
||||
+ goto cleanup;
|
||||
+ }
|
||||
|
||||
- if (def->cpu &&
|
||||
- (def->cpu->mode != VIR_CPU_MODE_CUSTOM || def->cpu->model)) {
|
||||
- virCPUCompareResult cmp;
|
||||
- const char *preferred;
|
||||
+ if (!(cpu = virCPUDefCopy(def->cpu)))
|
||||
+ goto cleanup;
|
||||
+
|
||||
+ if (cpu->mode != VIR_CPU_MODE_CUSTOM &&
|
||||
+ !migrating &&
|
||||
+ cpuUpdate(cpu, host) < 0)
|
||||
+ goto cleanup;
|
||||
|
||||
- if (!host ||
|
||||
- !host->model ||
|
||||
- (ncpus = virQEMUCapsGetCPUDefinitions(qemuCaps, &cpus)) == 0) {
|
||||
+ cmp = cpuGuestData(host, cpu, &data, &compare_msg);
|
||||
+ switch (cmp) {
|
||||
+ case VIR_CPU_COMPARE_INCOMPATIBLE:
|
||||
+ if (compare_msg) {
|
||||
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||
+ _("guest and host CPU are not compatible: %s"),
|
||||
+ compare_msg);
|
||||
+ } else {
|
||||
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||
- _("CPU specification not supported by hypervisor"));
|
||||
- goto cleanup;
|
||||
+ _("guest CPU is not compatible with host CPU"));
|
||||
}
|
||||
+ /* fall through */
|
||||
+ case VIR_CPU_COMPARE_ERROR:
|
||||
+ goto cleanup;
|
||||
|
||||
- if (!(cpu = virCPUDefCopy(def->cpu)))
|
||||
+ default:
|
||||
+ break;
|
||||
+ }
|
||||
+
|
||||
+ /* Only 'svm' requires --enable-nesting. The nested
|
||||
+ * 'vmx' patches now simply hook off the CPU features
|
||||
+ */
|
||||
+ if (def->os.arch == VIR_ARCH_X86_64 ||
|
||||
+ def->os.arch == VIR_ARCH_I686) {
|
||||
+ int hasSVM = cpuHasFeature(data, "svm");
|
||||
+ if (hasSVM < 0)
|
||||
goto cleanup;
|
||||
+ *hasHwVirt = hasSVM > 0 ? true : false;
|
||||
+ }
|
||||
|
||||
- if (cpu->mode != VIR_CPU_MODE_CUSTOM &&
|
||||
- !migrating &&
|
||||
- cpuUpdate(cpu, host) < 0)
|
||||
+ if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) {
|
||||
+ const char *mode = virCPUModeTypeToString(cpu->mode);
|
||||
+ if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_HOST)) {
|
||||
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||
+ _("CPU mode '%s' is not supported by QEMU"
|
||||
+ " binary"), mode);
|
||||
+ goto cleanup;
|
||||
+ }
|
||||
+ if (def->virtType != VIR_DOMAIN_VIRT_KVM) {
|
||||
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||
+ _("CPU mode '%s' is only supported with kvm"),
|
||||
+ mode);
|
||||
+ goto cleanup;
|
||||
+ }
|
||||
+ virBufferAddLit(buf, "host");
|
||||
+ } else {
|
||||
+ if (VIR_ALLOC(guest) < 0)
|
||||
+ goto cleanup;
|
||||
+ if (VIR_STRDUP(guest->vendor_id, cpu->vendor_id) < 0)
|
||||
goto cleanup;
|
||||
|
||||
- cmp = cpuGuestData(host, cpu, &data, &compare_msg);
|
||||
- switch (cmp) {
|
||||
- case VIR_CPU_COMPARE_INCOMPATIBLE:
|
||||
- if (compare_msg) {
|
||||
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||
- _("guest and host CPU are not compatible: %s"),
|
||||
- compare_msg);
|
||||
- } else {
|
||||
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||
- _("guest CPU is not compatible with host CPU"));
|
||||
- }
|
||||
- /* fall through */
|
||||
- case VIR_CPU_COMPARE_ERROR:
|
||||
+ guest->arch = host->arch;
|
||||
+ if (cpu->match == VIR_CPU_MATCH_MINIMUM)
|
||||
+ preferred = host->model;
|
||||
+ else
|
||||
+ preferred = cpu->model;
|
||||
+
|
||||
+ guest->type = VIR_CPU_TYPE_GUEST;
|
||||
+ guest->fallback = cpu->fallback;
|
||||
+ if (cpuDecode(guest, data, (const char **)cpus, ncpus, preferred) < 0)
|
||||
goto cleanup;
|
||||
|
||||
- default:
|
||||
- break;
|
||||
- }
|
||||
+ virBufferAdd(buf, guest->model, -1);
|
||||
+ if (guest->vendor_id)
|
||||
+ virBufferAsprintf(buf, ",vendor=%s", guest->vendor_id);
|
||||
+ for (i = 0; i < guest->nfeatures; i++) {
|
||||
+ char sign;
|
||||
+ if (guest->features[i].policy == VIR_CPU_FEATURE_DISABLE)
|
||||
+ sign = '-';
|
||||
+ else
|
||||
+ sign = '+';
|
||||
|
||||
- /* Only 'svm' requires --enable-nesting. The nested
|
||||
- * 'vmx' patches now simply hook off the CPU features
|
||||
- */
|
||||
- if (def->os.arch == VIR_ARCH_X86_64 ||
|
||||
- def->os.arch == VIR_ARCH_I686) {
|
||||
- int hasSVM = cpuHasFeature(data, "svm");
|
||||
- if (hasSVM < 0)
|
||||
- goto cleanup;
|
||||
- *hasHwVirt = hasSVM > 0 ? true : false;
|
||||
+ virBufferAsprintf(buf, ",%c%s", sign, guest->features[i].name);
|
||||
}
|
||||
+ }
|
||||
|
||||
- if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) {
|
||||
- const char *mode = virCPUModeTypeToString(cpu->mode);
|
||||
- if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CPU_HOST)) {
|
||||
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||
- _("CPU mode '%s' is not supported by QEMU"
|
||||
- " binary"), mode);
|
||||
- goto cleanup;
|
||||
- }
|
||||
- if (def->virtType != VIR_DOMAIN_VIRT_KVM) {
|
||||
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||
- _("CPU mode '%s' is only supported with kvm"),
|
||||
- mode);
|
||||
- goto cleanup;
|
||||
- }
|
||||
- virBufferAddLit(&buf, "host");
|
||||
- } else {
|
||||
- if (VIR_ALLOC(guest) < 0)
|
||||
- goto cleanup;
|
||||
- if (VIR_STRDUP(guest->vendor_id, cpu->vendor_id) < 0)
|
||||
- goto cleanup;
|
||||
+ ret = 0;
|
||||
+cleanup:
|
||||
+ virObjectUnref(caps);
|
||||
+ VIR_FREE(compare_msg);
|
||||
+ cpuDataFree(data);
|
||||
+ virCPUDefFree(guest);
|
||||
+ virCPUDefFree(cpu);
|
||||
+ return ret;
|
||||
+}
|
||||
|
||||
- guest->arch = host->arch;
|
||||
- if (cpu->match == VIR_CPU_MATCH_MINIMUM)
|
||||
- preferred = host->model;
|
||||
- else
|
||||
- preferred = cpu->model;
|
||||
+static int
|
||||
+qemuBuildCpuArgStr(virQEMUDriverPtr driver,
|
||||
+ const virDomainDef *def,
|
||||
+ const char *emulator,
|
||||
+ virQEMUCapsPtr qemuCaps,
|
||||
+ virArch hostarch,
|
||||
+ char **opt,
|
||||
+ bool *hasHwVirt,
|
||||
+ bool migrating)
|
||||
+{
|
||||
+ const char *default_model;
|
||||
+ bool have_cpu = false;
|
||||
+ int ret = -1;
|
||||
+ virBuffer buf = VIR_BUFFER_INITIALIZER;
|
||||
+ size_t i;
|
||||
|
||||
- guest->type = VIR_CPU_TYPE_GUEST;
|
||||
- guest->fallback = cpu->fallback;
|
||||
- if (cpuDecode(guest, data, (const char **)cpus, ncpus, preferred) < 0)
|
||||
- goto cleanup;
|
||||
+ *hasHwVirt = false;
|
||||
|
||||
- virBufferAdd(&buf, guest->model, -1);
|
||||
- if (guest->vendor_id)
|
||||
- virBufferAsprintf(&buf, ",vendor=%s", guest->vendor_id);
|
||||
- for (i = 0; i < guest->nfeatures; i++) {
|
||||
- char sign;
|
||||
- if (guest->features[i].policy == VIR_CPU_FEATURE_DISABLE)
|
||||
- sign = '-';
|
||||
- else
|
||||
- sign = '+';
|
||||
+ if (def->os.arch == VIR_ARCH_I686)
|
||||
+ default_model = "qemu32";
|
||||
+ else
|
||||
+ default_model = "qemu64";
|
||||
|
||||
- virBufferAsprintf(&buf, ",%c%s", sign, guest->features[i].name);
|
||||
- }
|
||||
- }
|
||||
+ if (def->cpu &&
|
||||
+ (def->cpu->mode != VIR_CPU_MODE_CUSTOM || def->cpu->model)) {
|
||||
+ if (qemuBuildCpuModelArgStr(driver, def, &buf, qemuCaps,
|
||||
+ hasHwVirt, migrating) < 0)
|
||||
+ goto cleanup;
|
||||
have_cpu = true;
|
||||
} else {
|
||||
/*
|
||||
@@ -6398,11 +6421,6 @@ qemuBuildCpuArgStr(virQEMUDriverPtr driver,
|
||||
ret = 0;
|
||||
|
||||
cleanup:
|
||||
- VIR_FREE(compare_msg);
|
||||
- cpuDataFree(data);
|
||||
- virCPUDefFree(guest);
|
||||
- virCPUDefFree(cpu);
|
||||
- virObjectUnref(caps);
|
||||
return ret;
|
||||
}
|
||||
|
||||
@@ -1,536 +0,0 @@
|
||||
From bbdbfbfc03494f5cbba4ee869149cca37c1fd53c Mon Sep 17 00:00:00 2001
|
||||
From: Cole Robinson <crobinso@redhat.com>
|
||||
Date: Tue, 23 Sep 2014 13:07:09 -0400
|
||||
Subject: [PATCH] qemu: Don't compare CPU against host for TCG
|
||||
|
||||
Right now when building the qemu command line, we try to do various
|
||||
unconditional validations of the guest CPU against the host CPU. However
|
||||
this checks are overly applied. The only time we should use the checks
|
||||
are:
|
||||
|
||||
- The user requests host-model/host-passthrough, or
|
||||
|
||||
- When KVM is requsted. CPU features requested in TCG mode are always
|
||||
emulated by qemu and are independent of the host CPU, so no host CPU
|
||||
checks should be performed.
|
||||
|
||||
Right now if trying to specify a CPU for arm on an x86 host, it attempts
|
||||
to do non-sensical validation and falls over.
|
||||
|
||||
Switch all the test cases that were intending to test CPU validation to
|
||||
use KVM, so they continue to test the intended code.
|
||||
|
||||
Amend some aarch64 XML tests with a CPU model, to ensure things work
|
||||
correctly.
|
||||
|
||||
(cherry picked from commit cf7fce8f2fd1c930f357fd4ff93ac35f38eb30c6)
|
||||
---
|
||||
src/qemu/qemu_command.c | 68 +++++++++++++---------
|
||||
.../qemuxml2argv-aarch64-virt-default-nic.args | 3 +-
|
||||
.../qemuxml2argv-aarch64-virt-default-nic.xml | 3 +
|
||||
.../qemuxml2argv-aarch64-virt-virtio.args | 3 +-
|
||||
.../qemuxml2argv-aarch64-virt-virtio.xml | 3 +
|
||||
.../qemuxml2argvdata/qemuxml2argv-cpu-exact1.args | 2 +-
|
||||
tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.xml | 4 +-
|
||||
.../qemuxml2argv-cpu-exact2-nofallback.args | 2 +-
|
||||
.../qemuxml2argv-cpu-exact2-nofallback.xml | 4 +-
|
||||
.../qemuxml2argvdata/qemuxml2argv-cpu-exact2.args | 2 +-
|
||||
tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.xml | 4 +-
|
||||
.../qemuxml2argv-cpu-fallback.args | 2 +-
|
||||
.../qemuxml2argvdata/qemuxml2argv-cpu-fallback.xml | 4 +-
|
||||
.../qemuxml2argv-cpu-minimum1.args | 2 +-
|
||||
.../qemuxml2argvdata/qemuxml2argv-cpu-minimum1.xml | 4 +-
|
||||
.../qemuxml2argv-cpu-minimum2.args | 2 +-
|
||||
.../qemuxml2argvdata/qemuxml2argv-cpu-minimum2.xml | 4 +-
|
||||
.../qemuxml2argv-cpu-nofallback.xml | 2 +-
|
||||
.../qemuxml2argvdata/qemuxml2argv-cpu-strict1.args | 2 +-
|
||||
.../qemuxml2argvdata/qemuxml2argv-cpu-strict1.xml | 4 +-
|
||||
.../qemuxml2argv-graphics-spice-timeout.args | 2 +-
|
||||
.../qemuxml2argv-graphics-spice-timeout.xml | 4 +-
|
||||
.../qemuxml2argv-pseries-cpu-exact.args | 4 +-
|
||||
tests/qemuxml2argvtest.c | 21 +++----
|
||||
.../qemuxml2xmlout-graphics-spice-timeout.xml | 4 +-
|
||||
25 files changed, 90 insertions(+), 69 deletions(-)
|
||||
|
||||
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
|
||||
index db5ea35..cd34445 100644
|
||||
--- a/src/qemu/qemu_command.c
|
||||
+++ b/src/qemu/qemu_command.c
|
||||
@@ -6160,6 +6160,8 @@ qemuBuildCpuModelArgStr(virQEMUDriverPtr driver,
|
||||
virCPUCompareResult cmp;
|
||||
const char *preferred;
|
||||
virCapsPtr caps = NULL;
|
||||
+ bool compareAgainstHost = (def->virtType == VIR_DOMAIN_VIRT_KVM ||
|
||||
+ def->cpu->mode != VIR_CPU_MODE_CUSTOM);
|
||||
|
||||
if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
|
||||
goto cleanup;
|
||||
@@ -6182,30 +6184,33 @@ qemuBuildCpuModelArgStr(virQEMUDriverPtr driver,
|
||||
cpuUpdate(cpu, host) < 0)
|
||||
goto cleanup;
|
||||
|
||||
- cmp = cpuGuestData(host, cpu, &data, &compare_msg);
|
||||
- switch (cmp) {
|
||||
- case VIR_CPU_COMPARE_INCOMPATIBLE:
|
||||
- if (compare_msg) {
|
||||
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||
- _("guest and host CPU are not compatible: %s"),
|
||||
- compare_msg);
|
||||
- } else {
|
||||
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||
- _("guest CPU is not compatible with host CPU"));
|
||||
- }
|
||||
- /* fall through */
|
||||
- case VIR_CPU_COMPARE_ERROR:
|
||||
- goto cleanup;
|
||||
+ /* For non-KVM, CPU features are emulated, so host compat doesn't matter */
|
||||
+ if (compareAgainstHost) {
|
||||
+ cmp = cpuGuestData(host, cpu, &data, &compare_msg);
|
||||
+ switch (cmp) {
|
||||
+ case VIR_CPU_COMPARE_INCOMPATIBLE:
|
||||
+ if (compare_msg) {
|
||||
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||
+ _("guest and host CPU are not compatible: %s"),
|
||||
+ compare_msg);
|
||||
+ } else {
|
||||
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||
+ _("guest CPU is not compatible with host CPU"));
|
||||
+ }
|
||||
+ /* fall through */
|
||||
+ case VIR_CPU_COMPARE_ERROR:
|
||||
+ goto cleanup;
|
||||
|
||||
- default:
|
||||
- break;
|
||||
+ default:
|
||||
+ break;
|
||||
+ }
|
||||
}
|
||||
|
||||
/* Only 'svm' requires --enable-nesting. The nested
|
||||
* 'vmx' patches now simply hook off the CPU features
|
||||
*/
|
||||
- if (def->os.arch == VIR_ARCH_X86_64 ||
|
||||
- def->os.arch == VIR_ARCH_I686) {
|
||||
+ if ((def->os.arch == VIR_ARCH_X86_64 || def->os.arch == VIR_ARCH_I686) &&
|
||||
+ compareAgainstHost) {
|
||||
int hasSVM = cpuHasFeature(data, "svm");
|
||||
if (hasSVM < 0)
|
||||
goto cleanup;
|
||||
@@ -6233,16 +6238,23 @@ qemuBuildCpuModelArgStr(virQEMUDriverPtr driver,
|
||||
if (VIR_STRDUP(guest->vendor_id, cpu->vendor_id) < 0)
|
||||
goto cleanup;
|
||||
|
||||
- guest->arch = host->arch;
|
||||
- if (cpu->match == VIR_CPU_MATCH_MINIMUM)
|
||||
- preferred = host->model;
|
||||
- else
|
||||
- preferred = cpu->model;
|
||||
+ if (compareAgainstHost) {
|
||||
+ guest->arch = host->arch;
|
||||
+ if (cpu->match == VIR_CPU_MATCH_MINIMUM)
|
||||
+ preferred = host->model;
|
||||
+ else
|
||||
+ preferred = cpu->model;
|
||||
|
||||
- guest->type = VIR_CPU_TYPE_GUEST;
|
||||
- guest->fallback = cpu->fallback;
|
||||
- if (cpuDecode(guest, data, (const char **)cpus, ncpus, preferred) < 0)
|
||||
- goto cleanup;
|
||||
+ guest->type = VIR_CPU_TYPE_GUEST;
|
||||
+ guest->fallback = cpu->fallback;
|
||||
+ if (cpuDecode(guest, data,
|
||||
+ (const char **)cpus, ncpus, preferred) < 0)
|
||||
+ goto cleanup;
|
||||
+ } else {
|
||||
+ guest->arch = def->os.arch;
|
||||
+ if (VIR_STRDUP(guest->model, cpu->model) < 0)
|
||||
+ goto cleanup;
|
||||
+ }
|
||||
|
||||
virBufferAdd(buf, guest->model, -1);
|
||||
if (guest->vendor_id)
|
||||
@@ -6259,7 +6271,7 @@ qemuBuildCpuModelArgStr(virQEMUDriverPtr driver,
|
||||
}
|
||||
|
||||
ret = 0;
|
||||
-cleanup:
|
||||
+ cleanup:
|
||||
virObjectUnref(caps);
|
||||
VIR_FREE(compare_msg);
|
||||
cpuDataFree(data);
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args
|
||||
index d4d403b..8cb57c5 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args
|
||||
@@ -1,5 +1,6 @@
|
||||
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
|
||||
-/usr/bin/qemu-system-aarch64 -S -M virt -m 1024 -smp 1 -nographic \
|
||||
+/usr/bin/qemu-system-aarch64 -S -M virt -cpu cortex-a53 \
|
||||
+-m 1024 -smp 1 -nographic \
|
||||
-nodefconfig -nodefaults -monitor unix:/tmp/test-monitor,server,nowait \
|
||||
-boot c -kernel /aarch64.kernel -initrd /aarch64.initrd -append console=ttyAMA0 \
|
||||
-usb -device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.xml b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.xml
|
||||
index 868de94..3a6f098 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.xml
|
||||
@@ -7,6 +7,9 @@
|
||||
<features>
|
||||
<acpi/>
|
||||
</features>
|
||||
+ <cpu match='exact'>
|
||||
+ <model>cortex-a53</model>
|
||||
+ </cpu>
|
||||
<os>
|
||||
<type arch="aarch64" machine="virt">hvm</type>
|
||||
<kernel>/aarch64.kernel</kernel>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args
|
||||
index afd6e41..05f3629 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args
|
||||
@@ -1,5 +1,6 @@
|
||||
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
|
||||
-/usr/bin/qemu-system-aarch64 -S -M virt -m 1024 -smp 1 -nographic \
|
||||
+/usr/bin/qemu-system-aarch64 -S -M virt -cpu cortex-a53 \
|
||||
+-m 1024 -smp 1 -nographic \
|
||||
-nodefconfig -nodefaults -monitor unix:/tmp/test-monitor,server,nowait \
|
||||
-boot c -kernel /aarch64.kernel -initrd /aarch64.initrd -append \
|
||||
'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.xml b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.xml
|
||||
index 184b62c..ad34615 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.xml
|
||||
@@ -16,6 +16,9 @@
|
||||
<apic/>
|
||||
<pae/>
|
||||
</features>
|
||||
+ <cpu match='exact'>
|
||||
+ <model>cortex-a53</model>
|
||||
+ </cpu>
|
||||
<clock offset="utc"/>
|
||||
<on_poweroff>destroy</on_poweroff>
|
||||
<on_reboot>restart</on_reboot>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.args b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.args
|
||||
index 76c2c48..0a58616 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.args
|
||||
@@ -1,5 +1,5 @@
|
||||
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
|
||||
-/usr/bin/qemu -S -M pc \
|
||||
+/usr/bin/qemu-kvm -S -M pc \
|
||||
-cpu qemu64,-svm,-lm,-nx,-syscall,-clflush,-pse36,-mca -m 214 -smp 6 \
|
||||
-nographic -monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot n -usb -net \
|
||||
none -serial none -parallel none
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.xml b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.xml
|
||||
index ddd9d5a..1d1e815 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.xml
|
||||
@@ -1,4 +1,4 @@
|
||||
-<domain type='qemu'>
|
||||
+<domain type='kvm'>
|
||||
<name>QEMUGuest1</name>
|
||||
<uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
||||
<memory unit='KiB'>219100</memory>
|
||||
@@ -23,6 +23,6 @@
|
||||
<on_reboot>restart</on_reboot>
|
||||
<on_crash>destroy</on_crash>
|
||||
<devices>
|
||||
- <emulator>/usr/bin/qemu</emulator>
|
||||
+ <emulator>/usr/bin/qemu-kvm</emulator>
|
||||
</devices>
|
||||
</domain>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2-nofallback.args b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2-nofallback.args
|
||||
index 0e37379..e46527b 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2-nofallback.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2-nofallback.args
|
||||
@@ -1,5 +1,5 @@
|
||||
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
|
||||
-/usr/bin/qemu -S -M pc \
|
||||
+/usr/bin/qemu-kvm -S -M pc \
|
||||
-cpu core2duo,+lahf_lm,+3dnowext,+xtpr,+ds_cpl,+tm,+ht,+ds,-nx -m 214 -smp 6 \
|
||||
-nographic -monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot n -usb -net \
|
||||
none -serial none -parallel none
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2-nofallback.xml b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2-nofallback.xml
|
||||
index de4c8d2..6b9b7d4 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2-nofallback.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2-nofallback.xml
|
||||
@@ -1,4 +1,4 @@
|
||||
-<domain type='qemu'>
|
||||
+<domain type='kvm'>
|
||||
<name>QEMUGuest1</name>
|
||||
<uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
||||
<memory unit='KiB'>219100</memory>
|
||||
@@ -30,6 +30,6 @@
|
||||
<on_reboot>restart</on_reboot>
|
||||
<on_crash>destroy</on_crash>
|
||||
<devices>
|
||||
- <emulator>/usr/bin/qemu</emulator>
|
||||
+ <emulator>/usr/bin/qemu-kvm</emulator>
|
||||
</devices>
|
||||
</domain>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.args b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.args
|
||||
index 0e37379..e46527b 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.args
|
||||
@@ -1,5 +1,5 @@
|
||||
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
|
||||
-/usr/bin/qemu -S -M pc \
|
||||
+/usr/bin/qemu-kvm -S -M pc \
|
||||
-cpu core2duo,+lahf_lm,+3dnowext,+xtpr,+ds_cpl,+tm,+ht,+ds,-nx -m 214 -smp 6 \
|
||||
-nographic -monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot n -usb -net \
|
||||
none -serial none -parallel none
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.xml b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.xml
|
||||
index e027e6f..eaea564 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.xml
|
||||
@@ -1,4 +1,4 @@
|
||||
-<domain type='qemu'>
|
||||
+<domain type='kvm'>
|
||||
<name>QEMUGuest1</name>
|
||||
<uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
||||
<memory unit='KiB'>219100</memory>
|
||||
@@ -30,6 +30,6 @@
|
||||
<on_reboot>restart</on_reboot>
|
||||
<on_crash>destroy</on_crash>
|
||||
<devices>
|
||||
- <emulator>/usr/bin/qemu</emulator>
|
||||
+ <emulator>/usr/bin/qemu-kvm</emulator>
|
||||
</devices>
|
||||
</domain>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-fallback.args b/tests/qemuxml2argvdata/qemuxml2argv-cpu-fallback.args
|
||||
index 4ee8391..ead561f 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-fallback.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-fallback.args
|
||||
@@ -3,7 +3,7 @@ PATH=/bin \
|
||||
HOME=/home/test \
|
||||
USER=test \
|
||||
LOGNAME=test QEMU_AUDIO_DRV=none \
|
||||
-/usr/bin/qemu \
|
||||
+/usr/bin/qemu-kvm \
|
||||
-S \
|
||||
-M pc \
|
||||
-cpu Penryn,-sse4.1 \
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-fallback.xml b/tests/qemuxml2argvdata/qemuxml2argv-cpu-fallback.xml
|
||||
index 6125f41..85642e9 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-fallback.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-fallback.xml
|
||||
@@ -1,4 +1,4 @@
|
||||
-<domain type='qemu'>
|
||||
+<domain type='kvm'>
|
||||
<name>QEMUGuest1</name>
|
||||
<uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
||||
<memory unit='KiB'>219100</memory>
|
||||
@@ -20,6 +20,6 @@
|
||||
<on_reboot>restart</on_reboot>
|
||||
<on_crash>destroy</on_crash>
|
||||
<devices>
|
||||
- <emulator>/usr/bin/qemu</emulator>
|
||||
+ <emulator>/usr/bin/qemu-kvm</emulator>
|
||||
</devices>
|
||||
</domain>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum1.args b/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum1.args
|
||||
index 0630ef4..d8207e7 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum1.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum1.args
|
||||
@@ -1,5 +1,5 @@
|
||||
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
|
||||
-/usr/bin/qemu -S -M pc \
|
||||
+/usr/bin/qemu-kvm -S -M pc \
|
||||
-cpu core2duo,+lahf_lm,+xtpr,+cx16,+tm2,+est,+vmx,+ds_cpl,+pbe,+tm,+ht,+ss,\
|
||||
+acpi,+ds -m 214 -smp 6 -nographic -monitor unix:/tmp/test-monitor,server,\
|
||||
nowait -no-acpi -boot n -usb -net none -serial none -parallel none
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum1.xml b/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum1.xml
|
||||
index 4ba5d0b..5879d35 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum1.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum1.xml
|
||||
@@ -1,4 +1,4 @@
|
||||
-<domain type='qemu'>
|
||||
+<domain type='kvm'>
|
||||
<name>QEMUGuest1</name>
|
||||
<uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
||||
<memory unit='KiB'>219100</memory>
|
||||
@@ -16,6 +16,6 @@
|
||||
<on_reboot>restart</on_reboot>
|
||||
<on_crash>destroy</on_crash>
|
||||
<devices>
|
||||
- <emulator>/usr/bin/qemu</emulator>
|
||||
+ <emulator>/usr/bin/qemu-kvm</emulator>
|
||||
</devices>
|
||||
</domain>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum2.args b/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum2.args
|
||||
index 830994f..17ba256 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum2.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum2.args
|
||||
@@ -1,5 +1,5 @@
|
||||
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
|
||||
-/usr/bin/qemu -S -M pc \
|
||||
+/usr/bin/qemu-kvm -S -M pc \
|
||||
-cpu core2duo,+lahf_lm,+xtpr,+cx16,+tm2,+est,+vmx,+ds_cpl,+pbe,+tm,+ht,+ss,\
|
||||
+acpi,+ds,-lm,-nx,-syscall -m 214 -smp 6 -nographic -monitor \
|
||||
unix:/tmp/test-monitor,server,nowait -no-acpi -boot n -usb -net none -serial none \
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum2.xml b/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum2.xml
|
||||
index c43bf4f..b8bbf25 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum2.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum2.xml
|
||||
@@ -1,4 +1,4 @@
|
||||
-<domain type='qemu'>
|
||||
+<domain type='kvm'>
|
||||
<name>QEMUGuest1</name>
|
||||
<uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
||||
<memory unit='KiB'>219100</memory>
|
||||
@@ -20,6 +20,6 @@
|
||||
<on_reboot>restart</on_reboot>
|
||||
<on_crash>destroy</on_crash>
|
||||
<devices>
|
||||
- <emulator>/usr/bin/qemu</emulator>
|
||||
+ <emulator>/usr/bin/qemu-kvm</emulator>
|
||||
</devices>
|
||||
</domain>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-nofallback.xml b/tests/qemuxml2argvdata/qemuxml2argv-cpu-nofallback.xml
|
||||
index 4ae0be8..abb0e9c 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-nofallback.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-nofallback.xml
|
||||
@@ -1,4 +1,4 @@
|
||||
-<domain type='qemu'>
|
||||
+<domain type='kvm'>
|
||||
<name>QEMUGuest1</name>
|
||||
<uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
||||
<memory unit='KiB'>219100</memory>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-strict1.args b/tests/qemuxml2argvdata/qemuxml2argv-cpu-strict1.args
|
||||
index 8b545a7..c500ef7 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-strict1.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-strict1.args
|
||||
@@ -1,5 +1,5 @@
|
||||
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
|
||||
-/usr/bin/qemu -S -M pc \
|
||||
+/usr/bin/qemu-kvm -S -M pc \
|
||||
-cpu core2duo,+lahf_lm,+3dnowext,+xtpr,+est,+vmx,+ds_cpl,+tm,+ht,+acpi,+ds,-nx \
|
||||
-m 214 -smp 6 -nographic -monitor unix:/tmp/test-monitor,server,nowait \
|
||||
-no-acpi -boot n -usb -net none -serial none -parallel none
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cpu-strict1.xml b/tests/qemuxml2argvdata/qemuxml2argv-cpu-strict1.xml
|
||||
index 935f46f..a9fc9c5 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-cpu-strict1.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-cpu-strict1.xml
|
||||
@@ -1,4 +1,4 @@
|
||||
-<domain type='qemu'>
|
||||
+<domain type='kvm'>
|
||||
<name>QEMUGuest1</name>
|
||||
<uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
||||
<memory unit='KiB'>219100</memory>
|
||||
@@ -33,6 +33,6 @@
|
||||
<on_reboot>restart</on_reboot>
|
||||
<on_crash>destroy</on_crash>
|
||||
<devices>
|
||||
- <emulator>/usr/bin/qemu</emulator>
|
||||
+ <emulator>/usr/bin/qemu-kvm</emulator>
|
||||
</devices>
|
||||
</domain>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.args b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.args
|
||||
index 48744b2..8b5d9ee 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.args
|
||||
@@ -1,5 +1,5 @@
|
||||
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=spice \
|
||||
-/usr/bin/qemu -S -M pc -cpu core2duo,+lahf_lm,+xtpr,+cx16,+tm2,\
|
||||
+/usr/bin/qemu-kvm -S -M pc -cpu core2duo,+lahf_lm,+xtpr,+cx16,+tm2,\
|
||||
+est,+vmx,+ds_cpl,+pbe,+tm,+ht,+ss,+acpi,+ds \
|
||||
-m 1024 -smp 2 -nodefaults -monitor unix:/tmp/test-monitor,server,nowait \
|
||||
-boot dc -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x6 \
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.xml
|
||||
index e6ecbed..3ed864c 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.xml
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.xml
|
||||
@@ -1,4 +1,4 @@
|
||||
-<domain type='qemu'>
|
||||
+<domain type='kvm'>
|
||||
<name>f14</name>
|
||||
<uuid>553effab-b5e1-2d80-dfe3-da4344826c43</uuid>
|
||||
<memory unit='KiB'>1048576</memory>
|
||||
@@ -38,7 +38,7 @@
|
||||
<on_reboot>restart</on_reboot>
|
||||
<on_crash>restart</on_crash>
|
||||
<devices>
|
||||
- <emulator>/usr/bin/qemu</emulator>
|
||||
+ <emulator>/usr/bin/qemu-kvm</emulator>
|
||||
<disk type='file' device='disk'>
|
||||
<driver name='qemu' type='qcow2'/>
|
||||
<source file='/var/lib/libvirt/images/f14.img'/>
|
||||
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-pseries-cpu-exact.args b/tests/qemuxml2argvdata/qemuxml2argv-pseries-cpu-exact.args
|
||||
index 1e09680..9927294 100644
|
||||
--- a/tests/qemuxml2argvdata/qemuxml2argv-pseries-cpu-exact.args
|
||||
+++ b/tests/qemuxml2argvdata/qemuxml2argv-pseries-cpu-exact.args
|
||||
@@ -1,6 +1,6 @@
|
||||
LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test \
|
||||
-/usr/bin/qemu-system-ppc64 -S -M pseries -cpu POWER7_v2.3 -m 512 -smp 1 -nographic \
|
||||
--nodefconfig -nodefaults \
|
||||
+QEMU_AUDIO_DRV=none /usr/bin/qemu-system-ppc64 -S -M pseries -cpu POWER7_v2.3 \
|
||||
+-m 512 -smp 1 -nographic -nodefconfig -nodefaults \
|
||||
-chardev socket,id=charmonitor,path=/tmp/test-monitor,server,nowait \
|
||||
-mon chardev=charmonitor,id=monitor,mode=readline -no-acpi -boot c -usb \
|
||||
-chardev pty,id=charserial0 \
|
||||
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
|
||||
index b380fd8..483ca90 100644
|
||||
--- a/tests/qemuxml2argvtest.c
|
||||
+++ b/tests/qemuxml2argvtest.c
|
||||
@@ -933,7 +933,7 @@ mymain(void)
|
||||
QEMU_CAPS_DEVICE, QEMU_CAPS_SPICE,
|
||||
QEMU_CAPS_DEVICE_QXL);
|
||||
DO_TEST("graphics-spice-timeout",
|
||||
- QEMU_CAPS_DRIVE,
|
||||
+ QEMU_CAPS_KVM, QEMU_CAPS_DRIVE,
|
||||
QEMU_CAPS_VGA, QEMU_CAPS_VGA_QXL,
|
||||
QEMU_CAPS_DEVICE, QEMU_CAPS_SPICE,
|
||||
QEMU_CAPS_DEVICE_QXL_VGA);
|
||||
@@ -1208,14 +1208,14 @@ mymain(void)
|
||||
DO_TEST("cpu-topology1", QEMU_CAPS_SMP_TOPOLOGY);
|
||||
DO_TEST("cpu-topology2", QEMU_CAPS_SMP_TOPOLOGY);
|
||||
DO_TEST("cpu-topology3", NONE);
|
||||
- DO_TEST("cpu-minimum1", NONE);
|
||||
- DO_TEST("cpu-minimum2", NONE);
|
||||
- DO_TEST("cpu-exact1", NONE);
|
||||
- DO_TEST("cpu-exact2", NONE);
|
||||
- DO_TEST("cpu-exact2-nofallback", NONE);
|
||||
- DO_TEST("cpu-fallback", NONE);
|
||||
- DO_TEST_FAILURE("cpu-nofallback", NONE);
|
||||
- DO_TEST("cpu-strict1", NONE);
|
||||
+ DO_TEST("cpu-minimum1", QEMU_CAPS_KVM);
|
||||
+ DO_TEST("cpu-minimum2", QEMU_CAPS_KVM);
|
||||
+ DO_TEST("cpu-exact1", QEMU_CAPS_KVM);
|
||||
+ DO_TEST("cpu-exact2", QEMU_CAPS_KVM);
|
||||
+ DO_TEST("cpu-exact2-nofallback", QEMU_CAPS_KVM);
|
||||
+ DO_TEST("cpu-fallback", QEMU_CAPS_KVM);
|
||||
+ DO_TEST_FAILURE("cpu-nofallback", QEMU_CAPS_KVM);
|
||||
+ DO_TEST("cpu-strict1", QEMU_CAPS_KVM);
|
||||
DO_TEST("cpu-numa1", NONE);
|
||||
DO_TEST("cpu-numa2", QEMU_CAPS_SMP_TOPOLOGY);
|
||||
DO_TEST_PARSE_ERROR("cpu-numa3", NONE);
|
||||
@@ -1303,7 +1303,8 @@ mymain(void)
|
||||
DO_TEST("pseries-usb-kbd", QEMU_CAPS_PCI_OHCI,
|
||||
QEMU_CAPS_DEVICE_USB_KBD, QEMU_CAPS_CHARDEV,
|
||||
QEMU_CAPS_DEVICE, QEMU_CAPS_NODEFCONFIG);
|
||||
- DO_TEST_FAILURE("pseries-cpu-exact", QEMU_CAPS_CHARDEV, QEMU_CAPS_DEVICE, QEMU_CAPS_NODEFCONFIG);
|
||||
+ DO_TEST("pseries-cpu-exact", QEMU_CAPS_CHARDEV, QEMU_CAPS_DEVICE,
|
||||
+ QEMU_CAPS_NODEFCONFIG);
|
||||
DO_TEST("disk-ide-drive-split",
|
||||
QEMU_CAPS_DRIVE, QEMU_CAPS_DEVICE, QEMU_CAPS_NODEFCONFIG,
|
||||
QEMU_CAPS_IDE_CD);
|
||||
diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-timeout.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-timeout.xml
|
||||
index 44c4cf7..73ebcab 100644
|
||||
--- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-timeout.xml
|
||||
+++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-spice-timeout.xml
|
||||
@@ -1,4 +1,4 @@
|
||||
-<domain type='qemu'>
|
||||
+<domain type='kvm'>
|
||||
<name>f14</name>
|
||||
<uuid>553effab-b5e1-2d80-dfe3-da4344826c43</uuid>
|
||||
<memory unit='KiB'>1048576</memory>
|
||||
@@ -38,7 +38,7 @@
|
||||
<on_reboot>restart</on_reboot>
|
||||
<on_crash>restart</on_crash>
|
||||
<devices>
|
||||
- <emulator>/usr/bin/qemu</emulator>
|
||||
+ <emulator>/usr/bin/qemu-kvm</emulator>
|
||||
<disk type='file' device='disk'>
|
||||
<driver name='qemu' type='qcow2'/>
|
||||
<source file='/var/lib/libvirt/images/f14.img'/>
|
||||
@@ -1,81 +0,0 @@
|
||||
From 1c20d4a0a608d65d02953b360c6f10397d3c4069 Mon Sep 17 00:00:00 2001
|
||||
From: Michal Privoznik <mprivozn@redhat.com>
|
||||
Date: Tue, 7 Oct 2014 16:22:17 +0200
|
||||
Subject: [PATCH] security_selinux: Don't relabel /dev/net/tun
|
||||
|
||||
https://bugzilla.redhat.com/show_bug.cgi?id=1147057
|
||||
|
||||
The code for relabelling the TAP FD is there due to a race. When
|
||||
libvirt creates a /dev/tapN device it's labeled as
|
||||
'system_u:object_r:device_t:s0' by default. Later, when
|
||||
udev/systemd reacts to this device, it's relabelled to the
|
||||
expected label 'system_u:object_r:tun_tap_device_t:s0'. Hence, we
|
||||
have a code that relabels the device, to cut the race down. For
|
||||
more info see ae368ebfcc4.
|
||||
|
||||
But the problem is, the relabel function is called on all TUN/TAP
|
||||
devices. Yes, on /dev/net/tun too. This is however a special kind
|
||||
of device - other processes uses it too. We shouldn't touch it's
|
||||
label then.
|
||||
|
||||
Ideally, there would an API in SELinux that would label just the
|
||||
passed FD and not the underlying path. That way, we wouldn't need
|
||||
to care as we would be not labeling /dev/net/tun but the FD
|
||||
passed to the domain. Unfortunately, there's no such API so we
|
||||
have to workaround until then.
|
||||
|
||||
Tested-by: Richard W.M. Jones <rjones@redhat.com>
|
||||
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
||||
(cherry picked from commit ebc05263960f41065fa7d882959ea754b9281ab1)
|
||||
---
|
||||
src/security/security_selinux.c | 23 +++++++++++++++++++++--
|
||||
1 file changed, 21 insertions(+), 2 deletions(-)
|
||||
|
||||
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
|
||||
index b7c1015..352f1ab 100644
|
||||
--- a/src/security/security_selinux.c
|
||||
+++ b/src/security/security_selinux.c
|
||||
@@ -2352,7 +2352,7 @@ virSecuritySELinuxSetTapFDLabel(virSecurityManagerPtr mgr,
|
||||
struct stat buf;
|
||||
security_context_t fcon = NULL;
|
||||
virSecurityLabelDefPtr secdef;
|
||||
- char *str = NULL;
|
||||
+ char *str = NULL, *proc = NULL, *fd_path = NULL;
|
||||
int rc = -1;
|
||||
|
||||
secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_SELINUX_NAME);
|
||||
@@ -2370,7 +2370,24 @@ virSecuritySELinuxSetTapFDLabel(virSecurityManagerPtr mgr,
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
- if (getContext(mgr, "/dev/tap.*", buf.st_mode, &fcon) < 0) {
|
||||
+ /* Label /dev/tap.* devices only. Leave /dev/net/tun alone! */
|
||||
+ if (virAsprintf(&proc, "/proc/self/fd/%d", fd) == -1)
|
||||
+ goto cleanup;
|
||||
+
|
||||
+ if (virFileResolveLink(proc, &fd_path) < 0) {
|
||||
+ virReportSystemError(errno,
|
||||
+ _("Unable to resolve link: %s"), proc);
|
||||
+ goto cleanup;
|
||||
+ }
|
||||
+
|
||||
+ if (!STRPREFIX(fd_path, "/dev/tap")) {
|
||||
+ VIR_DEBUG("fd=%d points to %s not setting SELinux label",
|
||||
+ fd, fd_path);
|
||||
+ rc = 0;
|
||||
+ goto cleanup;
|
||||
+ }
|
||||
+
|
||||
+ if (getContext(mgr, "/dev/tap*", buf.st_mode, &fcon) < 0) {
|
||||
virReportError(VIR_ERR_INTERNAL_ERROR,
|
||||
_("cannot lookup default selinux label for tap fd %d"), fd);
|
||||
goto cleanup;
|
||||
@@ -2384,6 +2401,8 @@ virSecuritySELinuxSetTapFDLabel(virSecurityManagerPtr mgr,
|
||||
|
||||
cleanup:
|
||||
freecon(fcon);
|
||||
+ VIR_FREE(fd_path);
|
||||
+ VIR_FREE(proc);
|
||||
VIR_FREE(str);
|
||||
return rc;
|
||||
}
|
||||
@@ -1,53 +0,0 @@
|
||||
From cd1b72fdd821d1fb4d08198833ea782651760e01 Mon Sep 17 00:00:00 2001
|
||||
Message-Id: <cd1b72fdd821d1fb4d08198833ea782651760e01.1414680021.git.crobinso@redhat.com>
|
||||
From: Lubomir Rintel <lkundrak@v3.sk>
|
||||
Date: Thu, 16 Oct 2014 21:28:00 +0200
|
||||
Subject: [PATCH 4/5] qemu: x86_64 is good enough for i686
|
||||
|
||||
virt-manager on Fedora sets up i686 hosts with "/usr/bin/qemu-kvm" emulator,
|
||||
which in turn unconditionally execs qemu-system-x86_64 querying capabilities
|
||||
then fails:
|
||||
|
||||
Error launching details: invalid argument: architecture from emulator 'x86_64' doesn't match given architecture 'i686'
|
||||
|
||||
Traceback (most recent call last):
|
||||
File "/usr/share/virt-manager/virtManager/engine.py", line 748, in _show_vm_helper
|
||||
details = self._get_details_dialog(uri, vm.get_connkey())
|
||||
File "/usr/share/virt-manager/virtManager/engine.py", line 726, in _get_details_dialog
|
||||
obj = vmmDetails(conn.get_vm(connkey))
|
||||
File "/usr/share/virt-manager/virtManager/details.py", line 399, in __init__
|
||||
self.init_details()
|
||||
File "/usr/share/virt-manager/virtManager/details.py", line 784, in init_details
|
||||
domcaps = self.vm.get_domain_capabilities()
|
||||
File "/usr/share/virt-manager/virtManager/domain.py", line 518, in get_domain_capabilities
|
||||
self.get_xmlobj().os.machine, self.get_xmlobj().type)
|
||||
File "/usr/lib/python2.7/site-packages/libvirt.py", line 3492, in getDomainCapabilities
|
||||
if ret is None: raise libvirtError ('virConnectGetDomainCapabilities() failed', conn=self)
|
||||
libvirtError: invalid argument: architecture from emulator 'x86_64' doesn't match given architecture 'i686'
|
||||
|
||||
Journal:
|
||||
|
||||
Oct 16 21:08:26 goatlord.localdomain libvirtd[1530]: invalid argument: architecture from emulator 'x86_64' doesn't match given architecture 'i686'
|
||||
|
||||
(cherry picked from commit afe8f4200f6e80d2510731165dd2cdae741bd9fb)
|
||||
---
|
||||
src/qemu/qemu_driver.c | 3 ++-
|
||||
1 file changed, 2 insertions(+), 1 deletion(-)
|
||||
|
||||
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
|
||||
index e873d45..d379c1f 100644
|
||||
--- a/src/qemu/qemu_driver.c
|
||||
+++ b/src/qemu/qemu_driver.c
|
||||
@@ -17572,7 +17572,8 @@ qemuConnectGetDomainCapabilities(virConnectPtr conn,
|
||||
|
||||
arch_from_caps = virQEMUCapsGetArch(qemuCaps);
|
||||
|
||||
- if (arch_from_caps != arch) {
|
||||
+ if (arch_from_caps != arch &&
|
||||
+ (arch_from_caps != VIR_ARCH_X86_64 || arch != VIR_ARCH_I686)) {
|
||||
virReportError(VIR_ERR_INVALID_ARG,
|
||||
_("architecture from emulator '%s' doesn't "
|
||||
"match given architecture '%s'"),
|
||||
--
|
||||
2.1.0
|
||||
|
||||
@@ -1,50 +0,0 @@
|
||||
From f4d5340ba116befaa965e14537f42c2ead17d486 Mon Sep 17 00:00:00 2001
|
||||
Message-Id: <f4d5340ba116befaa965e14537f42c2ead17d486.1414680854.git.crobinso@redhat.com>
|
||||
From: Martin Kletzander <mkletzan@redhat.com>
|
||||
Date: Fri, 3 Oct 2014 18:27:01 +0200
|
||||
Subject: [PATCH] util: Prepare URI formatting for libxml2 >= 2.9.2
|
||||
|
||||
Since commit 8eb55d782a2b9afacc7938694891cc6fad7b42a5 libxml2 removes
|
||||
two slashes from the URI when there is no server part. This is fixed
|
||||
with beb7281055dbf0ed4d041022a67c6c5cfd126f25, but only if the calling
|
||||
application calls xmlSaveUri() on URI that xmlURIParse() parsed. And
|
||||
that is not the case in virURIFormat(). virURIFormat() accepts
|
||||
virURIPtr that can be created without parsing it and we do that when we
|
||||
format network storage paths for gluster for example. Even though
|
||||
virStorageSourceParseBackingURI() uses virURIParse(), it throws that data
|
||||
structure right away.
|
||||
|
||||
Since we want to format URIs as URIs and not absolute URIs or opaque
|
||||
URIs (see RFC 3986), we can specify that with a special hack thanks to
|
||||
commit beb7281055dbf0ed4d041022a67c6c5cfd126f25, by setting port to -1.
|
||||
|
||||
This fixes qemuxml2argvtest test where the disk-drive-network-gluster
|
||||
case was failing.
|
||||
|
||||
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
|
||||
(cherry picked from commit 8f17d0eaae7ee2fa3e214b79b188fc14ed5aa1eb)
|
||||
---
|
||||
src/util/viruri.c | 7 +++++++
|
||||
1 file changed, 7 insertions(+)
|
||||
|
||||
diff --git a/src/util/viruri.c b/src/util/viruri.c
|
||||
index 69e7649..23d86c5 100644
|
||||
--- a/src/util/viruri.c
|
||||
+++ b/src/util/viruri.c
|
||||
@@ -254,6 +254,13 @@ virURIFormat(virURIPtr uri)
|
||||
xmluri.server = tmpserver;
|
||||
}
|
||||
|
||||
+ /*
|
||||
+ * This helps libxml2 deal with the difference
|
||||
+ * between uri:/absolute/path and uri:///absolute/path.
|
||||
+ */
|
||||
+ if (!xmluri.server && !xmluri.port)
|
||||
+ xmluri.port = -1;
|
||||
+
|
||||
ret = (char *)xmlSaveUri(&xmluri);
|
||||
if (!ret) {
|
||||
virReportOOMError();
|
||||
--
|
||||
2.1.0
|
||||
|
||||
@@ -1,21 +0,0 @@
|
||||
# Makefile for source rpm: libvirt
|
||||
# $Id$
|
||||
NAME := libvirt
|
||||
SPECFILE = $(firstword $(wildcard *.spec))
|
||||
|
||||
define find-makefile-common
|
||||
for d in common ../common ../../common ; do if [ -f $$d/Makefile.common ] ; then if [ -f $$d/CVS/Root -a -w $$d/Makefile.common ] ; then cd $$d ; cvs -Q update ; fi ; echo "$$d/Makefile.common" ; break ; fi ; done
|
||||
endef
|
||||
|
||||
MAKEFILE_COMMON := $(shell $(find-makefile-common))
|
||||
|
||||
ifeq ($(MAKEFILE_COMMON),)
|
||||
# attempt a checkout
|
||||
define checkout-makefile-common
|
||||
test -f CVS/Root && { cvs -Q -d $$(cat CVS/Root) checkout common && echo "common/Makefile.common" ; } || { echo "ERROR: I can't figure out how to checkout the 'common' module." ; exit -1 ; } >&2
|
||||
endef
|
||||
|
||||
MAKEFILE_COMMON := $(shell $(checkout-makefile-common))
|
||||
endif
|
||||
|
||||
include $(MAKEFILE_COMMON)
|
||||
+2306
-2585
File diff suppressed because it is too large
Load Diff
Reference in New Issue
Block a user