package/linux-tools: perf: Fix _BIN_ARCH_EXCLUDE
support/scripts/check-bin-arch has an option -i to exclude a path (or many paths by using -i multiple times). This was implemented in commit01d90f0d09("spport/check-bin-arch: accept arbitrary per-package ignore paths"). Looking at this feature (which hasn't changed since being added), we can see that check-bin-arch automatically adds a trailing slash to all entries specified using -i. Thus, specifying a path to a file, e.g. "/usr/libexec/perf-core/tests/pe-file.exe" will cause check-bin-arch to add "/usr/libexec/perf-core/tests/pe-file.exe/" to the IGNORES array. When running the main loop, the file "/usr/libexec/perf-core/tests/pe-file.exe" will thus not be ignored, since it will not trigger a match the pattern that was added to the IGNORES array ("/usr/libexec/perf-core/tests/pe-file.exe/"). This means that the -i option in check-bin-arch only supports directories and not files. Fix the LINUX_TOOLS_BIN_ARCH_EXCLUDE in package/linux-tools/linux-tool-perf.mk.in to specify a directory, as the existing LINUX_TOOLS_BIN_ARCH_EXCLUDE can never have actually worked. Fixes:a7ad781626("package/linux-tools: Exclude checking PE binaries from perf test") Signed-off-by: Niklas Cassel <cassel@kernel.org> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Julien Olivain <ju.o@free.fr>
This commit is contained in:
committed by
Julien Olivain
parent
572197f6d9
commit
4d7292675a
@@ -180,8 +180,7 @@ define PERF_INSTALL_REMOVE_SCRIPTS
|
||||
endef
|
||||
|
||||
LINUX_TOOLS_BIN_ARCH_EXCLUDE += \
|
||||
/usr/libexec/perf-core/tests/pe-file.exe \
|
||||
/usr/libexec/perf-core/tests/pe-file.exe.debug
|
||||
/usr/libexec/perf-core/tests/
|
||||
endif
|
||||
|
||||
define PERF_INSTALL_TARGET_CMDS
|
||||
|
||||
Reference in New Issue
Block a user