selftests/damon: remove tests for DAMON debugfs interface

It's time to remove DAMON debugfs interface, which has deprecated long
before in February 2023.  Read the cover letter of this patch series for
more details.

Remove selftests for the interface, to prevent causing unnecessary test
failures.

Link: https://lkml.kernel.org/r/20250106191941.107070-6-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Alex Shi <alexs@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Hu Haowen <2023002089@link.tyut.edu.cn>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Rae Moar <rmoar@google.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Yanteng Si <si.yanteng@linux.dev>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
SeongJae Park
2025-01-25 20:22:29 -08:00
committed by Andrew Morton
parent ce1d750282
commit 859de14931
14 changed files with 1 additions and 387 deletions
-3
View File
@@ -1,6 +1,3 @@
# SPDX-License-Identifier: GPL-2.0-only
huge_count_read_write
debugfs_target_ids_read_before_terminate_race
debugfs_target_ids_pid_leak
access_memory
access_memory_even
+1 -10
View File
@@ -1,15 +1,11 @@
# SPDX-License-Identifier: GPL-2.0
# Makefile for damon selftests
TEST_GEN_FILES += huge_count_read_write
TEST_GEN_FILES += debugfs_target_ids_read_before_terminate_race
TEST_GEN_FILES += debugfs_target_ids_pid_leak
TEST_GEN_FILES += access_memory access_memory_even
TEST_FILES = _chk_dependency.sh _debugfs_common.sh _damon_sysfs.py
TEST_FILES = _chk_dependency.sh _damon_sysfs.py
# functionality tests
TEST_PROGS = debugfs_attrs.sh debugfs_schemes.sh debugfs_target_ids.sh
TEST_PROGS += sysfs.sh
TEST_PROGS += sysfs_update_schemes_tried_regions_wss_estimation.py
TEST_PROGS += damos_quota.py damos_quota_goal.py damos_apply_interval.py
@@ -17,11 +13,6 @@ TEST_PROGS += damos_tried_regions.py damon_nr_regions.py
TEST_PROGS += reclaim.sh lru_sort.sh
# regression tests (reproducers of previously found bugs)
TEST_PROGS += debugfs_empty_targets.sh debugfs_huge_count_read_write.sh
TEST_PROGS += debugfs_duplicate_context_creation.sh
TEST_PROGS += debugfs_rm_non_contexts.sh
TEST_PROGS += debugfs_target_ids_read_before_terminate_race.sh
TEST_PROGS += debugfs_target_ids_pid_leak.sh
TEST_PROGS += sysfs_update_removed_scheme_dir.sh
TEST_PROGS += sysfs_update_schemes_tried_regions_hang.py
@@ -1,17 +0,0 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
source _debugfs_common.sh
# Test attrs file
# ===============
file="$DBGFS/attrs"
orig_content=$(cat "$file")
test_write_succ "$file" "1 2 3 4 5" "$orig_content" "valid input"
test_write_fail "$file" "1 2 3 4" "$orig_content" "no enough fields"
test_write_fail "$file" "1 2 3 5 4" "$orig_content" \
"min_nr_regions > max_nr_regions"
test_content "$file" "$orig_content" "1 2 3 4 5" "successfully written"
echo "$orig_content" > "$file"
@@ -1,27 +0,0 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
source _debugfs_common.sh
# Test duplicated context creation
# ================================
if ! echo foo > "$DBGFS/mk_contexts"
then
echo "context creation failed"
exit 1
fi
if echo foo > "$DBGFS/mk_contexts" 2> /dev/null
then
echo "duplicate context creation success"
exit 1
fi
if ! echo foo > "$DBGFS/rm_contexts"
then
echo "context deletion failed"
exit 1
fi
exit 0
@@ -1,21 +0,0 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
source _debugfs_common.sh
# Test empty targets case
# =======================
orig_target_ids=$(cat "$DBGFS/target_ids")
echo "" > "$DBGFS/target_ids"
if [ -f "$DBGFS/monitor_on_DEPRECATED" ]
then
monitor_on_file="$DBGFS/monitor_on_DEPRECATED"
else
monitor_on_file="$DBGFS/monitor_on"
fi
orig_monitor_on=$(cat "$monitor_on_file")
test_write_fail "$monitor_on_file" "on" "orig_monitor_on" "empty target ids"
echo "$orig_target_ids" > "$DBGFS/target_ids"
@@ -1,22 +0,0 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
source _debugfs_common.sh
# Test huge count read write
# ==========================
dmesg -C
for file in "$DBGFS/"*
do
./huge_count_read_write "$file"
done
if dmesg | grep -q WARNING
then
dmesg
exit 1
else
exit 0
fi
@@ -1,19 +0,0 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
source _debugfs_common.sh
# Test putting non-ctx files/dirs to rm_contexts file
# ===================================================
dmesg -C
for file in "$DBGFS/"*
do
(echo "$(basename "$f")" > "$DBGFS/rm_contexts") &> /dev/null
if dmesg | grep -q BUG
then
dmesg
exit 1
fi
done
@@ -1,19 +0,0 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
source _debugfs_common.sh
# Test schemes file
# =================
file="$DBGFS/schemes"
orig_content=$(cat "$file")
test_write_succ "$file" "1 2 3 4 5 6 4 0 0 0 1 2 3 1 100 3 2 1" \
"$orig_content" "valid input"
test_write_fail "$file" "1 2
3 4 5 6 3 0 0 0 1 2 3 1 100 3 2 1" "$orig_content" "multi lines"
test_write_succ "$file" "" "$orig_content" "disabling"
test_write_fail "$file" "2 1 2 1 10 1 3 10 1 1 1 1 1 1 1 1 2 3" \
"$orig_content" "wrong condition ranges"
echo "$orig_content" > "$file"
@@ -1,19 +0,0 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
source _debugfs_common.sh
# Test target_ids file
# ====================
file="$DBGFS/target_ids"
orig_content=$(cat "$file")
test_write_succ "$file" "1 2 3 4" "$orig_content" "valid input"
test_write_succ "$file" "1 2 abc 4" "$orig_content" "still valid input"
test_content "$file" "$orig_content" "1 2" "non-integer was there"
test_write_succ "$file" "abc 2 3" "$orig_content" "the file allows wrong input"
test_content "$file" "$orig_content" "" "wrong input written"
test_write_succ "$file" "" "$orig_content" "empty input"
test_content "$file" "$orig_content" "" "empty input written"
echo "$orig_content" > "$file"
@@ -1,68 +0,0 @@
// SPDX-License-Identifier: GPL-2.0
/*
* Author: SeongJae Park <sj@kernel.org>
*/
#define _GNU_SOURCE
#include <fcntl.h>
#include <stdbool.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <sys/time.h>
#include <unistd.h>
#define DBGFS_TARGET_IDS "/sys/kernel/debug/damon/target_ids"
static void write_targetid_exit(void)
{
int target_ids_fd = open(DBGFS_TARGET_IDS, O_RDWR);
char pid_str[128];
snprintf(pid_str, sizeof(pid_str), "%d", getpid());
write(target_ids_fd, pid_str, sizeof(pid_str));
close(target_ids_fd);
exit(0);
}
unsigned long msec_timestamp(void)
{
struct timeval tv;
gettimeofday(&tv, NULL);
return tv.tv_sec * 1000UL + tv.tv_usec / 1000;
}
int main(int argc, char *argv[])
{
unsigned long start_ms;
int time_to_run, nr_forks = 0;
if (argc != 2) {
fprintf(stderr, "Usage: %s <msecs to run>\n", argv[0]);
exit(1);
}
time_to_run = atoi(argv[1]);
start_ms = msec_timestamp();
while (true) {
int pid = fork();
if (pid < 0) {
fprintf(stderr, "fork() failed\n");
exit(1);
}
if (pid == 0)
write_targetid_exit();
wait(NULL);
nr_forks++;
if (msec_timestamp() - start_ms > time_to_run)
break;
}
printf("%d\n", nr_forks);
return 0;
}
@@ -1,22 +0,0 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
before=$(grep "^pid " /proc/slabinfo | awk '{print $2}')
nr_leaks=$(./debugfs_target_ids_pid_leak 1000)
expected_after_max=$((before + nr_leaks / 2))
after=$(grep "^pid " /proc/slabinfo | awk '{print $2}')
echo > /sys/kernel/debug/damon/target_ids
echo "tried $nr_leaks pid leak"
echo "number of active pid slabs: $before -> $after"
echo "(up to $expected_after_max expected)"
if [ $after -gt $expected_after_max ]
then
echo "maybe pids are leaking"
exit 1
else
exit 0
fi
@@ -1,80 +0,0 @@
// SPDX-License-Identifier: GPL-2.0
/*
* Author: SeongJae Park <sj@kernel.org>
*/
#define _GNU_SOURCE
#include <fcntl.h>
#include <stdbool.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <time.h>
#include <unistd.h>
#define DBGFS_MONITOR_ON "/sys/kernel/debug/damon/monitor_on_DEPRECATED"
#define DBGFS_TARGET_IDS "/sys/kernel/debug/damon/target_ids"
static void turn_damon_on_exit(void)
{
int target_ids_fd = open(DBGFS_TARGET_IDS, O_RDWR);
int monitor_on_fd = open(DBGFS_MONITOR_ON, O_RDWR);
char pid_str[128];
snprintf(pid_str, sizeof(pid_str), "%d", getpid());
write(target_ids_fd, pid_str, sizeof(pid_str));
write(monitor_on_fd, "on\n", 3);
close(target_ids_fd);
close(monitor_on_fd);
usleep(1000);
exit(0);
}
static void try_race(void)
{
int target_ids_fd = open(DBGFS_TARGET_IDS, O_RDWR);
int pid = fork();
int buf[256];
if (pid < 0) {
fprintf(stderr, "fork() failed\n");
exit(1);
}
if (pid == 0)
turn_damon_on_exit();
while (true) {
int status;
read(target_ids_fd, buf, sizeof(buf));
if (waitpid(-1, &status, WNOHANG) == pid)
break;
}
close(target_ids_fd);
}
static inline uint64_t ts_to_ms(struct timespec *ts)
{
return (uint64_t)ts->tv_sec * 1000 + (uint64_t)ts->tv_nsec / 1000000;
}
int main(int argc, char *argv[])
{
struct timespec start_time, now;
int runtime_ms;
if (argc != 2) {
fprintf(stderr, "Usage: %s <runtime in ms>\n", argv[0]);
exit(1);
}
runtime_ms = atoi(argv[1]);
clock_gettime(CLOCK_MONOTONIC, &start_time);
while (true) {
try_race();
clock_gettime(CLOCK_MONOTONIC, &now);
if (ts_to_ms(&now) - ts_to_ms(&start_time) > runtime_ms)
break;
}
return 0;
}
@@ -1,14 +0,0 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
dmesg -C
./debugfs_target_ids_read_before_terminate_race 5000
if dmesg | grep -q dbgfs_target_ids_read
then
dmesg
exit 1
else
exit 0
fi
@@ -1,46 +0,0 @@
// SPDX-License-Identifier: GPL-2.0
/*
* Author: SeongJae Park <sj@kernel.org>
*/
#include <fcntl.h>
#include <stdlib.h>
#include <unistd.h>
#include <stdio.h>
#pragma GCC diagnostic push
#if __GNUC__ >= 11 && __GNUC_MINOR__ >= 1
/* Ignore read(2) overflow and write(2) overread compile warnings */
#pragma GCC diagnostic ignored "-Wstringop-overread"
#pragma GCC diagnostic ignored "-Wstringop-overflow"
#endif
void write_read_with_huge_count(char *file)
{
int filedesc = open(file, O_RDWR);
char buf[256];
int ret;
printf("%s %s\n", __func__, file);
if (filedesc < 0) {
fprintf(stderr, "failed opening %s\n", file);
exit(1);
}
write(filedesc, "", 0xfffffffful);
ret = read(filedesc, buf, 0xfffffffful);
close(filedesc);
}
#pragma GCC diagnostic pop
int main(int argc, char *argv[])
{
if (argc != 2) {
fprintf(stderr, "Usage: %s <file>\n", argv[0]);
exit(1);
}
write_read_with_huge_count(argv[1]);
return 0;
}