net: disallow setup single buffer XDP when tcp-data-split is enabled.
When a single buffer XDP is attached, NIC should guarantee only single page packets will be received. tcp-data-split feature splits packets into header and payload. single buffer XDP can't handle it properly. So attaching single buffer XDP should be disallowed when tcp-data-split is enabled. Acked-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Taehee Yoo <ap420073@gmail.com> Link: https://patch.msgid.link/20250114142852.3364986-6-ap420073@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
committed by
Jakub Kicinski
parent
e61779015c
commit
2d46e481a9
@@ -92,6 +92,7 @@
|
||||
#include <linux/netdevice.h>
|
||||
#include <linux/etherdevice.h>
|
||||
#include <linux/ethtool.h>
|
||||
#include <linux/ethtool_netlink.h>
|
||||
#include <linux/skbuff.h>
|
||||
#include <linux/kthread.h>
|
||||
#include <linux/bpf.h>
|
||||
@@ -9567,6 +9568,14 @@ int dev_xdp_propagate(struct net_device *dev, struct netdev_bpf *bpf)
|
||||
if (!dev->netdev_ops->ndo_bpf)
|
||||
return -EOPNOTSUPP;
|
||||
|
||||
if (dev->ethtool->hds_config == ETHTOOL_TCP_DATA_SPLIT_ENABLED &&
|
||||
bpf->command == XDP_SETUP_PROG &&
|
||||
bpf->prog && !bpf->prog->aux->xdp_has_frags) {
|
||||
NL_SET_ERR_MSG(bpf->extack,
|
||||
"unable to propagate XDP to device using tcp-data-split");
|
||||
return -EBUSY;
|
||||
}
|
||||
|
||||
if (dev_get_min_mp_channel_count(dev)) {
|
||||
NL_SET_ERR_MSG(bpf->extack, "unable to propagate XDP to device using memory provider");
|
||||
return -EBUSY;
|
||||
@@ -9604,6 +9613,12 @@ static int dev_xdp_install(struct net_device *dev, enum bpf_xdp_mode mode,
|
||||
struct netdev_bpf xdp;
|
||||
int err;
|
||||
|
||||
if (dev->ethtool->hds_config == ETHTOOL_TCP_DATA_SPLIT_ENABLED &&
|
||||
prog && !prog->aux->xdp_has_frags) {
|
||||
NL_SET_ERR_MSG(extack, "unable to install XDP to device using tcp-data-split");
|
||||
return -EBUSY;
|
||||
}
|
||||
|
||||
if (dev_get_min_mp_channel_count(dev)) {
|
||||
NL_SET_ERR_MSG(extack, "unable to install XDP to device using memory provider");
|
||||
return -EBUSY;
|
||||
|
||||
Reference in New Issue
Block a user