scsi: hisi_sas: use DEFINE_SHOW_STORE_ATTRIBUTE() helper for debugfs
Use DEFINE_SHOW_STORE_ATTRIBUTE() helper for read-write file to reduce some duplicated code. Link: https://lkml.kernel.org/r/20230905024835.43219-3-yangxingui@huawei.com Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com> Co-developed-by: Xingui Yang <yangxingui@huawei.com> Signed-off-by: Xingui Yang <yangxingui@huawei.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Animesh Manna <animesh.manna@intel.com> Cc: Anshuman Gupta <anshuman.gupta@intel.com> Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com> Cc: Felipe Balbi <felipe.balbi@linux.intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Himanshu Madhani <himanshu.madhani@cavium.com> Cc: James Bottomley <jejb@linux.ibm.com> Cc: John Garry <john.g.garry@oracle.com> Cc: Martin K. Petersen <martin.petersen@oracle.com> Cc: Uma Shankar <uma.shankar@intel.com> Cc: Xiang Chen <chenxiang66@hisilicon.com> Cc: Zeng Tao <prime.zeng@hisilicon.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
committed by
Andrew Morton
parent
9cba82bba5
commit
00c9d55f57
@@ -3990,22 +3990,7 @@ static ssize_t debugfs_bist_linkrate_v3_hw_write(struct file *filp,
|
||||
|
||||
return count;
|
||||
}
|
||||
|
||||
static int debugfs_bist_linkrate_v3_hw_open(struct inode *inode,
|
||||
struct file *filp)
|
||||
{
|
||||
return single_open(filp, debugfs_bist_linkrate_v3_hw_show,
|
||||
inode->i_private);
|
||||
}
|
||||
|
||||
static const struct file_operations debugfs_bist_linkrate_v3_hw_fops = {
|
||||
.open = debugfs_bist_linkrate_v3_hw_open,
|
||||
.read = seq_read,
|
||||
.write = debugfs_bist_linkrate_v3_hw_write,
|
||||
.llseek = seq_lseek,
|
||||
.release = single_release,
|
||||
.owner = THIS_MODULE,
|
||||
};
|
||||
DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_linkrate_v3_hw);
|
||||
|
||||
static const struct {
|
||||
int value;
|
||||
@@ -4080,22 +4065,7 @@ static ssize_t debugfs_bist_code_mode_v3_hw_write(struct file *filp,
|
||||
|
||||
return count;
|
||||
}
|
||||
|
||||
static int debugfs_bist_code_mode_v3_hw_open(struct inode *inode,
|
||||
struct file *filp)
|
||||
{
|
||||
return single_open(filp, debugfs_bist_code_mode_v3_hw_show,
|
||||
inode->i_private);
|
||||
}
|
||||
|
||||
static const struct file_operations debugfs_bist_code_mode_v3_hw_fops = {
|
||||
.open = debugfs_bist_code_mode_v3_hw_open,
|
||||
.read = seq_read,
|
||||
.write = debugfs_bist_code_mode_v3_hw_write,
|
||||
.llseek = seq_lseek,
|
||||
.release = single_release,
|
||||
.owner = THIS_MODULE,
|
||||
};
|
||||
DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_code_mode_v3_hw);
|
||||
|
||||
static ssize_t debugfs_bist_phy_v3_hw_write(struct file *filp,
|
||||
const char __user *buf,
|
||||
@@ -4129,22 +4099,7 @@ static int debugfs_bist_phy_v3_hw_show(struct seq_file *s, void *p)
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int debugfs_bist_phy_v3_hw_open(struct inode *inode,
|
||||
struct file *filp)
|
||||
{
|
||||
return single_open(filp, debugfs_bist_phy_v3_hw_show,
|
||||
inode->i_private);
|
||||
}
|
||||
|
||||
static const struct file_operations debugfs_bist_phy_v3_hw_fops = {
|
||||
.open = debugfs_bist_phy_v3_hw_open,
|
||||
.read = seq_read,
|
||||
.write = debugfs_bist_phy_v3_hw_write,
|
||||
.llseek = seq_lseek,
|
||||
.release = single_release,
|
||||
.owner = THIS_MODULE,
|
||||
};
|
||||
DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_phy_v3_hw);
|
||||
|
||||
static ssize_t debugfs_bist_cnt_v3_hw_write(struct file *filp,
|
||||
const char __user *buf,
|
||||
@@ -4177,22 +4132,7 @@ static int debugfs_bist_cnt_v3_hw_show(struct seq_file *s, void *p)
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int debugfs_bist_cnt_v3_hw_open(struct inode *inode,
|
||||
struct file *filp)
|
||||
{
|
||||
return single_open(filp, debugfs_bist_cnt_v3_hw_show,
|
||||
inode->i_private);
|
||||
}
|
||||
|
||||
static const struct file_operations debugfs_bist_cnt_v3_hw_ops = {
|
||||
.open = debugfs_bist_cnt_v3_hw_open,
|
||||
.read = seq_read,
|
||||
.write = debugfs_bist_cnt_v3_hw_write,
|
||||
.llseek = seq_lseek,
|
||||
.release = single_release,
|
||||
.owner = THIS_MODULE,
|
||||
};
|
||||
DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_cnt_v3_hw);
|
||||
|
||||
static const struct {
|
||||
int value;
|
||||
@@ -4256,22 +4196,7 @@ static ssize_t debugfs_bist_mode_v3_hw_write(struct file *filp,
|
||||
|
||||
return count;
|
||||
}
|
||||
|
||||
static int debugfs_bist_mode_v3_hw_open(struct inode *inode,
|
||||
struct file *filp)
|
||||
{
|
||||
return single_open(filp, debugfs_bist_mode_v3_hw_show,
|
||||
inode->i_private);
|
||||
}
|
||||
|
||||
static const struct file_operations debugfs_bist_mode_v3_hw_fops = {
|
||||
.open = debugfs_bist_mode_v3_hw_open,
|
||||
.read = seq_read,
|
||||
.write = debugfs_bist_mode_v3_hw_write,
|
||||
.llseek = seq_lseek,
|
||||
.release = single_release,
|
||||
.owner = THIS_MODULE,
|
||||
};
|
||||
DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_mode_v3_hw);
|
||||
|
||||
static ssize_t debugfs_bist_enable_v3_hw_write(struct file *filp,
|
||||
const char __user *buf,
|
||||
@@ -4309,22 +4234,7 @@ static int debugfs_bist_enable_v3_hw_show(struct seq_file *s, void *p)
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int debugfs_bist_enable_v3_hw_open(struct inode *inode,
|
||||
struct file *filp)
|
||||
{
|
||||
return single_open(filp, debugfs_bist_enable_v3_hw_show,
|
||||
inode->i_private);
|
||||
}
|
||||
|
||||
static const struct file_operations debugfs_bist_enable_v3_hw_fops = {
|
||||
.open = debugfs_bist_enable_v3_hw_open,
|
||||
.read = seq_read,
|
||||
.write = debugfs_bist_enable_v3_hw_write,
|
||||
.llseek = seq_lseek,
|
||||
.release = single_release,
|
||||
.owner = THIS_MODULE,
|
||||
};
|
||||
DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_enable_v3_hw);
|
||||
|
||||
static const struct {
|
||||
char *name;
|
||||
@@ -4362,21 +4272,7 @@ static int debugfs_v3_hw_show(struct seq_file *s, void *p)
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int debugfs_v3_hw_open(struct inode *inode, struct file *filp)
|
||||
{
|
||||
return single_open(filp, debugfs_v3_hw_show,
|
||||
inode->i_private);
|
||||
}
|
||||
|
||||
static const struct file_operations debugfs_v3_hw_fops = {
|
||||
.open = debugfs_v3_hw_open,
|
||||
.read = seq_read,
|
||||
.write = debugfs_v3_hw_write,
|
||||
.llseek = seq_lseek,
|
||||
.release = single_release,
|
||||
.owner = THIS_MODULE,
|
||||
};
|
||||
DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_v3_hw);
|
||||
|
||||
static ssize_t debugfs_phy_down_cnt_v3_hw_write(struct file *filp,
|
||||
const char __user *buf,
|
||||
@@ -4407,22 +4303,7 @@ static int debugfs_phy_down_cnt_v3_hw_show(struct seq_file *s, void *p)
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int debugfs_phy_down_cnt_v3_hw_open(struct inode *inode,
|
||||
struct file *filp)
|
||||
{
|
||||
return single_open(filp, debugfs_phy_down_cnt_v3_hw_show,
|
||||
inode->i_private);
|
||||
}
|
||||
|
||||
static const struct file_operations debugfs_phy_down_cnt_v3_hw_fops = {
|
||||
.open = debugfs_phy_down_cnt_v3_hw_open,
|
||||
.read = seq_read,
|
||||
.write = debugfs_phy_down_cnt_v3_hw_write,
|
||||
.llseek = seq_lseek,
|
||||
.release = single_release,
|
||||
.owner = THIS_MODULE,
|
||||
};
|
||||
DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_phy_down_cnt_v3_hw);
|
||||
|
||||
enum fifo_dump_mode_v3_hw {
|
||||
FIFO_DUMP_FORVER = (1U << 0),
|
||||
@@ -4832,7 +4713,7 @@ static void debugfs_bist_init_v3_hw(struct hisi_hba *hisi_hba)
|
||||
hisi_hba, &debugfs_bist_phy_v3_hw_fops);
|
||||
|
||||
debugfs_create_file("cnt", 0600, hisi_hba->debugfs_bist_dentry,
|
||||
hisi_hba, &debugfs_bist_cnt_v3_hw_ops);
|
||||
hisi_hba, &debugfs_bist_cnt_v3_hw_fops);
|
||||
|
||||
debugfs_create_file("loopback_mode", 0600,
|
||||
hisi_hba->debugfs_bist_dentry,
|
||||
|
||||
Reference in New Issue
Block a user