mirror of
https://github.com/clearlinux/systemd-stable.git
synced 2026-11-19 03:33:55 +00:00
core: fix invalid free() in killall()
static int killall(....) in ./src/core/killall.c tries to get "s"
initialized by calling get_process_comm(...) which calls
read_one_line_file(...) which if it fails will mean it is left
uninitialized.
It is then used in argument to strna(s) call where it is
dereferenced(!), in addition to nothing else initializing it before
the scope it is in finishes.
(cherry picked from commit 3e09eb5c83)
This commit is contained in:
committed by
Zbigniew Jędrzejewski-Szmek
parent
89053aff0c
commit
3f4dbb254a
+1
-1
@@ -168,7 +168,7 @@ static int killall(int sig, Set *pids, bool send_sighup) {
|
||||
continue;
|
||||
|
||||
if (sig == SIGKILL) {
|
||||
_cleanup_free_ char *s;
|
||||
_cleanup_free_ char *s = NULL;
|
||||
|
||||
get_process_comm(pid, &s);
|
||||
log_notice("Sending SIGKILL to PID "PID_FMT" (%s).", pid, strna(s));
|
||||
|
||||
Reference in New Issue
Block a user