clearlinux/kvmtool
2
0
Fork 0
mirror of https://github.com/clearlinux/kvmtool.git synced 2026-08-23 22:46:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

kvm tools: Fix build of util.c on 32bit machines

Browse Source 
commit 378ee7e6dd301347c6bf2c740cb1fb40174bcb8b broke the -Werror build
on 32bit targets due to some variable typing in struct statfs:

On 14/12/11 11:03, David Evensky wrote:
> On an x86 32bit system (and using the 32bit CodeSourcery toolchain on
> a x86_64 system) I get:
>
> evensky@machine:~/.../linux-kvm/tools/kvm$ make
>   CC       util/util.o
> util/util.c: In function 'mmap_hugetlbfs':
> util/util.c:93:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
> util/util.c:99:7: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'int' [-Werror=format]
> cc1: all warnings being treated as errors
>
> make: *** [util/util.o] Error 1

Fixes the build.

Reported-by: David Evensky <evensky@dancer.ca.sandia.gov>
Signed-off-by: Matt Evans <matt@ozlabs.org>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
This commit is contained in:
Matt Evans
2011-12-14 12:10:03 +11:00
committed by Will Deacon
parent 17edd536d5
commit 78682c285b
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
util/util.c
+5 -3
View File
@@ -86,17 +86,19 @@ void *mmap_hugetlbfs(const char *htlbfs_path, u64 size)
int fd;
struct statfs sfs;
void *addr;
unsigned long blk_size;
if (statfs(htlbfs_path, &sfs) < 0)
die("Can't stat %s\n", htlbfs_path);
if (sfs.f_type != HUGETLBFS_MAGIC) {
if ((unsigned int)sfs.f_type != HUGETLBFS_MAGIC) {
die("%s is not hugetlbfs!\n", htlbfs_path);
}
if (sfs.f_bsize == 0 || (unsigned long)sfs.f_bsize > size) {
blk_size = (unsigned long)sfs.f_bsize;
if (sfs.f_bsize == 0 || blk_size > size) {
die("Can't use hugetlbfs pagesize %ld for mem size %lld\n",
sfs.f_bsize, size);
blk_size, size);
}
snprintf(mpath, PATH_MAX, "%s/kvmtoolXXXXXX", htlbfs_path);