clearlinux/graphene
2
0
Fork 0
mirror of https://github.com/clearlinux/graphene.git synced 2026-08-22 05:56:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

[LibOS] clone shouldn't expose child thread until its init

Browse Source 
The final initialization of child thread of clone is done by
clone_implementation_wrapper(). Until the initialization completes,
child shim_thread shouldn't be exposed to other thread.
Otherwise other thread can access uninitialized shim_thread.
For example, other thread tries to send signal to that thread by
walking thread_list and access uninitialized member of shim_thread.
Defer add_thread() until initialization is complete.

Signed-off-by: Isaku Yamahata <isaku.yamahata@gmail.com>
This commit is contained in:
Isaku Yamahata
2019-01-31 18:31:06 -08:00
committed by Don Porter
parent 8d3569dabc
commit 9ea009ab6f
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
LibOS/shim/src/sys/shim_clone.c
+4 -2
View File
@@ -129,6 +129,10 @@ int clone_implementation_wrapper(struct clone_args * arg)
my_thread->stack_top = vma.addr + vma.length;
my_thread->stack_red = my_thread->stack = vma.addr;
/* until now we're not ready to be exposed to other thread */
add_thread(my_thread);
set_as_child(arg->parent, my_thread);
/* Don't signal the initialize event until we are actually init-ed */
DkEventSet(pcargs->initialize_event);
@@ -324,8 +328,6 @@ int shim_do_clone (int flags, void * user_stack_addr, int * parent_tidptr,
thread->pal_handle = pal_handle;
thread->in_vm = thread->is_alive = true;
add_thread(thread);
set_as_child(self, thread);
if (set_parent_tid)
*set_parent_tid = tid;