HeliC829/golang-oerv-backport
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[release-branch.go1.24] cmd/go: initialize req.Header when loading git credential

Browse Source 
Fixes #71687

Change-Id: I3d733a50b4451dfb571aba91a28387ba9e0614dc
Reviewed-on: https://go-review.googlesource.com/c/go/+/647615
Reviewed-by: Michael Matloob <matloob@golang.org>
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit 58834c3ee0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/648936
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
This commit is contained in:
Quan Tong
2025-02-07 18:42:26 +07:00
committed by Gopher Robot
parent 3901409b5d
commit 80e2e474b8
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/cmd/go/internal/auth/auth.go
View File

@@ -128,7 +128,8 @@ func runGoAuth(client *http.Client, res *http.Response, url string) {
// If no GOAUTH command provided a credential for the given url
// and an error occurred, log the error.
if cfg.BuildX && url != "" {
if ok := loadCredential(&http.Request{}, url); !ok && len(cmdErrs) > 0 {
req := &http.Request{Header: make(http.Header)}
if ok := loadCredential(req, url); !ok && len(cmdErrs) > 0 {
log.Printf("GOAUTH encountered errors for %s:", url)
for _, err := range cmdErrs {
log.Printf(" %v", err)

2
src/cmd/go/testdata/script/goauth_git.txt vendored
View File

@@ -49,6 +49,8 @@ go get vcs-test.golang.org/auth/or401
go mod tidy
go list all
stdout vcs-test.golang.org/auth/or404
# With cached credentials, re-downloading in debug mode should succeed.
go get -x vcs-test.golang.org/auth/or401
# Clearing GOAUTH credentials should result in failures.
env GOAUTH='off'