Files
linux/drivers/gpu/drm
Tom Rix cdd296cdae drm/gma500: fix error check
Reviewing this block of code in cdv_intel_dp_init()

ret = cdv_intel_dp_aux_native_read(gma_encoder, DP_DPCD_REV, ...

cdv_intel_edp_panel_vdd_off(gma_encoder);
if (ret == 0) {
	/* if this fails, presume the device is a ghost */
	DRM_INFO("failed to retrieve link info, disabling eDP\n");
	drm_encoder_cleanup(encoder);
	cdv_intel_dp_destroy(connector);
	goto err_priv;
} else {

The (ret == 0) is not strict enough.
cdv_intel_dp_aux_native_read() returns > 0 on success
otherwise it is failure.

So change to <=

Fixes: d112a8163f ("gma500/cdv: Add eDP support")

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200805205911.20927-1-trix@redhat.com
2020-08-19 15:49:10 +02:00
..
2020-08-18 14:14:25 +02:00
2020-07-24 08:48:05 +10:00
2020-08-11 11:58:31 +10:00
2020-08-18 14:14:25 +02:00
2020-08-18 14:14:25 +02:00
2020-08-19 15:49:10 +02:00
2020-08-18 14:14:25 +02:00
2020-08-12 20:42:08 +02:00
…
2020-08-11 11:58:31 +10:00
2020-07-24 08:48:05 +10:00
…
2020-08-18 14:14:25 +02:00
2020-07-28 17:21:58 +02:00
2020-08-18 14:14:25 +02:00
2020-08-18 22:32:37 +02:00
2020-07-23 10:06:22 +02:00
2020-08-18 14:14:25 +02:00
2020-04-03 17:11:41 +02:00
…
2020-08-18 14:14:25 +02:00
2020-08-18 10:49:13 +02:00
…
2020-06-24 09:17:34 +02:00
2020-08-12 20:42:08 +02:00
2020-05-27 14:31:42 +03:00
2020-04-03 17:11:41 +02:00
2020-07-27 22:06:13 +02:00
…
2020-08-11 11:58:31 +10:00
2020-07-16 18:16:31 -04:00
2020-05-29 12:58:11 +02:00
2020-08-11 11:58:31 +10:00
2020-08-11 11:58:31 +10:00