From 94bb9a8dc537a22d32dc84041fb6459555cc8652 Mon Sep 17 00:00:00 2001 From: Athenas Jimenez Date: Wed, 30 Oct 2019 18:41:22 +0000 Subject: [PATCH] Initial commit Signed-off-by: Athenas Jimenez --- COPYING.Apache-2.0 | 202 +++++++++++++++++++++++++++++++++++++++++++++ Makefile.am | 18 ++++ autogen.sh | 14 ++++ coding-style.txt | 67 +++++++++++++++ configure.ac | 50 +++++++++++ findstatic.pl | 75 +++++++++++++++++ src/filedesc.c | 75 +++++++++++++++++ src/main.c | 47 +++++++++++ template | 39 +++++++++ 9 files changed, 587 insertions(+) create mode 100644 COPYING.Apache-2.0 create mode 100644 Makefile.am create mode 100755 autogen.sh create mode 100644 coding-style.txt create mode 100644 configure.ac create mode 100644 findstatic.pl create mode 100644 src/filedesc.c create mode 100644 src/main.c create mode 100644 template diff --git a/COPYING.Apache-2.0 b/COPYING.Apache-2.0 new file mode 100644 index 0000000..d645695 --- /dev/null +++ b/COPYING.Apache-2.0 @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 + http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by combination of their Contribution(s) + with the Work to which such Contribution(s) was submitted. If You + institute patent litigation against any entity (including a + cross-claim or counterclaim in a lawsuit) alleging that the Work + or a Contribution incorporated within the Work constitutes direct + or contributory patent infringement, then any patent licenses + granted to You under this License for that Work shall terminate + as of the date such litigation is filed. + + 4. Redistribution. You may reproduce and distribute copies of the + Work or Derivative Works thereof in any medium, with or without + modifications, and in Source or Object form, provided that You + meet the following conditions: + + (a) You must give any other recipients of the Work or + Derivative Works a copy of this License; and + + (b) You must cause any modified files to carry prominent notices + stating that You changed the files; and + + (c) You must retain, in the Source form of any Derivative Works + that You distribute, all copyright, patent, trademark, and + attribution notices from the Source form of the Work, + excluding those notices that do not pertain to any part of + the Derivative Works; and + + (d) If the Work includes a "NOTICE" text file as part of its + distribution, then any Derivative Works that You distribute must + include a readable copy of the attribution notices contained + within such NOTICE file, excluding those notices that do not + pertain to any part of the Derivative Works, in at least one + of the following places: within a NOTICE text file distributed + as part of the Derivative Works; within the Source form or + documentation, if provided along with the Derivative Works; or, + within a display generated by the Derivative Works, if and + wherever such third-party notices normally appear. The contents + of the NOTICE file are for informational purposes only and + do not modify the License. You may add Your own attribution + notices within Derivative Works that You distribute, alongside + or as an addendum to the NOTICE text from the Work, provided + that such additional attribution notices cannot be construed + as modifying the License. + + You may add Your own copyright statement to Your modifications and + may provide additional or different license terms and conditions + for use, reproduction, or distribution of Your modifications, or + for any such Derivative Works as a whole, provided Your use, + reproduction, and distribution of the Work otherwise complies with + the conditions stated in this License. + + 5. Submission of Contributions. Unless You explicitly state otherwise, + any Contribution intentionally submitted for inclusion in the Work + by You to the Licensor shall be under the terms and conditions of + this License, without any additional terms or conditions. + Notwithstanding the above, nothing herein shall supersede or modify + the terms of any separate license agreement you may have executed + with Licensor regarding such Contributions. + + 6. Trademarks. This License does not grant permission to use the trade + names, trademarks, service marks, or product names of the Licensor, + except as required for reasonable and customary use in describing the + origin of the Work and reproducing the content of the NOTICE file. + + 7. Disclaimer of Warranty. Unless required by applicable law or + agreed to in writing, Licensor provides the Work (and each + Contributor provides its Contributions) on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + implied, including, without limitation, any warranties or conditions + of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A + PARTICULAR PURPOSE. You are solely responsible for determining the + appropriateness of using or redistributing the Work and assume any + risks associated with Your exercise of permissions under this License. + + 8. Limitation of Liability. In no event and under no legal theory, + whether in tort (including negligence), contract, or otherwise, + unless required by applicable law (such as deliberate and grossly + negligent acts) or agreed to in writing, shall any Contributor be + liable to You for damages, including any direct, indirect, special, + incidental, or consequential damages of any character arising as a + result of this License or out of the use or inability to use the + Work (including but not limited to damages for loss of goodwill, + work stoppage, computer failure or malfunction, or any and all + other commercial damages or losses), even if such Contributor + has been advised of the possibility of such damages. + + 9. Accepting Warranty or Additional Liability. While redistributing + the Work or Derivative Works thereof, You may choose to offer, + and charge a fee for, acceptance of support, warranty, indemnity, + or other liability obligations and/or rights consistent with this + License. However, in accepting such obligations, You may act only + on Your own behalf and on Your sole responsibility, not on behalf + of any other Contributor, and only if You agree to indemnify, + defend, and hold each Contributor harmless for any liability + incurred by, or claims asserted against, such Contributor by reason + of your accepting any such warranty or additional liability. + + END OF TERMS AND CONDITIONS + + APPENDIX: How to apply the Apache License to your work. + + To apply the Apache License to your work, attach the following + boilerplate notice, with the fields enclosed by brackets "[]" + replaced with your own identifying information. (Don't include + the brackets!) The text should be enclosed in the appropriate + comment syntax for the file format. We also recommend that a + file or class name and description of purpose be included on the + same "printed page" as the copyright notice for easier + identification within third-party archives. + + Copyright [yyyy] [name of copyright owner] + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. diff --git a/Makefile.am b/Makefile.am new file mode 100644 index 0000000..297adbd --- /dev/null +++ b/Makefile.am @@ -0,0 +1,18 @@ +EXTRA_DIST = COPYING.Apache-2.0 findstatic.pl + +AM_CFLAGS = -g -Wall -W -Wformat-security -D_FORTIFY_SOURCE=2 -fno-common + +bin_PROGRAMS = \ + java + +java_SOURCES = \ + src/main.c \ + src/filedesc.c + +distclean-local: + rm -rf aclocal.m4 ar-lib autom4te.cache config.guess config.h.in config.h.in~ config.sub configure depcomp install-sh ltmain.sh m4 Makefile.in missing compile + + +install-exec-hook: + perl ${top_srcdir}/findstatic.pl ${top_builddir}/src/*.o | grep -v Checking ||: + diff --git a/autogen.sh b/autogen.sh new file mode 100755 index 0000000..2485332 --- /dev/null +++ b/autogen.sh @@ -0,0 +1,14 @@ +#!/bin/sh + +set -e + +autoreconf --force --install --symlink --warnings=all + +args="\ +--sysconfdir=/etc \ +--localstatedir=/var \ +--prefix=/usr \ +--enable-silent-rules" + +./configure CFLAGS="-g -O1 $CFLAGS" $args "$@" +make clean diff --git a/coding-style.txt b/coding-style.txt new file mode 100644 index 0000000..dbb5fb3 --- /dev/null +++ b/coding-style.txt @@ -0,0 +1,67 @@ +The formatting part of the coding style is easy; we follow the linux kernel +style with one key exception: + +if/else statements ALWAYS have {}'s, even if there is only 1 statement. +So + +if (foo) { + bar(); +} + +the reason for this is that this is both less error-prone, and easier to put +temporary or permanent logging/etc statements inside the {}'s. + + + + + +A note on error handling +======================== +The software in this project is system critical software, to a degree where +failure really is not an option: + +The impact of the application failing is VERY SIGNIFICANT. + +For that reason, we need to take great care to get error handling robust, +and not make some medium level issue worse by failing the whole system. + + +Rule 1: In userspace, malloc() does not fail +-------------------------------------------- +(The Thiago rule of memory management) + +In userspace, malloc() simply does not fail. +"But But". We have 47 bits of address space to fill before malloc() would fail +due to being out of space. It just won't happen. + +Because of this, we're not going to check for, or handle, malloc() failures. +For one, in practice all you can do is exit, and the next line after +malloc() will crash the program with the same effect. + +And more than that, the error handling, that never will be used, complicates +the program code enormously and is impossible to test, and thus impossible +to get right. + + +Rule 2: Deal gracefully with expected failures +---------------------------------------------- +Some kind of errors are actually expected, normal conditions, and should be +handled sensibly, business as usual. For example, the lack of configuration +file should be handled silently by just using the system defaults. + + +Rule 3: Correct unexpected failures +----------------------------------- +Other kind of errors are not expected. These kind of errors must be *fixed* +as part of the error handling, so that the system can return to an expected +situation. Just passing the error up the call chain is rarely the right +answer, that just passes the buck to a part of the software that knows even +less about how to properly correct the failure. + +Example: If a configuration file was required, but none exists, the error +handling for this scenario should include writing out a reference +configuration file with default values filled in. + +Example: If you really want to handle a memory allocation failure, you must +free at least as much memory as you tried to allocate to allow the system to +make progress in its execution. diff --git a/configure.ac b/configure.ac new file mode 100644 index 0000000..404b1ae --- /dev/null +++ b/configure.ac @@ -0,0 +1,50 @@ +# -*- Autoconf -*- +# Process this file with autoconf to produce a configure script. + +AC_PREREQ([2.66]) +AC_INIT(usrbinjava, 2, dev@lists.clearlinux.org) +AM_INIT_AUTOMAKE([foreign -Wall -W subdir-objects]) +AM_SILENT_RULES([yes]) +AC_PROG_CC +AM_PROG_CC_C_O +AC_LANG(C) +AC_CONFIG_MACRO_DIR([m4]) +AC_CONFIG_HEADERS([config.h]) + +have_coverage=no +AC_ARG_ENABLE(coverage, AS_HELP_STRING([--enable-coverage], [enable test coverage])) +if test "x$enable_coverage" = "xyes" ; then + AC_CHECK_PROG(lcov_found, [lcov], [yes], [no]) + if test "x$lcov_found" = xno ; then + AC_MSG_ERROR([*** lcov support requested but the program was not found]) + else + lcov_version_major="`lcov --version | cut -d ' ' -f 4 | cut -d '.' -f 1`" + lcov_version_minor="`lcov --version | cut -d ' ' -f 4 | cut -d '.' -f 2`" + if test "$lcov_version_major" -eq 1 -a "$lcov_version_minor" -lt 10; then + AC_MSG_ERROR([*** lcov version is too old. 1.10 required]) + else + have_coverage=yes + AC_DEFINE([COVERAGE], [1], [Coverage enabled]) + fi + fi +fi +AM_CONDITIONAL([COVERAGE], [test "$have_coverage" = "yes"]) + +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT + +AC_MSG_RESULT([ + $PACKAGE_NAME $VERSION + ======== + + prefix: ${prefix} + libdir: ${libdir} + sysconfdir: ${sysconfdir} + exec_prefix: ${exec_prefix} + bindir: ${bindir} + datarootdir: ${datarootdir} + + compiler: ${CC} + cflags: ${CFLAGS} + ldflags: ${LDFLAGS} +]) diff --git a/findstatic.pl b/findstatic.pl new file mode 100644 index 0000000..3c6ba24 --- /dev/null +++ b/findstatic.pl @@ -0,0 +1,75 @@ +#!/usr/bin/perl -w +# find a list of fns and variables in the code that could be static +# usually called with something like this: +# findstatic.pl `find . -name "*.o"` +# Andrew Tridgell + +use strict; + +# use nm to find the symbols +my($saved_delim) = $/; +undef $/; +my($syms) = `nm -o @ARGV`; +$/ = $saved_delim; + +my(@lines) = split(/\n/s, $syms); + +my(%def); +my(%undef); +my(%stype); + +my(%typemap) = ( + "T" => "function", + "C" => "uninitialised variable", + "D" => "initialised variable" + ); + + +# parse the symbols into defined and undefined +for (my($i)=0; $i <= $#lines; $i++) { + my($line) = $lines[$i]; + if ($line =~ /(.*):[a-f0-9]* ([TCD]) (.*)/) { + my($fname) = $1; + my($symbol) = $3; + push(@{$def{$fname}}, $symbol); + $stype{$symbol} = $2; + } + if ($line =~ /(.*):\s* U (.*)/) { + my($fname) = $1; + my($symbol) = $2; + push(@{$undef{$fname}}, $symbol); + } +} + +# look for defined symbols that are never referenced outside the place they +# are defined +foreach my $f (keys %def) { + print "Checking $f\n"; + my($found_one) = 0; + foreach my $s (@{$def{$f}}) { + my($found) = 0; + foreach my $f2 (keys %undef) { + if ($f2 ne $f) { + foreach my $s2 (@{$undef{$f2}}) { + if ($s2 eq $s) { + $found = 1; + $found_one = 1; + } + } + } + } + if ($found == 0) { + my($t) = $typemap{$stype{$s}}; + if ($s eq 'main') { + # special case: main program + $found_one = 1; + } else { + print " '$s' is unique to $f, should be static? ($t)\n"; + } + } + } + if ($found_one == 0) { + print " all symbols in '$f' are unused (main program?)\n"; + } +} + diff --git a/src/filedesc.c b/src/filedesc.c new file mode 100644 index 0000000..f073c22 --- /dev/null +++ b/src/filedesc.c @@ -0,0 +1,75 @@ +/* + * Software Updater - client side + * + * Copyright © 2012-2015 Intel Corporation. + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, version 2 or later of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * + * Authors: + * Arjan van de Ven + * + */ + +#define _GNU_SOURCE +#include +#include +#include +#include +#include +#include + + +void dump_file_descriptor_leaks(void) +{ + DIR *dir; + struct dirent *entry; + + dir = opendir("/proc/self/fd"); + if (!dir) + return; + + while (1) { + char *filename; + char buffer[PATH_MAX + 1]; + entry = readdir(dir); + size_t size; + if (!entry) + break; + if (strcmp(entry->d_name, ".") == 0) + continue; + if (strcmp(entry->d_name, "..") == 0) + continue; + /* skip stdin/out/err */ + if (strcmp(entry->d_name, "0") == 0) + continue; + if (strcmp(entry->d_name, "1") == 0) + continue; + if (strcmp(entry->d_name, "2") == 0) + continue; + + /* we hold an fd open, the one from opendir above */ + sprintf(buffer, "%i", dirfd(dir)); + if (strcmp(entry->d_name, buffer) == 0) + continue; + + if (asprintf(&filename, "/proc/self/fd/%s", entry->d_name) <= 0) + abort(); + memset(&buffer, 0, sizeof(buffer)); + size = readlink(filename, buffer, PATH_MAX); + if (size) + printf("Possible filedescriptor leak : %s (%s)", entry->d_name, buffer); + free(filename); + } + + closedir(dir); +} diff --git a/src/main.c b/src/main.c new file mode 100644 index 0000000..e962837 --- /dev/null +++ b/src/main.c @@ -0,0 +1,47 @@ +/* + * usrbinjava - java wrapper + * + * Copyright (C) 2015 Intel Corporation. + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, version 3, with OpenSSL-exception. + * + * Alternatively, you can chose to redistribute and/or modifiy this + * software under the terms of the Apache-2.0 license as published + * by the Apache Software Foundation. + * + * If you want to contribute code to this project using only one, + * instead of both, of these licenses, you need to remove the other + * license text from this file as part of your contribution. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * Likewise, you should have received a copy of the Apache-2.0 license, + * which can also be found at http://www.apache.org/licenses/LICENSE-2.0 + * + * Authors: + * Arjan van de Ven + * + */ + +#define _GNU_SOURCE +#include +#include +#include +#include +#include + + +int main(int argc, char **argv) +{ + char java[4096]; + strcpy(java, "/usr/bin/false"); + + return EXIT_SUCCESS; +} diff --git a/template b/template new file mode 100644 index 0000000..8ee6c02 --- /dev/null +++ b/template @@ -0,0 +1,39 @@ +/* + * usrbinjava -- java wrapper + * + * Copyright (C) 2015 Intel Corporation. + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, version 3, with OpenSSL-exception. + * + * Alternatively, you can chose to redistribute and/or modifiy this + * software under the terms of the Apache-2.0 license as published + * by the Apache Software Foundation. + * + * If you want to contribute code to this project using only one, + * instead of both, of these licenses, you need to remove the other + * license text from this file as part of your contribution. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + * Likewise, you should have received a copy of the Apache-2.0 license, + * which can also be found at http://www.apache.org/licenses/LICENSE-2.0 + * + * Authors: + * Arjan van de Ven + * + */ + +#define _GNU_SOURCE +#include +#include +#include +#include +#include +