From a2ec305b46c1a2f292a720f4de449bdc1b4a135f Mon Sep 17 00:00:00 2001 From: Castulo Martinez Date: Thu, 6 Feb 2020 10:44:08 -0800 Subject: [PATCH] Warn user when a 3rd-party binary isn't executable This commit notifies the user that the 3rd-party bundle they installed isn't configured properly so they can know something about the quality of the 3rd-party repository they are using. Signed-off-by: Castulo Martinez --- src/3rd_party_bundle_add.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/3rd_party_bundle_add.c b/src/3rd_party_bundle_add.c index ff558ea9..aad98195 100644 --- a/src/3rd_party_bundle_add.c +++ b/src/3rd_party_bundle_add.c @@ -118,6 +118,7 @@ static enum swupd_code create_wrapper_script(char *filename) binary = sys_path_join(globals.path_prefix, filename); if (!sys_filelink_is_executable(binary)) { + warn("File %s does not have 'execute' permission so it won't be exported\n", filename); goto close_and_exit; }