From 434221d0eb6eb41972b56bfbbf6f95d45ae0a7c3 Mon Sep 17 00:00:00 2001 From: Burke Libbey Date: Tue, 13 Oct 2015 17:46:55 -0400 Subject: [PATCH] Fix --ipc=host dependency on /dev/mqueue existing Since #15862, containers fail to start when started with --ipc=host if /dev/mqueue is not present. This change causes docker to create container-local mounts for --ipc=host containers as well as in the default case. Signed-off-by: Burke Libbey --- daemon/container.go | 2 +- daemon/container_unix.go | 8 +------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/daemon/container.go b/daemon/container.go index 53807f90e..b31c40bd8 100644 --- a/daemon/container.go +++ b/daemon/container.go @@ -288,7 +288,7 @@ func (container *Container) Start() (err error) { return err } - if !container.hostConfig.IpcMode.IsContainer() && !container.hostConfig.IpcMode.IsHost() { + if !container.hostConfig.IpcMode.IsContainer() { if err := container.setupIpcDirs(); err != nil { return err } diff --git a/daemon/container_unix.go b/daemon/container_unix.go index 5864e7db7..ca15bedc4 100644 --- a/daemon/container_unix.go +++ b/daemon/container_unix.go @@ -215,12 +215,6 @@ func populateCommand(c *Container, env []string) error { ipc.ContainerID = ic.ID c.ShmPath = ic.ShmPath c.MqueuePath = ic.MqueuePath - } else { - ipc.HostIpc = c.hostConfig.IpcMode.IsHost() - if ipc.HostIpc { - c.ShmPath = "/dev/shm" - c.MqueuePath = "/dev/mqueue" - } } pid := &execdriver.Pid{} @@ -1408,7 +1402,7 @@ func (container *Container) setupIpcDirs() error { } func (container *Container) unmountIpcMounts() error { - if container.hostConfig.IpcMode.IsContainer() || container.hostConfig.IpcMode.IsHost() { + if container.hostConfig.IpcMode.IsContainer() { return nil }