diff --git a/daemon/volumes.go b/daemon/volumes.go index 3d6864b7d..867bbb44e 100644 --- a/daemon/volumes.go +++ b/daemon/volumes.go @@ -235,7 +235,7 @@ func parseVolumesFromSpec(daemon *Daemon, spec string) (map[string]*Mount, error if len(specParts) == 2 { mode := specParts[1] - if validMountMode(mode) { + if !validMountMode(mode) { return nil, fmt.Errorf("Invalid mode for volumes-from: %s", mode) } diff --git a/integration-cli/docker_cli_run_test.go b/integration-cli/docker_cli_run_test.go index 01a3f5763..e218430ce 100644 --- a/integration-cli/docker_cli_run_test.go +++ b/integration-cli/docker_cli_run_test.go @@ -389,7 +389,7 @@ func TestRunVolumesFromInReadWriteMode(t *testing.T) { t.Fatal(err) } - cmd = exec.Command(dockerBinary, "run", "--volumes-from", "parent", "busybox", "touch", "/test/file") + cmd = exec.Command(dockerBinary, "run", "--volumes-from", "parent:rw", "busybox", "touch", "/test/file") if _, err := runCommand(cmd); err != nil { t.Fatal(err) }