Fix a couple of places where we're trying to remove files from the files
list while we're iterating through it -- replicate the change elsewhere
to keep a temporary list of the files to remove, then iterate through
*that* list after iterating through the global files list.
In the event a commit contains invalid UTF-8 characters, replace them
with U+FFFD by using the 'replace' error handler for decode().
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
- FFLAGS/FCLAGS defaults were recently modified, so support both old and
new defaults.
- `rm -rf %{buildroot}` is another autospec default line for %install,
so it will never be a manual addition.
- The `name` field from options.conf is the same as the package name.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
Modification of Source0 is more trustworthy, since not all packages use
autospec. Also, (to me) the line stands out more when it appears at the
top of the spec file diff.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
Once this line is added to a package spec, it is likely to never show up
again, and its initial appearance may have a significant impact on the
build, so it is good to keep to not lose context.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
The for-review.txt files were being generated with `git show` and thus
not compatible with `git send-email`. Use `git format-patch` instead to
fix this issue.
Also add a more prominent notice about the existence of for-review.txt
and its intended purpose.
Signed-off-by: Patrick McCarty <patrick.mccarty@intel.com>
