As of go 1.14 JSON decoder no longer accepts invalid numbers.
https://golang.org/doc/go1.14#encoding/json
Switch Version to a new type and add Unmarshaler to handle the
type which allows unsigned integer or 'latest' as valid values.
Dropped required coverage by 1% for model.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Documentation and standard convention requires allowInsecureHTTP
to be camel-case, but the code and documentation were both incorrect.
Some users will need to update the YAML files if they already
had the incorrect 'AllowInsecureHttp' which is now 'allowInsecureHTTP'.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Change the PostArchive model type from bool to boolset to account
for default of true and state if the value was explicitly set.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Change the AutoUpdate model type from bool to boolset to account
for default of true and state if the value was explicitly set.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
New default is the creation of a /var/swapfile if not
swap partition is explicitly defined in the YAML file
or via Advanced Configuration.
Now use and report media sizes in XiB
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
The size of the swapfile can be set in the YAML file
and overridden by the command line argument.
Update for usage of XiB or XB units.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes: #517
Enable the possibility of no /boot partition in legacy mode.
- add warning if no /boot and legacy
Warn the user that installing in legacy mode without a /boot
partition means the install will never boot in UEFI mode.
- Force off 64bit mode
When an ext file system is used for the /boot content
(no /boot partition, and booting legacy mode) we need to
disable 64bit flag or the image file system not boot.
https://wiki.syslinux.org/wiki/index.php?title=Filesystem#ext
- Blocked use of XFS due to partition table requirement to use MBR.
- Do not allow encryption of / w/o /boot
Refactor validation code for reuse by both standard and advanced
disk partitioning. Add new standard Desktop and Server wrapper
functions.
Move validation to common function, remove from Find Targets, and
remove redundant validation function.
Enable the skip size for advanced partitions.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Add command line arguments and YAML file configurations for settings
skipping partition size checks during validation.
Skip Validation All implies Skip Size.
Never write skip validation options to YAML
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
We were attempting to run the telemetry command to opt out
on the target when the binary was not present.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes: #531
Add new hook to be called after image generation is completed.
Update base image test to use post-image hook
This is useful for image manipulation such as compression, format
modification, etc.
Add the publisher and the application/image type to the ISO.
- ApplicationId set to 'server' by default, 'desktop' if any
bundles are included which contain the name 'desktop.
- ApplicationId can be overridden via the YAML file
- Publisher only set if included in YAML file
Add new test coverage.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes: #600
Only copy the swupd configuration files from the host to the target
by default when running the interactive installer (gui or tui).
Otherwise, observe the setting from the configuration YAML or the
command line (highest) argument.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Ensure we do not allow the user to set options, either
via command line or in the default configuration file,
which would not be valid during an interactive installation.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
When converting an ister JSON configuration file to a
clr-installer YAML configuration file, we want to ensure
a single kernel is set. Additional kernel result in a
warning as ISO mainly due to ISO generation limitation
in the code.
Add new coverage test for multiple kernels.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Optionally included bundles (also-add) can now be omitted from the
install target by passing the --swupd-skip-optional flag or by setting
the swupdSkipOptional field in the config file.
Signed-off-by: John Akre <john.w.akre@intel.com>
Fixes: #559
Allow the format to be set in the configuration YAML file
as well as on the command line.
Useful for mixes.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes: #478
Add new --allow-insecure-http flag to support the use of HTTP URLs.
This is needed to allow swupd to download content from http sites;
generally development mixes.
Also enable the use of the setting in both the TUI and GUI to allow
the user to set a swupd mirror which is HTTP.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
When creating installer images with offline support, installation
content for a minimum set of bundles will be downloaded to the
/var/lib/clr-installer/offline-content directory inside the installer
image. The offline-content directory will be used instead of the network
to install bundles when it exists.
To generate images with offline support, the --offline command line
argument or the offline config file field can be set.
Signed-off-by: John Akre <john.w.akre@intel.com>
The targetBundles field in the config file specifies the minimum set of
bundles that the installer image's installer will install to the target
media. To achieve this functionality, a config file is generated and
inserted into the installer image at /var/lib/clr-installer.yaml. This
config file contains the list of bundles specified by targetBundles and
a minimum set of entries based on the config file used to generate the
installer image (keyboard, language, timezone, kernel).
Signed-off-by: John Akre <john.w.akre@intel.com>
This change removes the need for telemetrics bundle to be present for
the installer to work.
Signed-off-by: Alex Jaramillo <alex.v.jaramillo@intel.com>
Since we have code which assumes we want autoUpdate to be true
unless it is added to the YAML file, we need to be sure it is
write to the YAML when false.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
We should only store the telemetry answer when it was
user selected. This fix was needed due to the new advanced
configuration which save the temporary state.
Need to update the ister model for the new change.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
No easy way to test all of the error conditions of
Marshaling and Unmarshaling, so dropping the coverage by 1%
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
- model: Store precheck status in model
- Refactor sudo user into reusable function
- Enable the partitioning tool button
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Change InstallSelected to be a map with the key being
the name of the TargetMedias from the model to support
installing across multiple disks.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
This is needed to ensure proper locking while running the external
tool for disk partitioning for Advanced disk configuration during
interactive installations.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
graphical will crash if you "confirm" without a value
for the kernel command line.
Also fixed the same bug in the text-based interface.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
For documentation purposes (screen shots), we do not want to
include the version string. Having a version string in the image
requires updating all image each release.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Create the command line argument and configuration file changes
to support generating an ISO from the raw image.
TODO: Integrate the ISO generation code
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Safe: gpt disk with sufficient space
Destructive: All media (expect mounted)
Modify: all gpt disks
When adding new partitions, ensure we store the new
partition number and update the device name.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes Issue: #261
Pull Request #236 introduced a bug where local network interfaces
are always copied to the target media.
This PR correct this by only copying when copyNetwork is set to
true; this is enabled in the UI when the users changes a network
interface (for static).
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
Fixes Issue: #242
Only show user selected bundles on the summary menu item for
bundle selection; not core, required bundles.
Make the latest user bundle changes more evident by prepending
them to the list of bundles to install.
Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
William Douglas